From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CA6DC43334 for ; Thu, 9 Jun 2022 19:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7jtEbSPqxZdO4HjQDcDYCXVw4Pnvs43y/M3ynHaA/Pk=; b=Vtb0xtUDjuqmMrP0PZPPLWhXtG olED7RyqY3v+8Xh33r1lnQzHd9QbnRyjspnnmgN3Zu2l9/AQj18Bd1vKClPPaCFKiiKaJyecDhLoS nnbyACNgcBUj5cs8f7zjfspX24/N9D19BJ3lENayHt468elA5h3ChXxtVs0yJuD1ee2v+vrm9LvdU U/WOmU7+AouWtW7neZGYxhLJNlQyoNBX8E2vejLW/Sr3tfc12ZC9B1/PNvZS5/wXtLmNsH98NPgfU T3nc0KW6gADPi2u3f6ZysAp4jEQqynIzUpMqIWGz6JeJAFj5ugLsHDzHpPLA9nAy2hXVa4BSy0kWz DpAxgi0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzNa4-003nCE-Ol; Thu, 09 Jun 2022 19:12:32 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzNa1-003n9l-Ij for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 19:12:30 +0000 Received: by mail-yb1-xb49.google.com with SMTP id v127-20020a256185000000b0065cbe0f6999so20898938ybb.22 for ; Thu, 09 Jun 2022 12:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=FSSm+9bvhgEmW3qoBTTPNjVhREVEJPEtoEmaPEajWR0=; b=rheQX3q5gm+JqSEPnyXRm/4V7W847eNbvPvWjho1z5A7iYu9qZG/QjrtIcm4n1niXG rJROrAAjr6HekwElPZeErWzAOok/nOt063R5M8MoppcY4F4jY+4KzKSc6gk2rAS4IuQ6 b0l47RWbk1Z/tTPflBmxlJKWLgVes51IP+opL/9jJT5IyyreMc+B5NLAjeh1RnODi91E 0xZdl4+3VAXQH7OmL+yCPxVxcx6yJ2kEGSaqY8kSJWQ7YY2h1RdKTHdEXHPeBPXQxhE9 sDpJ3yJwReNTK8lhgDhf7cTLR/6tuDelqot4KYeJjucgP8LFzBg0+UgnNy2626a5sz+U /Qfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FSSm+9bvhgEmW3qoBTTPNjVhREVEJPEtoEmaPEajWR0=; b=g0MzUNQMSJfRmJz95CqcZK97KFPZsmTwxkj4zZ4qlMd7MQK7KkDgEjZ0wvMbCTWduT WhAM3eg4yFtUV3fjYA8lcRh+6f14l1w3pokUhfLaOc+g0/gQHrjqSp/cUaMOui/jvFkw lBxPIsS56DKeAjWKBfPQxa6sT8LufVdRFCnX49aakD+rP/vnxSop2h5BeEV4K3f8LrRd X6GqKXXtntJic5MjmwG3sHw8KNao2nK7W+9SiLscHM2Pe/59wHF+e9DKh7nN+srItAXe QZlPMcq6zgIKF2Vvi9CR0GD0/H8Eefv18cI0jwZGU6Gbcc5K4ughg3DpZ77rpQhtOgT9 CqDw== X-Gm-Message-State: AOAM531qagQqm2g4Vz+kBzin/3MfJQ7A9EdxhOdv08ef1r5Tj0caP0x/ RQEa9LT/yE/Gmw9lln0HQ7LT59dasS/uXQ== X-Google-Smtp-Source: ABdhPJw9v05gr7h/UJrl5rkXxevCDgUr4Asf4N2CtmyR5iQlnR4H5kPQPxLJNhwA7fsw2jUyVZVcUJ8whLMNQA== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a25:d803:0:b0:663:3da5:9813 with SMTP id p3-20020a25d803000000b006633da59813mr29071178ybg.530.1654801944110; Thu, 09 Jun 2022 12:12:24 -0700 (PDT) Date: Thu, 9 Jun 2022 19:12:21 +0000 In-Reply-To: Message-Id: <20220609191221.rv3lqbhipnvvzt67@google.com> Mime-Version: 1.0 References: Subject: Re: [next] arm64: boot failed - next-20220606 From: Shakeel Butt To: Roman Gushchin Cc: Naresh Kamboju , Linux-Next Mailing List , open list , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Linux ARM , linux-mm , Stephen Rothwell , Andrew Morton , Ard Biesheuvel , Arnd Bergmann , Catalin Marinas , Raghuram Thammiraju , Mark Brown , Will Deacon , Vasily Averin , Qian Cai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_121229_651540_4C3DD9B2 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 09, 2022 at 10:56:09AM -0700, Roman Gushchin wrote: > On Thu, Jun 09, 2022 at 10:47:35AM -0700, Shakeel Butt wrote: > > On Thu, Jun 9, 2022 at 10:27 AM Roman Gushchin wrote: > > > > > [...] > > > +struct mem_cgroup *mem_cgroup_from_obj(void *p) > > > +{ > > > + struct folio *folio; > > > + > > > + if (mem_cgroup_disabled()) > > > + return NULL; > > > + > > > + if (unlikely(is_vmalloc_addr(p))) > > > + folio = page_folio(vmalloc_to_page(p)); > > > > Do we need to check for NULL from vmalloc_to_page(p)? > > Idk, can it realistically return NULL after is_vmalloc_addr() returned true? > I would be surprised, but maybe I'm missing something. is_vmalloc_addr() is simply checking the range and some buggy caller can provide an unmapped address within the range. Maybe VM_BUG_ON() should be good enough (though no strong opinion either way). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel