From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E1B1C433EF for ; Sun, 12 Jun 2022 10:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qXg1Yq/1/1yHKL+Hr7VSJJLCv9hCHK2wy0UYHbAY3bc=; b=pXoY8f60TRA+Mi kJcR4xC8osO0808SC2jq1UzCjEE+s1gbyeILFt3nPwHY54qZDZtyHsq9Pe7JIhEyzcMhyIlfyH2rc 9m/5A/g7F6bhO0AbTYUlsRYFqjDFQPA0ufemr4glaGnw/ZsQcassNAr/+NhhsbMPMRzHnO++EAnR0 pGYcBS3vtc3UrIY6RLeW1awPo3hF/oWvrcnEesTPs1GcBieUYkZVDBqpy54BEZ1LFbDQHKgujLcD2 Ir0Hsxn5tFbRGOOiHi+1woP+EdsJM2atMuZorU/jNSUMF1NHGXBP7/QfmmVSE4rCBuTUqXZrSb3Xe ejRNrqf41f1uPQOxkB3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0L4q-00GJDo-7f; Sun, 12 Jun 2022 10:44:16 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0L4n-00GJBd-26 for linux-arm-kernel@lists.infradead.org; Sun, 12 Jun 2022 10:44:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655030653; x=1686566653; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oY4m7/TA+RKNO4Qsg0G2e91Q7hQxCUmosIWjYQ/l6PU=; b=AjXcRe/uiEr0rp70LV5fOhA0zWAb2D5JpK4IiWQCZJSE7KYLzi7pY+6Q IMp9+wK4oXgBwwdbhxIyLspzHsKJuL4SHdMuDgRXn7hcU+ujt5VctteAM Bkd014P16LcM0qwEdo0JQNTH0oDmJ6F5kkDCNg+JSDET3WHSXkVYAxX71 yjNXuk/tWuuKR1ysD5puJPsXcB/UV9PmoRHr47PR+n4nnqfOttB/Fj/u8 JYl2n+dVlDlMkjSgGnt8EkACjtLRhyJ3RElSxbvVux3eSwRgDKxyFr0N+ Ltf73yrCgeY2Hl946NvVq1g8I0fVdF+mkz4a97bQ24JY4p/ndDUZxfx7d Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10375"; a="279099712" X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="279099712" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 03:44:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="611340376" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 12 Jun 2022 03:44:05 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o0L4e-000Jqt-Dd; Sun, 12 Jun 2022 10:44:04 +0000 Date: Sun, 12 Jun 2022 18:43:47 +0800 From: kernel test robot To: Qin Jian , sboyd@kernel.org Cc: kbuild-all@lists.01.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, mturquette@baylibre.com, linux@armlinux.org.uk, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Qin Jian Subject: Re: [PATCH v17 05/10] clk: Add Sunplus SP7021 clock driver Message-ID: <202206121806.C2ECo2lB-lkp@intel.com> References: <65ef2bf7fc393eb373b966fe839852bcd1bacad8.1654565776.git.qinjian@cqplus1.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <65ef2bf7fc393eb373b966fe839852bcd1bacad8.1654565776.git.qinjian@cqplus1.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220612_034413_189808_34018E95 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on pza/reset/next] [also build test WARNING on robh/for-next clk/clk-next tip/irq/core linus/master v5.19-rc1 next-20220610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20220607-100746 base: https://git.pengutronix.de/git/pza/linux reset/next config: microblaze-randconfig-c024-20220612 (https://download.01.org/0day-ci/archive/20220612/202206121806.C2ECo2lB-lkp@intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot cocci warnings: (new ones prefixed by >>) >> drivers/clk/clk-sp7021.c:584:2-7: WARNING: invalid free of devm_ allocated data vim +584 drivers/clk/clk-sp7021.c 550 551 static struct clk_hw *sp_pll_register(struct device *dev, const char *name, 552 const struct clk_parent_data *parent_data, 553 void __iomem *reg, int pd_bit, int bp_bit, 554 unsigned long brate, int shift, int width, 555 unsigned long flags) 556 { 557 struct sp_pll *pll; 558 struct clk_hw *hw; 559 struct clk_init_data initd = { 560 .name = name, 561 .parent_data = parent_data, 562 .ops = (bp_bit >= 0) ? &sp_pll_ops : &sp_pll_sub_ops, 563 .num_parents = 1, 564 .flags = flags, 565 }; 566 int ret; 567 568 pll = devm_kzalloc(dev, sizeof(*pll), GFP_KERNEL); 569 if (!pll) 570 return ERR_PTR(-ENOMEM); 571 572 pll->hw.init = &initd; 573 pll->reg = reg; 574 pll->pd_bit = pd_bit; 575 pll->bp_bit = bp_bit; 576 pll->brate = brate; 577 pll->div_shift = shift; 578 pll->div_width = width; 579 spin_lock_init(&pll->lock); 580 581 hw = &pll->hw; 582 ret = devm_clk_hw_register(dev, hw); 583 if (ret) { > 584 kfree(pll); 585 return ERR_PTR(ret); 586 } 587 588 return hw; 589 } 590 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel