From: Christoph Hellwig <hch@lst.de>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ardb@kernel.org>, Christoph Hellwig <hch@lst.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 2/2] arm64: mm: Remove assembly DMA cache maintenance wrappers
Date: Mon, 13 Jun 2022 07:53:43 +0200 [thread overview]
Message-ID: <20220613055343.GA32221@lst.de> (raw)
In-Reply-To: <20220610151228.4562-3-will@kernel.org>
On Fri, Jun 10, 2022 at 04:12:28PM +0100, Will Deacon wrote:
> Remove the __dma_{flush,map,unmap}_area assembly wrappers and call the
> appropriate cache maintenance functions directly from the DMA mapping
> callbacks.
Thanks, this looks so much nicer. Is there any good reason why
the C prototypes for the assembly function take an unsigned long
instead of a void *, though? It seems like all or almost all of
the callers have a pointer at hand an do silly casts for the assembly
code that could work perfectly fine with a pointer and length.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-13 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:12 [PATCH 0/2] arm64: mm: Fix cache maintenance for non-coherent streaming DMA Will Deacon
2022-06-10 15:12 ` [PATCH 1/2] arm64: mm: Don't invalidate FROM_DEVICE buffers at start of DMA transfer Will Deacon
2022-06-10 15:12 ` [PATCH 2/2] arm64: mm: Remove assembly DMA cache maintenance wrappers Will Deacon
2022-06-13 5:53 ` Christoph Hellwig [this message]
2022-06-17 18:07 ` Catalin Marinas
2022-06-11 8:01 ` [PATCH 0/2] arm64: mm: Fix cache maintenance for non-coherent streaming DMA Ard Biesheuvel
2022-06-17 18:25 ` (subset) " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613055343.GA32221@lst.de \
--to=hch@lst.de \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).