From: Sudeep Holla <sudeep.holla@arm.com>
To: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Cc: mst@redhat.com, jasowang@redhat.com, cristian.marussi@arm.com,
Sudeep Holla <sudeep.holla@arm.com>,
quic_sramana@quicinc.com, vincent.guittot@linaro.org,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] dt-bindings: arm: Add document for SCMI Virtio backend device
Date: Mon, 13 Jun 2022 18:33:48 +0100 [thread overview]
Message-ID: <20220613173348.t4ibrtzzs5pe6nii@bogus> (raw)
In-Reply-To: <20220609071956.5183-2-quic_neeraju@quicinc.com>
On Thu, Jun 09, 2022 at 12:49:54PM +0530, Neeraj Upadhyay wrote:
> Document the properties for ARM SCMI Virtio backend device
> node.
>
> Signed-off-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
> ---
> .../firmware/arm,scmi-vio-backend.yaml | 85 +++++++++++++++++++
> 1 file changed, 85 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
> new file mode 100644
> index 000000000000..c95d4e093a3c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi-vio-backend.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/arm,scmi-vio-backend.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: System Control and Management Interface (SCMI) Virtio backend bindings
> +
> +maintainers:
> + - Neeraj Upadhyay <quic_neeraju@quicinc.com>
> +
> +description: |
> + This binding defines the interface for configuring the ARM SCMI Virtio
> + backend using device tree.
> +
> +properties:
> + $nodename:
> + const: scmi-vio-backend
> +
> + compatible:
> + const: arm,scmi-vio-backend
> +
One only change between this and the existing DT binding is the compatible.
I don't see any explanation here as why this deserves to be separate binding
document. What can't you just add the compatible to the existing one if there
is no other change. If not, please provide details and examples on how it
differs.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-13 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 7:19 [RFC 0/3] SCMI Vhost and Virtio backend implementation Neeraj Upadhyay
2022-06-09 7:19 ` [RFC 1/3] dt-bindings: arm: Add document for SCMI Virtio backend device Neeraj Upadhyay
2022-06-13 17:33 ` Sudeep Holla [this message]
2022-06-09 7:19 ` [RFC 2/3] firmware: Add ARM SCMI Virtio backend implementation Neeraj Upadhyay
2022-06-09 7:19 ` [RFC 3/3] vhost/scmi: Add Host kernel accelerator for Virtio SCMI Neeraj Upadhyay
2022-06-13 17:20 ` [RFC 0/3] SCMI Vhost and Virtio backend implementation Cristian Marussi
2022-06-30 13:54 ` Vincent Guittot
2022-07-09 3:28 ` Mike Tipton
2022-07-27 4:17 ` Neeraj Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613173348.t4ibrtzzs5pe6nii@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=quic_neeraju@quicinc.com \
--cc=quic_sramana@quicinc.com \
--cc=vincent.guittot@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox