From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46FA8C43334 for ; Tue, 14 Jun 2022 05:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y1EH3spz6O7w0lAF6FTi10MXcqDBfCnXz9wsM2bD2kY=; b=4X6bd6wqU+YW7C OHa3ld/GL9jPXpWptOYxYa8OnXedzvccq0LxQjxB5fLS28+plbuNidhy5QfpUhBqQCPVZC0QJvDQ6 og+gVsWdsh7hRdCNR4nUPaPPY/ZeNuj6aIhgLk8rfMD3H7851Y5yFgFkNxCUhyYuDUmazEW6eoiNO 2qKTqUMrOIbdyReNQGf3nDHBLhhW0zwwV5+ehpeSC+nOHmlXWEVX+zwdnivUHcDcETyWObmgPvDt4 xsXCHREH0Y1ql8ZoSJEEw2IMmeeUKXzL3uyfhCLZUeiM67C/rN0hC5S8cXxweCCdwzj+eVQVntMwF e6/7kZYqNLUkL+yRpROg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0zQZ-007941-No; Tue, 14 Jun 2022 05:49:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0zQW-007939-EU for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 05:49:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3714B61678; Tue, 14 Jun 2022 05:49:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24DAFC3411B; Tue, 14 Jun 2022 05:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655185758; bh=R+0qAAX6efv+AygD/S2OgXLLIy/Y/Bbh3wzi0ZGiAWQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PYNoPUtL9o4blp5GFVcqKknV93aauo63yGEnKIVW30K7HR/1jkDXld2d/XUhxx6/2 239sw6OgsseZPYwoxf+GT3DKTYlqIcPibec6wchik4vBaRsXllag2VIz0DPZjEpah2 yRvOqdBds2oqlZC4fmDYQv/WSMEAWOG3HBLObpjFRlykmKy95Gku+w77MOGKLYDxTy qZ8WhEnd9eavxACzB+XBITuOTmBK4sS87kRdCSuEoB+pWIEvoqHQT2R3DAg3E0v5uO sIsdRkmRM/VGX8V8mnxPb+1d6DE4PG1YkZOjC4vztpSEbOY5iu5v9DTcNLTISR1vYg t5QOZCjsc0QPg== Date: Mon, 13 Jun 2022 22:49:17 -0700 From: Jakub Kicinski To: Christian 'Ansuel' Marangi Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Mentovai Subject: Re: [net-next PATCH 2/2] net: ethernet: stmmac: reset force speed bit for ipq806x Message-ID: <20220613224917.325aca0a@kernel.org> In-Reply-To: <20220609002831.24236-2-ansuelsmth@gmail.com> References: <20220609002831.24236-1-ansuelsmth@gmail.com> <20220609002831.24236-2-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_224920_567591_A3AD7EE3 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 9 Jun 2022 02:28:31 +0200 Christian 'Ansuel' Marangi wrote: > + dn = of_get_child_by_name(pdev->dev.of_node, "fixed-link"); > + ret = of_property_read_u32(dn, "speed", &link_speed); > + if (ret) { > + dev_err(dev, "found fixed-link node with no speed"); > + return ret; Doesn't this return potentially leak the reference on dn? You move the of_node_put() right before the if (ret) { > + } > + > + of_node_put(dn); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel