From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26BA6C43334 for ; Tue, 14 Jun 2022 10:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wV+QNujLyXvD7y66GoyH4rtDcEcSztLUFCGod9KfEWc=; b=qr9bhjxv7eyyVt dhzZzO+/wo9cz5QYJCGlVRf2mJUZsDdEl0jHQfmWCs7hBMPSm4n6vGbROTzCK21zPUdYGul7cO1Yb Y5fV6Tecj07oJeGzH3fFv5ZE9SQlc0K6Eva1bWp1ATUqQr6x7bPHbS1zcc8lIUEFcDlBDXWILMpiN eWB4UyXQNcG0yTZvifJrtxfRe2yoJVoXNlWX31MGD5YGipjsowK/vJk++XzIRewlhXtliNAyA+Dqg fSt8R0zuG7uXoVYbdOyNkskOpgrF+pZFlD8mKVuKk5lMp+VglB1otIgQmvMSuUl9YSu699N0f3Djf sk10akRfIJsMOpgZWQCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o13ca-008zCN-P5; Tue, 14 Jun 2022 10:18:05 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o13cV-008z9q-J1 for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 10:18:01 +0000 Received: by mail-ej1-x62a.google.com with SMTP id o7so16233038eja.1 for ; Tue, 14 Jun 2022 03:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7A7nTmdaI9/bcr+2R0SqLAb+aR5IHo7VJJCTzS5ZF6s=; b=HWVuub0cau9MEvLNm1/l0bFz9qGQTxJJVGMyDa0eazCpvT+V1EJ+579Ljji9OjeT4K utpCbQRbb3gSMMlMc23ZZnBR9baABXEhxSWsRmVFDTnZwKtnMyyuDvKB6d9a0uyLgy/y XFOhOM+ZbJdk3t0BJ7Yfo3kXHyXJyyF9360SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7A7nTmdaI9/bcr+2R0SqLAb+aR5IHo7VJJCTzS5ZF6s=; b=6knamuBrioesVpZXIvqR+AUzNnKUpxO5fqi7+k9GKeRSEwVliVNW0rIqzOXTlKFORZ dF2P8c0a6gsnuD5nYMicHq71PylHObwRzrBACkB1l5Uxc1T/UjjFybTVMWyJ8toduLGh QR6plwH9VXRV06jNgVtPT4Ok8THWKCc50WaOGcPYRdS5E1tFa6h6QBXVNV+C3InXsLS6 IEAODq/wMQ38/t3LYinMWwJ1TIkiajRnyVJkCxhlbCZPBP/URDIB7mFJ5ol0l44P+mdM kERTwH/Bgq5y5sA+p/qGdp2gMgalsrxa0+H2WUg5EWtpiWTmvDYmZA1/SoYxs1KV+jfl oHfg== X-Gm-Message-State: AOAM531leUay8MRTwrW7p8M0y2I8tGpNIRaD7+61mowujip3S6/TyaWS caQBCBARgrf5o/J+XhyMfS2ikQ== X-Google-Smtp-Source: AGRyM1uSGDUHuyUQPJNZ4pVQMMzgj9Aj3XhH2tdLGyOUMiYZyrozh51lRXj+PKvb4y9+ZonVCHMDJw== X-Received: by 2002:a17:907:d24:b0:712:1142:88c7 with SMTP id gn36-20020a1709070d2400b00712114288c7mr3673468ejc.435.1655201876750; Tue, 14 Jun 2022 03:17:56 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-80-116-90-174.pool80116.interbusiness.it. [80.116.90.174]) by smtp.gmail.com with ESMTPSA id dx6-20020a170906a84600b007094f98788csm4878838ejb.113.2022.06.14.03.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 03:17:56 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Michael Trimarchi , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] dmaengine: mxs: fix driver registering Date: Tue, 14 Jun 2022 12:17:51 +0200 Message-Id: <20220614101751.3636028-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_031759_697099_9F907CF7 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Driver registration fails on SOC imx8mn as its supplier, the clock control module, is not ready. Since platform_driver_probe(), as reported by its description, is incompatible with deferred probing, we have to use platform_driver_register(). Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Cc: stable@vger.kernel.org --- Changes in v3: - Restore __init in front of mxs_dma_init() definition. Changes in v2: - Add the tag "Cc: stable@vger.kernel.org" in the sign-off area. drivers/dma/mxs-dma.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index 994fc4d2aca4..6e90540fedc4 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c @@ -741,7 +741,7 @@ static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec, ofdma->of_node); } -static int __init mxs_dma_probe(struct platform_device *pdev) +static int mxs_dma_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; const struct mxs_dma_type *dma_type; @@ -839,10 +839,7 @@ static struct platform_driver mxs_dma_driver = { .name = "mxs-dma", .of_match_table = mxs_dma_dt_ids, }, + .probe = mxs_dma_probe, }; -static int __init mxs_dma_module_init(void) -{ - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe); -} -subsys_initcall(mxs_dma_module_init); +module_platform_driver(mxs_dma_driver); -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel