From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1ED4C43334 for ; Tue, 14 Jun 2022 11:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hqLDter+oc9e8UIY3ecUFeRo5fDYJ6wA7qS1771jZ4s=; b=Ohn4gUF7Y9Atoa sg3i7xFiKKDgQRydKaUrsczXO4Bwf+0Q02otBalgBKsWFy20U/d7CLHBwScu/dXoiU5orutapLSB8 +rGgj5Db2QglUeoqGwgwySrJObEwpO3VRHbNm38/j3bWv2In/SuakSLRn9DQxO+Tg/2Gmb5joJrvY vNcBLVXbxiHzFAtwn27RIDqIrFE3F03jE9JJBMAKmYwtispE0eLahbUzeZqCqggoQSVasGg5tlR4J cFEqsWb1vYm28HRf5K2Y3PROYc5XNyqv6DbW3p1biJe5iwvpjuNbozEgtLNa5eBbE5UW2M6Xk7AZN rmq3J5fuWKYB6cr9fH8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o154j-009Jxr-Av; Tue, 14 Jun 2022 11:51:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o154g-009Jwz-Ht for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 11:51:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3CFA6132D; Tue, 14 Jun 2022 11:51:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A09FDC3411E; Tue, 14 Jun 2022 11:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655207469; bh=UxMFgBxh+tLcHM5HY/sBLNk+B5l+uHI+DjprsoQaKfQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C+DlCtMINgCiNNF9rNUlecR2G32rSU4NLuvtySoVFh/6oAgnIWe3ZYXBRTrOPeZWJ 0Ltef+a3Kq4u2ku9YRwnyGpmNuhUD50TEUw/NyY33zdeUqgDZTlrH6+Ow6YEm+XpDK b0F/19JHx+p1eE9isQGl+y3KO3LQkx2vx06EY5HagcW9lRJEkxvV+KQThvIhdTeeLT e8z1Z7ih0Uq1ljJJsp9nfpk2KisfhzU3HJyRKW19tEsnj52/pTJ3KIyXjE0oLqUqEr EeiFJ/rapseiDbAJgTXGKt5NKQXWQxow+IXjSlsN+TIgVs9CxahEBnE65ff/DA6D5x fEqWQZ0nCadOQ== Date: Tue, 14 Jun 2022 13:00:18 +0100 From: Jonathan Cameron To: Subject: Re: [PATCH 07/16] iio: adc: at91-sama5d2_adc: simplify the code in at91_adc_read_info_raw() Message-ID: <20220614130018.4b29345d@jic23-huawei> In-Reply-To: <14fc4d7c-4ce7-e4ed-3e2e-400cbd16c071@microchip.com> References: <20220609083213.1795019-1-claudiu.beznea@microchip.com> <20220609083213.1795019-8-claudiu.beznea@microchip.com> <20220611185403.3eaf9b65@jic23-huawei> <14fc4d7c-4ce7-e4ed-3e2e-400cbd16c071@microchip.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_045110_681661_6C091424 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, ludovic.desroches@atmel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Eugen.Hristev@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Jun 2022 08:49:03 +0000 wrote: > On 11.06.2022 20:54, Jonathan Cameron wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Thu, 9 Jun 2022 11:32:04 +0300 > > Claudiu Beznea wrote: > > > >> Simplify a bit the code in at91_adc_read_info_raw() by reducing the > >> number of lines of code. > >> > >> Signed-off-by: Claudiu Beznea > > > > I'm not convinced this is worth while, but there are some lesser > > steps visible in this patch that probably are. > > > > Given your earlier reorg to move at01_adc_adjust_val_osr() under the locks, > > you can now move the locks to the caller, thus not needing to handle them > > separately in all the exit paths. > > OK, I'll give it a try. With this, would you prefer to still keep this patch? > No. I don't think it will bring enough benefit for the loss of readability. Having moved the locking, there will only be a few repeated lines. Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel