From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84B6DC43334 for ; Tue, 14 Jun 2022 20:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OV+iiKDfsZAaVozREhBs+/p+6eLieFWiLcxgikZnbvY=; b=3FBxKZeYJ3y2JP Zc1QRbGlfQ7bB0uYFKAR3SVdcq558IvUae16Gfm6BCob+6OuaQyIiGoj/0qxZDhcylVaEQexkfxdi IqEBAQWrtegivYaxnW/wwee2CnUVDWhc6r3JmW75Z5yztSzUPYoZ8Nl7jLhqQryL/YIaTSlq/pNg8 i42zOV+piVdbrQOMtxqvIO2Oz0ZUVEqAf9JUtpGCp0UXPObPPkKAQkwk2wH/A6BrV7Z096PW3UFrK 6Xp4IEGsRHv3pwpSDWQns7akRcsCP87V3M/tVxWQdV6tUA/CErHcD3NAc22p6MEoLTdkrDE5c5T0d knytDqUUbxW2e6V5paGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1CtL-00B4VD-Cw; Tue, 14 Jun 2022 20:11:59 +0000 Received: from mail-io1-f53.google.com ([209.85.166.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1CtG-00B4RN-V6 for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 20:11:57 +0000 Received: by mail-io1-f53.google.com with SMTP id 19so10564801iou.12 for ; Tue, 14 Jun 2022 13:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9/XBqejShhBsGHynRMK/NnFFuohdRCp1F64DE0/PIZM=; b=qzdmUbnCvy6rMpIQO7m0M1nVG8PFoxTCV9vDtmSu0TLJT5BO66IpfY9mNGBBf59hBE ZDCxPh4xjA9Nc35eGtZ1k7vxbBgozbIVxATHgdhBbNxeapfj5sCM1wW8nrAR2ZYRnHKO RXDV6CR5QL6k/ed4ZkqodAaK7JeMvV3Arll4MphbX6UoZHbjPp+acD3H5lntL/Olf8Xl ZHygaJxBLpK66uHe512G6RlcRfjAxPPfGAXUzQhrMQgifgv43KPLVAVnbu/zJ/7WAjnw L9Is23/oeF7KWfqVwzlFx6z7rE96Cs9KVMiganTvABVl5nZsIp1OHdR2BRIRgX86bZs9 JjEw== X-Gm-Message-State: AOAM530cyQcHGptiXr39MNH+rzUziLgw64uzjDNYQW0bsOzX5FLdgl4R 4hqRV60nCAswS2PFxrza2g== X-Google-Smtp-Source: ABdhPJxWEsmo+mG/x3kXLODUtDKPZ8ETebE3K2+pKnnHvBgtT4SiuVSTIClpZz5EwzbOKjOIAfOuqA== X-Received: by 2002:a6b:6a07:0:b0:66a:2e5f:2058 with SMTP id x7-20020a6b6a07000000b0066a2e5f2058mr929393iog.72.1655237509097; Tue, 14 Jun 2022 13:11:49 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id t6-20020a025406000000b00331c8618d2esm5249796jaa.143.2022.06.14.13.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 13:11:48 -0700 (PDT) Received: (nullmailer pid 2359572 invoked by uid 1000); Tue, 14 Jun 2022 20:11:46 -0000 Date: Tue, 14 Jun 2022 14:11:46 -0600 From: Rob Herring To: Liu Ying Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, lee.jones@linaro.org, mchehab@kernel.org, marcel.ziswiler@toradex.com Subject: Re: [PATCH v9 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Message-ID: <20220614201146.GA2344044-robh@kernel.org> References: <20220611141421.718743-1-victor.liu@nxp.com> <20220611141421.718743-6-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220611141421.718743-6-victor.liu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_131155_033763_22F5ADB5 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 11, 2022 at 10:14:12PM +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Signed-off-by: Liu Ying > --- > v8->v9: > * Add 'fsl,dc-id' and 'fsl,dc-stream-id' properties. (Laurent) Why? Isn't the graph sufficient for determining the connections? That's what it is for. > * Drop Rob's R-b tag. > > v7->v8: > * No change. > > v6->v7: > * No change. > > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > > v1->v2: > * Use graph schema. (Laurent) > * Require all four pixel link output ports. (Laurent) > * Mention pixel link is accessed via SCU firmware. (Rob) > > .../bridge/fsl,imx8qxp-pixel-link.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > new file mode 100644 > index 000000000000..38ecc7926fad > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8qm/qxp Display Pixel Link > + > +maintainers: > + - Liu Ying > + > +description: | > + The Freescale i.MX8qm/qxp Display Pixel Link(DPL) forms a standard > + asynchronous linkage between pixel sources(display controller or > + camera module) and pixel consumers(imaging or displays). > + It consists of two distinct functions, a pixel transfer function and a > + control interface. Multiple pixel channels can exist per one control channel. > + This binding documentation is only for pixel links whose pixel sources are > + display controllers. > + > + The i.MX8qm/qxp Display Pixel Link is accessed via System Controller Unit(SCU) > + firmware. > + > +properties: > + compatible: > + enum: > + - fsl,imx8qm-dc-pixel-link > + - fsl,imx8qxp-dc-pixel-link > + > + fsl,dc-id: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: | > + u8 value representing the display controller index that the pixel link > + connects to. > + > + fsl,dc-stream-id: > + $ref: /schemas/types.yaml#/definitions/uint8 > + description: | > + u8 value representing the display controller stream index that the pixel > + link connects to. > + enum: [0, 1] > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: The pixel link input port node from upstream video source. > + > + patternProperties: > + "^port@[1-4]$": > + $ref: /schemas/graph.yaml#/properties/port > + description: The pixel link output port node to downstream bridge. > + > + required: > + - port@0 > + - port@1 > + - port@2 > + - port@3 > + - port@4 > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qxp-dc-pixel-link > + then: > + properties: > + fsl,dc-id: > + const: 0 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8qm-dc-pixel-link > + then: > + properties: > + fsl,dc-id: > + enum: [0, 1] > + > +required: > + - compatible > + - fsl,dc-id > + - fsl,dc-stream-id > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + dc0-pixel-link0 { > + compatible = "fsl,imx8qxp-dc-pixel-link"; > + fsl,dc-id = /bits/ 8 <0>; > + fsl,dc-stream-id = /bits/ 8 <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* from dc0 pixel combiner channel0 */ > + port@0 { > + reg = <0>; > + > + dc0_pixel_link0_dc0_pixel_combiner_ch0: endpoint { > + remote-endpoint = <&dc0_pixel_combiner_ch0_dc0_pixel_link0>; Isn't dc0 and link0 here the same information (if you get the port number from the remote end). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel