From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEFF2C433EF for ; Tue, 14 Jun 2022 21:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nNp2GKWsr5z5Ie8if03IRZPQNqwk/nenme18PxOvlMQ=; b=gwYcs8LYl04OjJ D1wu9j1HLH6j6IjDeRBY4ku9m7pYLg2Bisc/TcSshxsXJhAvXJ1gz3iqDX0IqMJ70GlWvngJ3NxfZ D5WAguoCfmy3Xs72le9EIi0M5aGYSUBgTlDU1H9HYfQ51fC2b7cqpcLlINvG/pOmL5senGweWbFVf lPEGRS3yCtobjauIBwvrGXN3RjOwAe+tTzDA21w1KramVysY/rqsjhoYA6VEKnwZQVjlTuCbru926 9nJ/IDN0laLQ4U4Fq3+H16rdfHRardwABcDnRlhPvtaC0ECPqedXX4YqSGyUR/HGoFZvagqD0ZAES fPwgY4QhgtXc4NqKT5qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1DzT-00BN3Q-C6; Tue, 14 Jun 2022 21:22:23 +0000 Received: from mail-il1-f169.google.com ([209.85.166.169]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1DzQ-00BN1K-4D for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 21:22:21 +0000 Received: by mail-il1-f169.google.com with SMTP id z11so7521720ilq.6 for ; Tue, 14 Jun 2022 14:22:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LJ7oqbtybKBkB0Ag7vT1yQWpqQMSkI/6sxH61W3XByo=; b=IUIoYs5xwkzjGNTj+VGhqe0ifGuMijjNykgjW6MAbS6KPDkCDsm/4kW8mfh9ursk8E 00wvTYW+ynCZtxUmx7CTl7zBURWCFvSMJCfKwusrfPONpb6afCbEEm+UiDPrOqKfYNWn CTmlnHDB501urKZWmilZjcL/HiZ9eKdPO+whJzTjLc/Eftvc6FPXzQosfLe+dNA3p0VX geiTv6ndAiLj4AcRxNelEvh9DJF0i6lwFB3TelK69deM30WOldZgbrx49sSLZu2EexJA obApXb/DaBFaql2hVvFGvruMEb7Wpwj8+sZqx3xtMKRwwMTH+l8Wc2UaRb/7UnIswMoP Ug0g== X-Gm-Message-State: AJIora9ANJQOfBT5wxic4nds9eSflMB6b4xseKyH/WylKkSQ7UoYUb4a rnqoZRv6SbBKkTupcZOjVg== X-Google-Smtp-Source: AGRyM1tUB8HljEWpwIqWOb25UGejqXfhJnyZMVhHQl4YipIIOeQY0g4ivzM9vJEOIjZeesIVSR7o7g== X-Received: by 2002:a05:6e02:1607:b0:2d1:e622:3f0a with SMTP id t7-20020a056e02160700b002d1e6223f0amr4184323ilu.287.1655241738198; Tue, 14 Jun 2022 14:22:18 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id y5-20020a92d0c5000000b002d5c572f410sm5906255ila.63.2022.06.14.14.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 14:22:17 -0700 (PDT) Received: (nullmailer pid 2648115 invoked by uid 1000); Tue, 14 Jun 2022 21:22:15 -0000 Date: Tue, 14 Jun 2022 15:22:15 -0600 From: Rob Herring To: Brad Larson Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, samuel@sholland.org, fancer.lancer@gmail.com, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, ulf.hansson@linaro.org, will@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC binding Message-ID: <20220614212215.GA2627610-robh@kernel.org> References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-3-brad@pensando.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220613195658.5607-3-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_142220_236121_21B3A8AE X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 13, 2022 at 12:56:45PM -0700, Brad Larson wrote: > From: Brad Larson > > AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and > explicitly controls byte-lane enables. > > Signed-off-by: Brad Larson > --- > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > index 4207fed62dfe..35bc4cf6f214 100644 > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > @@ -13,10 +13,24 @@ maintainers: > allOf: > - $ref: mmc-controller.yaml > > + - if: > + properties: > + compatible: > + enum: > + - amd,pensando-elba-sd4hc > + then: > + properties: > + reg: > + items: > + - description: Cadence host controller registers > + - description: Byte-lane control register > + minItems: 2 This doesn't work. The if/then is additional constraints on the main section which says there is only 1 register region. The main section needs the above, but with 'minItems: 1'. Then the if/then should be: if: properties: compatible: const: amd,pensando-elba-sd4hc then: properties: reg: minItems: 2 else: properties: reg: maxItems: 1 > + > properties: > compatible: > items: > - enum: > + - amd,pensando-elba-sd4hc > - microchip,mpfs-sd4hc > - socionext,uniphier-sd4hc > - const: cdns,sd4hc > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel