From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7320C43334 for ; Wed, 15 Jun 2022 23:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=FwCnb0/ZYlt/YmJd8tTahxUSGYlQ4dhvrCitYkLaYNg=; b=1TFb0f4mKwPhvu ztFpaunirWNGeyPEJ5hstKIZXIB50GC+h4+SJbw/fceWw56cNQuSCzhg+A8fy40tRahTPivGxVm3p ey8iAu5qxei7MKhWy22Ox9u6iWCro7GA5ii3gFu0Dmv3NhtZxsPE8LsnvXDN3I5WaRhIXHU7D2FNZ u5AFSk6HDZjkuSIDn8g/kL6DN4rEoPLy7677KzlTIoKpo3fHFC4uMnMr+HV8iz2nmBU0xjAa7pYHG DUaZ7ANj845fA1qPfX0hhhHPjqDEX/+wMyYHantUen5eF52Nax4W42JPzplAUFpszcxFVJKJcplj/ M3kafDFW+hfLhYpIc5HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1c0m-00Glr6-HQ; Wed, 15 Jun 2022 23:01:20 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1c0j-00Glqd-Io for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 23:01:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D0A8B82189; Wed, 15 Jun 2022 23:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 990CFC3411A; Wed, 15 Jun 2022 23:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655334074; bh=RjcmWRwQhZbNhnUkDtDWbV7ROtGcBvDZqWFahbsTuYY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=OCG3K5JDCEeSTOG4YptWBYN36OhOjDnb7FBKBxf2U88N3WVsEYjrH3PP27QG+ee1u btxQv5OZbHxCrWatiL34a11sQY62LiwtG153ZQoeMPr2UQ77vGc52xn95zzKnJDdPK J51Pv2rSQ+9m3zVJ6gOyRqESosWwLgCvUt+y8XZlK9gNks6aAaE841ZDBd8WQdcvSA YQNSptzulcQ3Ruc71CUZ7MkJ5SPt84hcsDMFNBQnumTRhW+hzQ+tBrc0lF7AaUVcec xY/0VSe61TIcXurmxm0RdIPXmTdzOvMoNEnQyFYUOjZ1nT4SpE4A6yweKp2bSb4RMd Ya8PILdP1gUpg== Date: Wed, 15 Jun 2022 18:01:13 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v11 0/8] PCI: imx6: refine codes and add the error propagation Message-ID: <20220615230113.GA1054155@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1655189942-12678-1-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_160117_954342_08D6CA78 X-CRM114-Status: GOOD ( 34.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 14, 2022 at 02:58:54PM +0800, Richard Zhu wrote: > This series patches refine pci-imx6 driver and do the following main changes. > - Encapsulate the clock enable into one standalone function > - Add the error propagation from host_init and resume > - Turn off regulator when the system is in suspend mode > - Let the probe successfully when link never comes up > - Do not hide the phy driver callbacks in core reset and clk_enable. > BTW, this series are verified on i.MX8MM EVK board when one NVME is used. I applied these on pci/ctrl/imx6, but I noticed a few more things while applying, so I'm going to post a v12 with a little rework for your approval. > Main changes from v10 to v11: > No code changes, just do the following operations refer to Bjorn's comments. > - Split #6 patch into two patches. > - Rebase to v5.19-rc1 based on for-next branch of Shawn's git. > > Main changes from v9 to v10: > - Add the "Reviewed-by: Lucas Stach " tag into #3 > and #4 patches. > - Refer to Bjorn's comments: > - refine the commit of the first patch > - keep alignment of the message format in the second patch > - More specific commit and subject of the #5 and #7 patches. > - Move the regualtor_disable into suspend, turn off the regulator when bus > is powered off and system in suspend mode. > - Let the driver probe successfully, return zero in imx6_pcie_start_link() > when PCIe link is down. > In this link down scenario, only start the PCIe link training in resume > when the link is up before system suspend to avoid the long latency in > the link training period. > - Don't hide phy driver callbacks in core reset and clk_enable, and refine > the error handling accordingly. > - Drop the #8 patch of v9 series, since the clocks and powers are not gated > off anymore when link is down. > > Main changes from v8 to v9: > - Don't change pcie-designware codes, and do the error exit process only in > pci-imx6 driver internally. > - Move the phy driver callbacks to the proper places > > Main changes from v7 to v8: > Regarding Bjorn's review comments. > - Align the format of the dev_info message and refine commit log of > #6/7/8 patches. > - Rename the err_reset_phy label, since there is no PHY reset in the out > > Main changes from v6 to v7: > - Keep the regulator usage counter balance in the #5 patch of v6 series. > > Main changes from v5 to v6: > - Refer to the following discussion with Fabio, fix the dump by his patch. > https://patchwork.kernel.org/project/linux-pci/patch/1641368602-20401-6-git-send-email-hongxing.zhu@nxp.com/ > Refine and rebase this patch-set after Fabio' dump fix patch is merged. > - Add one new #4 patch to disable i.MX6QDL REF clock too when disable clocks > - Split the regulator refine codes into one standalone patch #5 in this version. > > Main changes from v4 to v5: > - Since i.MX8MM PCIe support had been merged. Based on Lorenzo's git repos, > resend the patch-set after rebase. > > Main changes from v3 to v4: > - Regarding Mark's comments, delete the regulator_is_enabled() check. > - Squash #3 and #6 of v3 patch into #5 patch of v4 set. > > Main changes from v2 to v3: > - Add "Reviewed-by: Lucas Stach " tag into > first two patches. > - Add a Fixes tag into #3 patch. > - Split the #4 of v2 to two patches, one is clock disable codes move, > the other one is the acutal clock unbalance fix. > - Add a new host_exit() callback into dw_pcie_host_ops, then it could be > invoked to handle the unbalance issue in the error handling after > host_init() function when link is down. > - Add a new host_exit() callback for i.MX PCIe driver to handle this case > in the error handling after host_init. > > Main changes from v1 to v2: > Regarding Lucas' comments. > - Move the placement of the new imx6_pcie_clk_enable() to avoid the > forward declarition. > - Seperate the second patch of v1 patch-set to three patches. > - Use the module_param to replace the kernel command line. > Regarding Bjorn's comments: > - Use the cover-letter for a multi-patch series. > - Correct the subject line, and refine the commit logs. For example, > remove the timestamp of the logs. > > drivers/pci/controller/dwc/pci-imx6.c | 241 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------- > 1 file changed, 157 insertions(+), 84 deletions(-) > [PATCH v11 1/8] PCI: imx6: Encapsulate the clock enable into one > [PATCH v11 2/8] PCI: imx6: Add the error propagation from host_init > [PATCH v11 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier > [PATCH v11 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when > [PATCH v11 5/8] PCI: imx6: Turn off regulator when the system is in > [PATCH v11 6/8] PCI: imx6: Mark the link down as none fatal error > [PATCH v11 7/8] PCI: imx6: Reduce resume time by only starting link > [PATCH v11 8/8] PCI: imx6: Do not hide phy driver callbacks and _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel