From: Viresh Kumar <viresh.kumar@linaro.org>
To: Liang He <windhl@126.com>
Cc: vireshk@kernel.org, shiraz.linux.kernel@gmail.com,
soc@kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: mach-spear: Add missing of_node_put() in time.c
Date: Thu, 16 Jun 2022 15:21:56 +0530 [thread overview]
Message-ID: <20220616095156.clyiogsvrxbmyrd6@vireshk-i7> (raw)
In-Reply-To: <20220616093027.3984903-1-windhl@126.com>
On 16-06-22, 17:30, Liang He wrote:
> In spear_setup_of_timer(), of_find_matching_node() will return a
> node pointer with refcount incrementd. We should use of_node_put()
> in each fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> changelog:
>
> v2: use goto-label patch style suggested by Viresh.
> v1: use plain of_node_put in each fail path.
>
> arch/arm/mach-spear/time.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c
> index d1fdb6066f7b..c7c17c0f936c 100644
> --- a/arch/arm/mach-spear/time.c
> +++ b/arch/arm/mach-spear/time.c
> @@ -218,13 +218,13 @@ void __init spear_setup_of_timer(void)
> irq = irq_of_parse_and_map(np, 0);
> if (!irq) {
> pr_err("%s: No irq passed for timer via DT\n", __func__);
> - return;
> + goto err_put_np;
> }
>
> gpt_base = of_iomap(np, 0);
> if (!gpt_base) {
> pr_err("%s: of iomap failed\n", __func__);
> - return;
> + goto err_put_np;
> }
>
> gpt_clk = clk_get_sys("gpt0", NULL);
> @@ -239,6 +239,8 @@ void __init spear_setup_of_timer(void)
> goto err_prepare_enable_clk;
> }
>
> + of_node_put(np);
> +
> spear_clockevent_init(irq);
> spear_clocksource_init();
>
> @@ -248,4 +250,6 @@ void __init spear_setup_of_timer(void)
> clk_put(gpt_clk);
> err_iomap:
> iounmap(gpt_base);
> +err_put_np:
> + of_node_put(np);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-16 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 9:30 [PATCH v2] arm: mach-spear: Add missing of_node_put() in time.c Liang He
2022-06-16 9:51 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616095156.clyiogsvrxbmyrd6@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=vireshk@kernel.org \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox