From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55FADC43334 for ; Fri, 17 Jun 2022 21:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cZV6zo2TQhfFqyGDCH7ACpIpJ49WPioX6p+FFKqB1m8=; b=kUCHr6nW5AmswH Cy60eWEgHyITMTGRC6hyKcAja2ohwMf9ycyYzxB39b//G4SH1/LW6ly9QFjg99CsiwlfYQEVRpWeE UhzCp5OfvMSUSpmCs8GdUjnaNUPRmFU5ghjHiWdRTIW1DvMwl5Jk5yfwR9vx/3g5gGSAN8pCNlNaN Zn8lLUPbMhEW/3JjsbhU4d8mNaoXbvmZQaxw37l5EoA1r3TePHHBgGwVZcQXtEzqYNGvcozdo/whk heUjVfqHIJbEvWStq/yHbyo8JHlrKynHwMsIy6SAL10qmckVdZ+U0+yb7rtm0KSjJh0PVyNawEYNm d/nDTKJrxUTdB7DL2QBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2JQO-009EHA-9A; Fri, 17 Jun 2022 21:22:40 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2JP0-009DcI-Ib for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 21:21:16 +0000 Received: by mail-wr1-x429.google.com with SMTP id w17so7158701wrg.7 for ; Fri, 17 Jun 2022 14:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dd/oQAJmMtZFWANi0yOf4gxIvREWtT1OGH41J8eLN8E=; b=AlkWRGyaYd+XX/IoOcFliNOTW40rjtbEo+YcfiUsYb00sFkt62ko2ieYl1yAbTfz/H j3j8x6clB0s3YHT1Htk2hynvvaJys+aADSVQ/bSlZAnwGyU9zSA7lrBlJpTXMIw+MJ2H 4GeJzrxH/TJTWDHdHSr4GRWFk+4xWwOiqS/SHYzYyW4Lk83KTSiltjryjZv7Xj0ne7EC JSRutoUv8hjVVhRIGNt84VXvzjkHEaxtCmvFEhJH3CPwdIW9XGy9pvHkCz9UJB4RMQRn zhsRgdJp7iVHghOqkFk6jps9Fp0gtkh6EHFyHiiJweT/Ms1Zm+l1BFnDbqJB6nawMEt1 kSEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dd/oQAJmMtZFWANi0yOf4gxIvREWtT1OGH41J8eLN8E=; b=TfkQIoN6gc5mbvFF9NHMDALhDoNuyJF7A/NNVevW7Y9sb4KamDOiX0o62s5Et5IG95 S2aBqGX0Ot3GikFQnpPy39dDzapST9fG3YKhxnWDfsrWpa4kme4M87Lc2KGn9MBikBOe DxBodt5cvuincTgE6j6LxnWiM/wAm8W2ZyzRZDVYFUlYKkrgTei/Pe/B/6TBMR1PpP4o LzAfNzNHCM40vMtBr2bIlK+AO93p/ISbpyWoFXE4Hh4n8MTlB8rzag5lLYhwB5Lo1a2K OnmFPI2EldE3lZ7egH8GA2ANw1V/SyC6693HW0J3gUBqIm8D3jvNn+74mKNdnwuQVH7W kdWw== X-Gm-Message-State: AJIora8Em78KkGrRhMdJRqh29GzevIASQ1SD2HkBpA24VCn4GtHEoO+P 0iEVYC0Z/qnrXVHcRZ0z0w4= X-Google-Smtp-Source: AGRyM1sZ1C+forFzpsDc8tjYnBXPlqdhp4thfRO2J6IOHM5KWsC/jR+5/Y4gNDYKHzEwLri0V9aABA== X-Received: by 2002:adf:db85:0:b0:21a:9af:4e7e with SMTP id u5-20020adfdb85000000b0021a09af4e7emr10836334wri.27.1655500871293; Fri, 17 Jun 2022 14:21:11 -0700 (PDT) Received: from voidz-builder.home ([2a00:23c8:180c:3301:82fa:5bff:fe49:bece]) by smtp.gmail.com with ESMTPSA id t9-20020adfeb89000000b002103bd9c5acsm5681937wrn.105.2022.06.17.14.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 14:21:10 -0700 (PDT) From: Laurence de Bruxelles To: Linus Walleij Cc: Robert Jarzmik , Lee Jones , Daniel Thompson , linux-arm-kernel@lists.infradead.org, Laurence de Bruxelles Subject: [PATCH] backlight: corgi: Fix gpio numbers for backlight controls Date: Fri, 17 Jun 2022 22:20:37 +0100 Message-Id: <20220617212037.28118-1-lfdebrux@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_142114_691106_7ED34131 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With recent stable kernels on my Zaurus Akita I am unable to change the backlight brightness, as the necessary files are not in the sys filesystem, and at startup I get the following errors: corgi-lcd spi2.1: requested GPIO 0 (207) is out of range [0..120] for chip gpio-pxa corgi-lcd: probe of spi2.1 failed with error -22 Looking at recent changes to the Corgi backlight driver, I found that commit ee0c8e494cc3 ("backlight: corgi: Convert to use GPIO descriptors") replaced the use of the deprecated integer-based GPIO interface, but didn't convert the GPIO numbers in the platform header to match this. I think this is what causes the error, as the GPIOs for the backlight are part of an expander chip with a GPIO base number larger than the number of GPIOs for the gpio-pxa device. This patch fixes things by updating the GPIO numbers for the backlight, simply by dropping the GPIO base. It also updates the GPIO lookups to look in the table for the appropriate expander. For the Akita platform the expander with i2c address 0-0018 is used, for Spitz and Borzoi the second Sharp SCOOP expander is used. I've tested this patch with real Akita and Spitz handhelds, as well as with QEMU. Signed-off-by: Laurence de Bruxelles Fixes: ee0c8e494cc3 ("backlight: corgi: Convert to use GPIO descriptors") --- arch/arm/mach-pxa/spitz.c | 8 ++++---- arch/arm/mach-pxa/spitz.h | 34 +++++++++++++++++----------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c index dd88953adc9d..ede3727fc91d 100644 --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -524,9 +524,9 @@ static void spitz_bl_kick_battery(void) static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { .dev_id = "spi2.1", .table = { - GPIO_LOOKUP("gpio-pxa", SPITZ_GPIO_BACKLIGHT_CONT, + GPIO_LOOKUP("sharp-scoop.1", SPITZ_GPIO_BACKLIGHT_CONT, "BL_CONT", GPIO_ACTIVE_LOW), - GPIO_LOOKUP("gpio-pxa", SPITZ_GPIO_BACKLIGHT_ON, + GPIO_LOOKUP("sharp-scoop.1", SPITZ_GPIO_BACKLIGHT_ON, "BL_ON", GPIO_ACTIVE_HIGH), { }, }, @@ -535,9 +535,9 @@ static struct gpiod_lookup_table spitz_lcdcon_gpio_table = { static struct gpiod_lookup_table akita_lcdcon_gpio_table = { .dev_id = "spi2.1", .table = { - GPIO_LOOKUP("gpio-pxa", AKITA_GPIO_BACKLIGHT_CONT, + GPIO_LOOKUP("0-0018", AKITA_GPIO_BACKLIGHT_CONT, "BL_CONT", GPIO_ACTIVE_LOW), - GPIO_LOOKUP("gpio-pxa", AKITA_GPIO_BACKLIGHT_ON, + GPIO_LOOKUP("0-0018", AKITA_GPIO_BACKLIGHT_ON, "BL_ON", GPIO_ACTIVE_HIGH), { }, }, diff --git a/arch/arm/mach-pxa/spitz.h b/arch/arm/mach-pxa/spitz.h index 04828d8918aa..4def79ee6df0 100644 --- a/arch/arm/mach-pxa/spitz.h +++ b/arch/arm/mach-pxa/spitz.h @@ -137,26 +137,26 @@ #define SPITZ_SCP2_SUS_SET (SPITZ_SCP2_IR_ON | SPITZ_SCP2_RESERVED_1) #define SPITZ_SCP2_GPIO_BASE (PXA_NR_BUILTIN_GPIO + 12) -#define SPITZ_GPIO_IR_ON (SPITZ_SCP2_GPIO_BASE + 0) -#define SPITZ_GPIO_AKIN_PULLUP (SPITZ_SCP2_GPIO_BASE + 1) -#define SPITZ_GPIO_RESERVED_1 (SPITZ_SCP2_GPIO_BASE + 2) -#define SPITZ_GPIO_RESERVED_2 (SPITZ_SCP2_GPIO_BASE + 3) -#define SPITZ_GPIO_RESERVED_3 (SPITZ_SCP2_GPIO_BASE + 4) -#define SPITZ_GPIO_RESERVED_4 (SPITZ_SCP2_GPIO_BASE + 5) -#define SPITZ_GPIO_BACKLIGHT_CONT (SPITZ_SCP2_GPIO_BASE + 6) -#define SPITZ_GPIO_BACKLIGHT_ON (SPITZ_SCP2_GPIO_BASE + 7) -#define SPITZ_GPIO_MIC_BIAS (SPITZ_SCP2_GPIO_BASE + 8) +#define SPITZ_GPIO_IR_ON 0 +#define SPITZ_GPIO_AKIN_PULLUP 1 +#define SPITZ_GPIO_RESERVED_1 2 +#define SPITZ_GPIO_RESERVED_2 3 +#define SPITZ_GPIO_RESERVED_3 4 +#define SPITZ_GPIO_RESERVED_4 5 +#define SPITZ_GPIO_BACKLIGHT_CONT 6 +#define SPITZ_GPIO_BACKLIGHT_ON 7 +#define SPITZ_GPIO_MIC_BIAS 8 /* Akita IO Expander GPIOs */ #define AKITA_IOEXP_GPIO_BASE (PXA_NR_BUILTIN_GPIO + 12) -#define AKITA_GPIO_RESERVED_0 (AKITA_IOEXP_GPIO_BASE + 0) -#define AKITA_GPIO_RESERVED_1 (AKITA_IOEXP_GPIO_BASE + 1) -#define AKITA_GPIO_MIC_BIAS (AKITA_IOEXP_GPIO_BASE + 2) -#define AKITA_GPIO_BACKLIGHT_ON (AKITA_IOEXP_GPIO_BASE + 3) -#define AKITA_GPIO_BACKLIGHT_CONT (AKITA_IOEXP_GPIO_BASE + 4) -#define AKITA_GPIO_AKIN_PULLUP (AKITA_IOEXP_GPIO_BASE + 5) -#define AKITA_GPIO_IR_ON (AKITA_IOEXP_GPIO_BASE + 6) -#define AKITA_GPIO_RESERVED_7 (AKITA_IOEXP_GPIO_BASE + 7) +#define AKITA_GPIO_RESERVED_0 0 +#define AKITA_GPIO_RESERVED_1 1 +#define AKITA_GPIO_MIC_BIAS 2 +#define AKITA_GPIO_BACKLIGHT_ON 3 +#define AKITA_GPIO_BACKLIGHT_CONT 4 +#define AKITA_GPIO_AKIN_PULLUP 5 +#define AKITA_GPIO_IR_ON 6 +#define AKITA_GPIO_RESERVED_7 7 /* Spitz IRQ Definitions */ -- 2.36.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel