From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31E1CC433EF for ; Sat, 18 Jun 2022 02:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqfnsMrg58dCflASJ18zr6ZLZI815e2+u79pP0a7Qcg=; b=NoeXaxf4o4uA5X H60eZUypGIWb45FwRC5/DUTZS4LjuT1yDbkTC/kYF/LExRgS026wLgJlApuMTuMVwlYbnfFjOTyRF phLTEwa6HI6xtASHWWwJccpMDT4JT9mwD9OnP0z9xWVMs6tBMHh2v19aphxhAD/6Ji8fLNFZhmMk7 Tsc0TWQDSl2XIlx9oqPulN4SEG1rk6OT4EdC0ysLgiKfWo3cIj/9xozgegyaQ0jYR3kmxOxWAyDoi xc9aVNYd8Ptxplh8N9+se4k7wvM+Nk/W7J5Ao1pHURlBPAXiVWtVX2PbYtyuUQnOzhSrtg5GLH2gs CqMReDbAM31gcp/0PzyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2O46-00A4C7-QD; Sat, 18 Jun 2022 02:19:58 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2O42-00A4BP-Vd for linux-arm-kernel@lists.infradead.org; Sat, 18 Jun 2022 02:19:56 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25I2JoCu085186; Fri, 17 Jun 2022 21:19:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655518790; bh=KowOwt7/uxj0mtFxMJgrFeb9wkGNGAaHQTQP51WraPU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YC2CpplwEfAHMODHKuX94Or71h6bo+AxVsGWHI2EdH/4gQOjJfZY2BuZbTngbE7cb Ce/HjkD98UokeR5J/5nCSVgqxKbj7g0jxBgIfEfSzNCpZGeJiOdoQivRmeDbS5Wzfe jjl04jxLe7e60XlKn/5mmh5XU3/tnECDmq52w57I= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25I2JnPk008623 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Jun 2022 21:19:49 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Jun 2022 21:19:49 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 17 Jun 2022 21:19:49 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25I2JnAL128179; Fri, 17 Jun 2022 21:19:49 -0500 Date: Fri, 17 Jun 2022 21:19:49 -0500 From: Nishanth Menon To: Rahul T R Subject: Re: [PATCH v4 2/3] arm64: dts: ti: k3-j721e-*: Add dts nodes for EHRPWMs Message-ID: <20220618021949.i5m4saxi2celzanz@kahuna> References: <20220530101031.11357-1-r-ravikumar@ti.com> <20220530101031.11357-3-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220530101031.11357-3-r-ravikumar@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_191955_145220_B1F8A337 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, vigneshr@ti.com, kristo@kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, rogerq@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Vijay Pothukuchi , lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:40-20220530, Rahul T R wrote: > From: Vijay Pothukuchi > > Add dts nodes for 6 EHRPWM instances on SoC > > Signed-off-by: Vijay Pothukuchi > Signed-off-by: Rahul T R > --- > .../dts/ti/k3-j721e-common-proc-board.dts | 24 +++++++ > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 62 ++++++++++++++++++- > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 24 +++++++ > 3 files changed, 109 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index 2bc26a296496..f7d02fa4d6fc 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -995,3 +995,27 @@ > &main_mcan13 { > status = "disabled"; > }; > + > +&main_ehrpwm0 { > + status = "disabled"; > +}; > + > +&main_ehrpwm1 { > + status = "disabled"; > +}; > + > +&main_ehrpwm2 { > + status = "disabled"; > +}; > + > +&main_ehrpwm3 { > + status = "disabled"; > +}; > + > +&main_ehrpwm4 { > + status = "disabled"; > +}; > + > +&main_ehrpwm5 { > + status = "disabled"; > +}; Do the pwm driver croak and die OR it is un-usable on proc-board or disabled due to not-primary function (ideally drivers should shut things off when unused)? > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 43b6cf5791ee..1ee00b73905d 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -66,7 +66,67 @@ > #mux-control-cells = <1>; > mux-reg-masks = <0x4000 0x8000000>, /* USB0 to SERDES0/3 mux */ > <0x4010 0x8000000>; /* USB1 to SERDES1/2 mux */ > - }; > + }; > + > + ehrpwm_tbclk: clock-controller@4140 { > + compatible = "ti,am654-ehrpwm-tbclk", "syscon"; > + reg = <0x4140 0x18>; > + #clock-cells = <1>; > + }; > + }; > + > + main_ehrpwm0: pwm@3000000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3000000 0x0 0x100>; would suggest 0x00 instead of 0x0 > + power-domains = <&k3_pds 83 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 0>, <&k3_clks 83 0>; > + clock-names = "tbclk", "fck"; > + }; > + > + main_ehrpwm1: pwm@3010000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3010000 0x0 0x100>; > + power-domains = <&k3_pds 84 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 1>, <&k3_clks 84 0>; > + clock-names = "tbclk", "fck"; > + }; > + > + main_ehrpwm2: pwm@3020000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3020000 0x0 0x100>; > + power-domains = <&k3_pds 85 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 2>, <&k3_clks 85 0>; > + clock-names = "tbclk", "fck"; > + }; > + > + main_ehrpwm3: pwm@3030000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3030000 0x0 0x100>; > + power-domains = <&k3_pds 86 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 3>, <&k3_clks 86 0>; > + clock-names = "tbclk", "fck"; > + }; > + > + main_ehrpwm4: pwm@3040000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3040000 0x0 0x100>; > + power-domains = <&k3_pds 87 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 4>, <&k3_clks 87 0>; > + clock-names = "tbclk", "fck"; > + }; > + > + main_ehrpwm5: pwm@3050000 { > + compatible = "ti,am654-ehrpwm", "ti,am3352-ehrpwm"; > + #pwm-cells = <3>; > + reg = <0x0 0x3050000 0x0 0x100>; > + power-domains = <&k3_pds 88 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&ehrpwm_tbclk 5>, <&k3_clks 88 0>; > + clock-names = "tbclk", "fck"; > }; > > gic500: interrupt-controller@1800000 { > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > index 80358cba6954..98a55778f3fe 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > @@ -1129,3 +1129,27 @@ > memory-region = <&c71_0_dma_memory_region>, > <&c71_0_memory_region>; > }; > + > +&main_ehrpwm0 { > + status = "disabled"; > +}; > + > +&main_ehrpwm1 { > + status = "disabled"; > +}; > + > +&main_ehrpwm2 { > + status = "disabled"; > +}; > + > +&main_ehrpwm3 { > + status = "disabled"; > +}; > + > +&main_ehrpwm4 { > + status = "disabled"; > +}; > + > +&main_ehrpwm5 { > + status = "disabled"; > +}; > -- > 2.17.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel