From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14DBBC433EF for ; Sat, 18 Jun 2022 02:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CV+mAEI1326GSqQ+WRArMY77Mi+tUqat+SP2Ge+HWIU=; b=IqdcU2hNISfJ/d LOcEzvCsNGYzhiAEmuNVDKFkGNUGhD9EhXHLqQbIL6s4ylNpiNMD+OSe0MSmdcD3K3rRk1SIfrzDM +xU6dS5vQnTXjVXD1Cyobpewo9x2nP+HN0G+TWS3YB7PNg2UfDODZyi4pNUng2JwqRMXx9EdCe6ao Nj4bGYEubqJPo2PY0E1jkqjoy7S2Ciwk4QLStQ8fcLQ/H5XHSIt4fqc6s9I+p4NPFD6Q6Hw6a3YF2 U1l5RRkquMOXru42H9dLbjvVG0SDH8rN7WIzM3dm0IVHKmdVqzITx7uXzOwnCPTMdM+wrOQjcgYRg EBqKsK9u/zJZ0Rx9nAnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2OON-00A5bE-Uo; Sat, 18 Jun 2022 02:40:56 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2OOL-00A5ao-45 for linux-arm-kernel@lists.infradead.org; Sat, 18 Jun 2022 02:40:54 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25I2emso008858; Fri, 17 Jun 2022 21:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655520048; bh=oXLqMye2VzEFwSwRHpDgWkr1vSMEoKi8gVzaBkQA9xA=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ivX39e6m1HD2Ie1wZMEbzomCsgpi6GKSstZSBweUkSWhAjWo3gv/gYB/PDycsyCrf nTINIqhQ86BhqWOXJiTTVHLnq/nOCxIxdpHwanfYajhB6Kkc02kp+B23at8Rcpc+Ll 9Zkuzk9C4pN0rWMfWpDz5s/DSJ9VjGyVNjzBLH1U= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25I2emef060805 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Jun 2022 21:40:48 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Jun 2022 21:40:48 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 17 Jun 2022 21:40:48 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25I2em3f006228; Fri, 17 Jun 2022 21:40:48 -0500 Date: Fri, 17 Jun 2022 21:40:48 -0500 From: Nishanth Menon To: Yihao Han CC: Santosh Shilimkar , , , Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20220618024048.hr7hgphogmdaeq2x@kahuna> References: <20220505024833.8494-1-hanyihao@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220505024833.8494-1-hanyihao@vivo.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_194053_286822_4258AC49 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19:48-20220504, Yihao Han wrote: > Fix the following coccicheck warning: > ./drivers/soc/ti/wkup_m3_ipc.c:198:0-23: WARNING: > wkup_m3_ipc_option_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: Yihao Han > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0076d467ff6b..2142d8fb3f5c 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -195,7 +195,7 @@ static int option_set(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, > +DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, > "%llu\n"); Please run ./scripts/checkpatch --strict patch +CHECK: Alignment should match open parenthesis +#29: FILE: drivers/soc/ti/wkup_m3_ipc.c:199: ++DEFINE_DEBUGFS_ATTRIBUTE(wkup_m3_ipc_option_fops, option_get, option_set, + "%llu\n"); + mechanically convert to the typical style using --fix or --fix-inplace. + them to the maintainer, see CHECKPATCH in MAINTAINERS. Could you fix and post a V2? > > static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc) > -- > 2.17.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel