From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 609F6C43334 for ; Sat, 18 Jun 2022 15:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YsvoLwjFpSzkPiVOqq0zbZWcx+WJRxjpccPQk9Vg3Ew=; b=4CfRe3DQWPfZCt he3kN8xLgb6EHvLPCmotQLBdoKXyr2upjCzke2cJxn4O7zUuwtawIlnw4wgW8foUSeNGY1yC2ATBD 21kXs6I9YEdBWWrxIHbg7W4qwe6SKzq6Yhw6+oj8KQy7KNQTVmfWXBgsvumr6LOZ9jaQQXuNcUSie QvyCY+dq3hXRQpmcjV+E6XgEnLNhXA2eWpracphkgPzdGOsAi7B7mSz9iLzLyK31yb/npkmOXhg4s D0C4AMFK7dYoiY66gln/rwGYVFYtVpZ6GPg5biUZ8egMvlzjPx/Xv8q26Ps+RAsJkG99QaUhp5wiP jSNiLR4TmysdCUyQgkBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2aMq-00Berk-Ao; Sat, 18 Jun 2022 15:28:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2aMn-00Beqi-OB for linux-arm-kernel@lists.infradead.org; Sat, 18 Jun 2022 15:28:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE66060B1E; Sat, 18 Jun 2022 15:28:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B478C3411A; Sat, 18 Jun 2022 15:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655566084; bh=BVsNfMePkIkcRLJKxWnrPVHIGrWk4Pmg3MuN5L6XZTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YEdkot7sy/W+8Tns+DaPXCCEzI2fvdOGx22Bzu01XVJf8iNNbwtA36CP5KFedCT2A vVTeEbf4JQusT+4Q4NRqHAq+XE03j7Tw+129AY6547iNY6UlS3VKqQWGchghwPYtvZ BRVotCHJzS6k2YEJIlWppzi9XTEFpgcmp3hPdmyrVwJCKui6AXYrVbv2nquswlAeFK a9V1KPwMnsDbXiGicHxl9048UsoFRB+Dq6OjP4Sb0+1RFjaU0yJW2pxEw22pqYkV2t y80531VDnHD8aHXVWFE1aJRiFovycfJgh5G2Re1QIGj60TjuS5YXYCOJ26Z9e6XuOC ffXOolx148r3Q== Date: Sat, 18 Jun 2022 16:37:21 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , Fabrice Gasnier Subject: Re: [PATCH v1 1/1] iio: dac: stm32-dac: Replace open coded str_enable_disable() Message-ID: <20220618163721.1cef64c9@jic23-huawei> In-Reply-To: <20220616220023.9894-1-andriy.shevchenko@linux.intel.com> References: <20220616220023.9894-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220618_082805_877219_BA3F1C4B X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jun 2022 01:00:23 +0300 Andy Shevchenko wrote: > Replace open coded str_enable_disable() in error message in > stm32_dac_set_enable_state(). > > Signed-off-by: Andy Shevchenko +CC Fabrice. Looks good + harmless to me, so I'll pick it up now, but still time for any additional feedback as I'll only push it out for 0-day to poke at initially. Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/dac/stm32-dac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > index e842c15c674d..315d66648210 100644 > --- a/drivers/iio/dac/stm32-dac.c > +++ b/drivers/iio/dac/stm32-dac.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #include "stm32-dac-core.h" > > @@ -79,8 +80,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > ret = regmap_update_bits(dac->common->regmap, STM32_DAC_CR, msk, en); > mutex_unlock(&dac->lock); > if (ret < 0) { > - dev_err(&indio_dev->dev, "%s failed\n", en ? > - "Enable" : "Disable"); > + dev_err(&indio_dev->dev, "%s failed\n", str_enable_disable(en)); > goto err_put_pm; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel