From: Peter Chen <peter.chen@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe()
Date: Mon, 20 Jun 2022 21:55:15 +0800 [thread overview]
Message-ID: <20220620135515.GB1227419@Peter> (raw)
In-Reply-To: <20220614120522.1469957-1-alexander.stein@ew.tq-group.com>
On 22-06-14 14:05:22, Alexander Stein wrote:
> Use dev_err_probe() to simplify handling errors in ci_hdrc_imx_probe()
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 097142ffb184..9ffcecd3058c 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -348,25 +348,18 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> data->pinctrl = devm_pinctrl_get(dev);
> if (PTR_ERR(data->pinctrl) == -ENODEV)
> data->pinctrl = NULL;
> - else if (IS_ERR(data->pinctrl)) {
> - if (PTR_ERR(data->pinctrl) != -EPROBE_DEFER)
> - dev_err(dev, "pinctrl get failed, err=%ld\n",
> - PTR_ERR(data->pinctrl));
> - return PTR_ERR(data->pinctrl);
> - }
> + else if (IS_ERR(data->pinctrl))
> + return dev_err_probe(dev, PTR_ERR(data->pinctrl),
> + "pinctrl get failed\n");
>
> data->hsic_pad_regulator =
> devm_regulator_get_optional(dev, "hsic");
> if (PTR_ERR(data->hsic_pad_regulator) == -ENODEV) {
> /* no pad regualator is needed */
> data->hsic_pad_regulator = NULL;
> - } else if (IS_ERR(data->hsic_pad_regulator)) {
> - if (PTR_ERR(data->hsic_pad_regulator) != -EPROBE_DEFER)
> - dev_err(dev,
> - "Get HSIC pad regulator error: %ld\n",
> - PTR_ERR(data->hsic_pad_regulator));
> - return PTR_ERR(data->hsic_pad_regulator);
> - }
> + } else if (IS_ERR(data->hsic_pad_regulator))
> + return dev_err_probe(dev, PTR_ERR(data->hsic_pad_regulator),
> + "Get HSIC pad regulator error\n");
>
> if (data->hsic_pad_regulator) {
> ret = regulator_enable(data->hsic_pad_regulator);
> @@ -458,9 +451,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> &pdata);
> if (IS_ERR(data->ci_pdev)) {
> ret = PTR_ERR(data->ci_pdev);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "ci_hdrc_add_device failed, err=%d\n",
> - ret);
> + dev_err_probe(dev, ret, "ci_hdrc_add_device failed\n");
> goto err_clk;
> }
>
> --
> 2.25.1
>
--
Thanks,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-20 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:05 [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe() Alexander Stein
2022-06-20 13:55 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620135515.GB1227419@Peter \
--to=peter.chen@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).