* [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe()
@ 2022-06-14 12:05 Alexander Stein
2022-06-20 13:55 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2022-06-14 12:05 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, linux-usb, linux-arm-kernel
Use dev_err_probe() to simplify handling errors in ci_hdrc_imx_probe()
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 097142ffb184..9ffcecd3058c 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -348,25 +348,18 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
data->pinctrl = devm_pinctrl_get(dev);
if (PTR_ERR(data->pinctrl) == -ENODEV)
data->pinctrl = NULL;
- else if (IS_ERR(data->pinctrl)) {
- if (PTR_ERR(data->pinctrl) != -EPROBE_DEFER)
- dev_err(dev, "pinctrl get failed, err=%ld\n",
- PTR_ERR(data->pinctrl));
- return PTR_ERR(data->pinctrl);
- }
+ else if (IS_ERR(data->pinctrl))
+ return dev_err_probe(dev, PTR_ERR(data->pinctrl),
+ "pinctrl get failed\n");
data->hsic_pad_regulator =
devm_regulator_get_optional(dev, "hsic");
if (PTR_ERR(data->hsic_pad_regulator) == -ENODEV) {
/* no pad regualator is needed */
data->hsic_pad_regulator = NULL;
- } else if (IS_ERR(data->hsic_pad_regulator)) {
- if (PTR_ERR(data->hsic_pad_regulator) != -EPROBE_DEFER)
- dev_err(dev,
- "Get HSIC pad regulator error: %ld\n",
- PTR_ERR(data->hsic_pad_regulator));
- return PTR_ERR(data->hsic_pad_regulator);
- }
+ } else if (IS_ERR(data->hsic_pad_regulator))
+ return dev_err_probe(dev, PTR_ERR(data->hsic_pad_regulator),
+ "Get HSIC pad regulator error\n");
if (data->hsic_pad_regulator) {
ret = regulator_enable(data->hsic_pad_regulator);
@@ -458,9 +451,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
&pdata);
if (IS_ERR(data->ci_pdev)) {
ret = PTR_ERR(data->ci_pdev);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "ci_hdrc_add_device failed, err=%d\n",
- ret);
+ dev_err_probe(dev, ret, "ci_hdrc_add_device failed\n");
goto err_clk;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe()
2022-06-14 12:05 [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe() Alexander Stein
@ 2022-06-20 13:55 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2022-06-20 13:55 UTC (permalink / raw)
To: Alexander Stein
Cc: Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Fabio Estevam,
linux-usb, linux-arm-kernel
On 22-06-14 14:05:22, Alexander Stein wrote:
> Use dev_err_probe() to simplify handling errors in ci_hdrc_imx_probe()
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 097142ffb184..9ffcecd3058c 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -348,25 +348,18 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> data->pinctrl = devm_pinctrl_get(dev);
> if (PTR_ERR(data->pinctrl) == -ENODEV)
> data->pinctrl = NULL;
> - else if (IS_ERR(data->pinctrl)) {
> - if (PTR_ERR(data->pinctrl) != -EPROBE_DEFER)
> - dev_err(dev, "pinctrl get failed, err=%ld\n",
> - PTR_ERR(data->pinctrl));
> - return PTR_ERR(data->pinctrl);
> - }
> + else if (IS_ERR(data->pinctrl))
> + return dev_err_probe(dev, PTR_ERR(data->pinctrl),
> + "pinctrl get failed\n");
>
> data->hsic_pad_regulator =
> devm_regulator_get_optional(dev, "hsic");
> if (PTR_ERR(data->hsic_pad_regulator) == -ENODEV) {
> /* no pad regualator is needed */
> data->hsic_pad_regulator = NULL;
> - } else if (IS_ERR(data->hsic_pad_regulator)) {
> - if (PTR_ERR(data->hsic_pad_regulator) != -EPROBE_DEFER)
> - dev_err(dev,
> - "Get HSIC pad regulator error: %ld\n",
> - PTR_ERR(data->hsic_pad_regulator));
> - return PTR_ERR(data->hsic_pad_regulator);
> - }
> + } else if (IS_ERR(data->hsic_pad_regulator))
> + return dev_err_probe(dev, PTR_ERR(data->hsic_pad_regulator),
> + "Get HSIC pad regulator error\n");
>
> if (data->hsic_pad_regulator) {
> ret = regulator_enable(data->hsic_pad_regulator);
> @@ -458,9 +451,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> &pdata);
> if (IS_ERR(data->ci_pdev)) {
> ret = PTR_ERR(data->ci_pdev);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "ci_hdrc_add_device failed, err=%d\n",
> - ret);
> + dev_err_probe(dev, ret, "ci_hdrc_add_device failed\n");
> goto err_clk;
> }
>
> --
> 2.25.1
>
--
Thanks,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-20 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 12:05 [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe() Alexander Stein
2022-06-20 13:55 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).