linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pranavi Somisetty <pranavi.somisetty@xilinx.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	Harini Katakam <harini.katakam@xilinx.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Subject: [xilinx-xlnx:xlnx_rebase_v5.15 1090/1181] drivers/staging/xilinx-tsn/xilinx_tsn_ep_ex.c:111:52: warning: variable 'mac_addr' is uninitialized when used here
Date: Tue, 21 Jun 2022 05:09:08 +0800	[thread overview]
Message-ID: <202206210504.DOkGUgfX-lkp@intel.com> (raw)

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   5e0be2b8c0a423b650f4e4d107be37e858d2b9dd
commit: 69f4e38f3088d4dc9c007070610b5223c5611d08 [1090/1181] net: xilinx: Move Xilinx TSN to staging
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220621/202206210504.DOkGUgfX-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/69f4e38f3088d4dc9c007070610b5223c5611d08
        git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.15
        git checkout 69f4e38f3088d4dc9c007070610b5223c5611d08
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/staging/xilinx-tsn/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/xilinx-tsn/xilinx_tsn_ep_ex.c:111:52: warning: variable 'mac_addr' is uninitialized when used here [-Wuninitialized]
           ret = of_get_mac_address(pdev->dev.of_node, (u8 *)mac_addr);
                                                             ^~~~~~~~
   drivers/staging/xilinx-tsn/xilinx_tsn_ep_ex.c:86:22: note: initialize the variable 'mac_addr' to silence this warning
           const void *mac_addr;
                               ^
                                = NULL
   1 warning generated.


vim +/mac_addr +111 drivers/staging/xilinx-tsn/xilinx_tsn_ep_ex.c

50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   79  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   80  static int tsn_ex_ep_probe(struct platform_device *pdev)
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   81  {
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   82  	struct axienet_local *lp;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   83  	struct net_device *ndev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   84  	struct device_node *ep_node;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   85  	struct axienet_local *ep_lp;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   86  	const void *mac_addr;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   87  	int ret = 0;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   88  	const void *packet_switch;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   89  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   90  	ndev = alloc_netdev(sizeof(*lp), "exep",
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   91  			    NET_NAME_UNKNOWN, ether_setup);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   92  	if (!ndev)
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   93  		return -ENOMEM;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   94  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   95  	platform_set_drvdata(pdev, ndev);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   96  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   97  	SET_NETDEV_DEV(ndev, &pdev->dev);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   98  	ndev->flags &= ~IFF_MULTICAST;  /* clear multicast */
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06   99  	ndev->features = NETIF_F_SG;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  100  	ndev->netdev_ops = &ex_ep_netdev_ops;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  101  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  102  	/* MTU range: 64 - 9000 */
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  103  	ndev->min_mtu = 64;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  104  	ndev->max_mtu = XAE_JUMBO_MTU;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  105  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  106  	lp = netdev_priv(ndev);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  107  	lp->ndev = ndev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  108  	lp->dev = &pdev->dev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  109  	lp->options = XAE_OPTION_DEFAULTS;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  110  	/* Retrieve the MAC address */
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06 @111  	ret = of_get_mac_address(pdev->dev.of_node, (u8 *)mac_addr);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  112  	if (ret) {
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  113  		dev_err(&pdev->dev, "could not find MAC address\n");
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  114  		goto free_netdev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  115  	}
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  116  	tsn_ex_ep_set_mac_address(ndev, mac_addr);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  117  	packet_switch = of_get_property(pdev->dev.of_node, "packet-switch", NULL);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  118  	ep_node = of_parse_phandle(pdev->dev.of_node, "tsn,endpoint", 0);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  119  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  120  	lp->master = of_find_net_device_by_node(ep_node);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  121  	ret = register_netdev(lp->ndev);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  122  	if (ret) {
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  123  		dev_err(lp->dev, "register_netdev() error (%i)\n", ret);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  124  		goto free_netdev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  125  	}
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  126  	ep_lp = netdev_priv(lp->master);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  127  	ep_lp->ex_ep = ndev;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  128  	if (packet_switch)
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  129  		ep_lp->packet_switch = 1;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  130  	return ret;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  131  free_netdev:
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  132  	free_netdev(ndev);
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  133  
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  134  	return ret;
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  135  }
50ac45f37fce9e drivers/net/ethernet/xilinx/xilinx_tsn_ep_ex.c Pranavi Somisetty 2022-04-06  136  

:::::: The code at line 111 was first introduced by commit
:::::: 50ac45f37fce9e1fc3e40b605ac1f18d9c193efd net: xilinx: TSN endpoint extension support

:::::: TO: Pranavi Somisetty <pranavi.somisetty@xilinx.com>
:::::: CC: Michal Simek <michal.simek@xilinx.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

                 reply	other threads:[~2022-06-20 21:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206210504.DOkGUgfX-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=harini.katakam@xilinx.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=llvm@lists.linux.dev \
    --cc=monstr@monstr.eu \
    --cc=pranavi.somisetty@xilinx.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).