From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4ABCC433EF for ; Wed, 22 Jun 2022 07:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fQUW2zX27bXWDX2Y7VyluuseLXQl4ul+r2C1Q/LXQsI=; b=wWFv/bWEMkhFdcXuTodt4ZSLLt o/d6rDJKbu43rakfrdpIwxWhpNVnpiuh5b8l02tajgwVjPF+aXHfHQTEYOmCV7/AYkkkmluYjOiRF JPYPpqV/R3eLyjPAb4PS62RaR4fGUisjyrEgWZ1omZQp9n+HvbVEge2WvURVFXwgHXfymDeAWeecM XYFyB1HsdaatDUShWDzgsJKHo/mnbQcVsMLWflmnbSmQ9OfF1d7fKO8cdz/ZvT+DeovZbYRQ6youe k3I5AIRVULWyRWy/GQ3VEjWl79xEWNvlykfI8EggOlTBoTjZdlN3RZ+kUocHP4DG9gL1e74ANby0x zjuYYwmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3vEy-0098tH-5p; Wed, 22 Jun 2022 07:57:32 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3vEv-0098sH-1u for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 07:57:30 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 33A935C00D8; Wed, 22 Jun 2022 03:57:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 22 Jun 2022 03:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1655884648; x=1655971048; bh=x1drCMu5dq EeEn5rlOqr732uAMnNtHSW/+Yw52DBQHM=; b=pbyDL2YJVwqma+q5ZDQLE+Cw4h 8zD5iAzAXCo402V0ukFU1qb9Ad+Mq6U1NBQ8QBQG8T0xBVhdSjE/SLm11/pFzedW tdQjkxxpaiqX6J5s7Xp5nw3l7e/Ln6StT0zo5GCV8V/Y5WY83wMeXNB/+B/JnQ8j kus9OCi7biIq7o/dfMizKS9zAl05EfvrYXEWzT5v4UHo6Qkiy9JdbW/FuwO47rFV wltuOvTmUG6PIfbMNgZ4VmbaaTq6ZfJBd/mlS9D2m8ZV17kQ/LqfN4065LSTRD4g r7q18oGc4qzphbpNoiegbT3WfclFkOvvOPQ0byd2qt/ilExPOvGNJU22hPbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655884648; x=1655971048; bh=x1drCMu5dqEeEn5rlOqr732uAMnN tHSW/+Yw52DBQHM=; b=o3k5NlJchNCwnv8bCsQZx2/IWFPd3VUiOaFHm4rkuDzW lipDdqr9jRUHzC/nBEM23CZ5SpS36QD2d19H/HlI8Nm3Oj4pNzNTs+ngj1j3R7a8 SNxLCyfueW3ccnrqRAlsZbwuc2ezuArdl46u6HsrTfLNESWXdkKUtpLQXJkOToev KSRUh3eI1Ji+z1wCUn8ahheo6qMusFP2uh7hq2UGOdlxqvfruI7cEWd0MvhrCBAq emGDaBecGN7jv8f89FGDQ3bnf7Eq+pp9uaHl1OkVMmh0nVloX1HdTIbW4xdwbnW9 wmny/fPZcaGGEk4utiITTKpAyJwSZqgj0xLPPdGOWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefgedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepteefffefgfektdefgfeludfgtdejfeejvddttdekteeiffejvdfgheeh fffhvedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Jun 2022 03:57:27 -0400 (EDT) Date: Wed, 22 Jun 2022 09:57:25 +0200 From: Maxime Ripard To: Saud Farooqui Cc: jernej.skrabec@gmail.com, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, wens@csie.org, daniel@ffwll.ch Subject: Re: [PATCH v1] drm/sun4i: Return from the function in error condition Message-ID: <20220622075725.y6ws22ielpc4pmxw@houat> References: <20220609142253.7aad4jlaoahqkmy7@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_005729_235068_7D56A488 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0309686326691396588==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0309686326691396588== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dpuceqjgfufrqrxt" Content-Disposition: inline --dpuceqjgfufrqrxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Jun 21, 2022 at 09:44:27PM +0500, Saud Farooqui wrote: > Added return statement in sun4i_layer_format_mod_supported() > in case of error. >=20 > Signed-off-by: Saud Farooqui > --- > drivers/gpu/drm/sun4i/sun4i_layer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/= sun4i_layer.c > index 6d43080791a0..85fb9e800ddf 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -117,7 +117,7 @@ static bool sun4i_layer_format_mod_supported(struct d= rm_plane *plane, > struct sun4i_layer *layer =3D plane_to_sun4i_layer(plane); > =20 > if (IS_ERR_OR_NULL(layer->backend->frontend)) > - sun4i_backend_format_is_supported(format, modifier); > + return sun4i_backend_format_is_supported(format, modifier); While there's a bug, it definitely isn't what your commit message describe. Frontends only available on some SoCs and are thus optional in the driver. If the frontend pointer isn't set, it means that it isn't there and thus we try to figure out the format through the backend that is always there. Maxime --dpuceqjgfufrqrxt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYrLLZQAKCRDj7w1vZxhR xawwAP4u3twxDl6X0vHRjMf8txv6dArTqceH0FbDHlbmVRr+UgEAw7KvX806M1k8 y9t+0imQJJiEN4hGTzwC4nriK80T/AA= =om1g -----END PGP SIGNATURE----- --dpuceqjgfufrqrxt-- --===============0309686326691396588== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0309686326691396588==--