From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35797C433EF for ; Thu, 23 Jun 2022 17:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v/rqRwe4xqWJuSASsZfef/MqMZEqZSB/etdB1nlFyHI=; b=CzH+uGNdkrKh+X Ra+QqvsduApB1yziwQWtndF0oQgAFgJ7sgwCuXXaZ66ncahZS0Bs/gJPP7FV/yf/jdu3rNE0QKnAR WOykkLsbnU3YdauN+7oR4LofL902+yefRU3uEztznZwei8Gz6okYSccr58Rn4I0j1jf+aXgZVkGw/ H4RsFz+s2+Z5XZojbm+sPE/qQvFIXYD62LQtrQpJu65LyQ/5nVZ6KapZyE18tVObg+yssmStkG5OK JcVsoRfWf5R72bkox0M6s5PRATFp814vUZPaIJ2P5OX/9zKuZ5QWdDtPJy9w/G4LAA6OFUnAtsLcx vT7DnAVf4H0I18q9bImA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4Qvj-00GAvT-M6; Thu, 23 Jun 2022 17:47:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4Qvg-00GAv5-DL for linux-arm-kernel@lists.infradead.org; Thu, 23 Jun 2022 17:47:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8BA361B1C; Thu, 23 Jun 2022 17:47:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F9F1C3411B; Thu, 23 Jun 2022 17:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656006462; bh=RN59Dq6CO49ktixtoVE91NB9AVMW0PbALD6rMPIxaX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lXxdBHhAQ1VVoTqYm8mGAIurjstPmvKTpAV0veo/ZlBuPcur58RwPByM7vajRB2VR qJCUQhedOwLqcrAoVufznJgkToVtLZlIdU6g2yiFTMi3DA6ikEbd0Xx3SWLy3BMOeH N3rHdL2rDtVuG1Wo7eubiPpiJypisRpKw/BNE0QS0yEWDbagBEEF+bnDT/Nhw51IHA 7AVh4NfVHvl3+PytPiOah74zN7I11Bk6N/+ilvbfF0+PxJYRWDCGL8rlmBy1CX5sh6 +dOXh44ZHNMq4WFwyGulVgP3tysF7oxICf3vy7Ec80k9cj9Oz5n1D6t1V3Vmr+stsl HNiChEWLoRzCQ== Date: Thu, 23 Jun 2022 18:47:38 +0100 From: Will Deacon To: Mark Brown Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64/signal: Clean up SVE/SME feature checking inconsistency Message-ID: <20220623174737.GA17439@willie-the-truck> References: <20220613210133.1327091-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220613210133.1327091-1-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_104744_526219_4E987544 X-CRM114-Status: GOOD ( 21.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 13, 2022 at 10:01:33PM +0100, Mark Brown wrote: > Currently when restoring signal state we check to see if SVE is supported > in restore_sigframe() but check to see if SVE is supported inside > restore_sve_fpsimd_context(). This makes no real difference since SVE is > always supported in systems with SME but looks a bit untidy and makes > things slightly harder to follow, move the SVE check next to the SME one > in restore_sve_fpsimd_context(). > > Signed-off-by: Mark Brown > --- > arch/arm64/kernel/signal.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index 23dd4c3bcfed..0d5a9eb43085 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -281,6 +281,9 @@ static int restore_sve_fpsimd_context(struct user_ctxs *user) > > vl = task_get_sme_vl(current); > } else { > + if (!system_supports_sve()) > + return -EINVAL; > + > vl = task_get_sve_vl(current); > } > > @@ -652,14 +655,10 @@ static int restore_sigframe(struct pt_regs *regs, > if (!user.fpsimd) > return -EINVAL; > > - if (user.sve) { > - if (!system_supports_sve()) > - return -EINVAL; > - > + if (user.sve) > err = restore_sve_fpsimd_context(&user); This breaks the allnoconfig build for me: ld.lld: error: undefined symbol: restore_sve_fpsimd_context >>> referenced by signal.c >>> kernel/signal.o:(__arm64_sys_rt_sigreturn) in archive arch/arm64/built-in.a make: *** [Makefile:1164: vmlinux] Error 1 Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel