From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 895CBC43334 for ; Fri, 24 Jun 2022 17:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=SXq09IHACUAi4su6eRNwuF93MYyH8ITTPPvqcsGsZjI=; b=zbOq14XmNXKdIL nVmt6vR+fOEvfwhkA6GCvWIdWVMBPTbGwt0QZ/Qv2zWr1eIOmT0AV4pACCGUDxdPV4MVfsGa/BU4K qZUe82YpIQNGMAghflS5YlRUfMGNEtcK9BRSlYsREl/in2hCRfb2rTsUG4CeJhcKjlUkv/mHGE/zW uMYJ74zF562wDKR95PKFS/1gw8x8hUfqlPDZ1qHMnup7S7KOohjlgV3DPjOf9qT7Uk32hovXZoAh+ tB33WTMzy2ORYHtrpypIuKa8ZPG/sM8yKA6vcTims8Dn1TeIydT10WLRkaZGLKi9hPh3ThL8fcGi1 KwepwczkaVFd99ns9t0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4nDi-003H6n-3j; Fri, 24 Jun 2022 17:35:50 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4nDe-003H6K-PF for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 17:35:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1A2DB82AD6; Fri, 24 Jun 2022 17:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 256E3C34114; Fri, 24 Jun 2022 17:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656092143; bh=jNWQgByNPGwt1vuGYhLV57h57DF3v7csL/7CapG0qJ8=; h=Date:From:To:Cc:Subject:From; b=QjcgpRPkaeb4vmkKrM7HzojQ7QA1S2Y+QHycO8lBVYM4nB84sBUKxoyqINIcCTzC/ u/AeRZn0WiiUnM50mBwZLWHIZ6NNnH9kWGifcisyMZ4CBRe9sg00AP1z7zUW/CuB+G 2l/Eh/WMNkO2vFKOPb0Q8tGm16J05+wa3qb2zU53H8iX6eue9i3i+jP6bXYDVZfeUx G/t1KzuGZePUnckiLtgo7CLbjULohSJUfrQIe7pZivyt49mrWyjq/irQlRJROOgOmn w1twxoqkVjtBBUeAkuYd86Rgk7z6Ormeov5mGZecpDeSJwLbjIV0bl4Ha/G2d0f8ZN p1igItfuZzLTw== Date: Fri, 24 Jun 2022 12:35:41 -0500 From: Bjorn Helgaas To: Jaehoon Chung , Jingoo Han Cc: Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Alim Akhtar , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: pci-exynos.c phy_init() usage Message-ID: <20220624173541.GA1543581@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_103546_993611_9A8746E5 X-CRM114-Status: UNSURE ( 5.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In exynos_pcie_host_init() [1], we call: phy_reset(ep->phy); phy_power_on(ep->phy); phy_init(ep->phy); The phy_init() function comment [2] says it must be called before phy_power_on(). Is exynos doing this backwards? Bjorn [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pci-exynos.c?id=v5.19-rc1#n252 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-core.c?id=v5.19-rc1#n233 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel