* [PATCH v1] phy: rockchip-inno-usb2: Prevent incorrect error on probe
@ 2022-06-25 21:27 Peter Geis
2022-07-05 6:33 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Geis @ 2022-06-25 21:27 UTC (permalink / raw)
To: Heiko Stuebner, Kishon Vijay Abraham I, Vinod Koul
Cc: Peter Geis, linux-phy, linux-arm-kernel, linux-rockchip,
linux-kernel
If a phy supply is designated but isn't available at probe time, an
EPROBE_DEFER is returned. Use dev_err_probe to prevent this from
incorrectly printing during boot.
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 6e44069617df..706a2263b0b2 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1289,7 +1289,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
phy = devm_phy_create(dev, child_np, &rockchip_usb2phy_ops);
if (IS_ERR(phy)) {
- dev_err(dev, "failed to create phy\n");
+ dev_err_probe(dev, PTR_ERR(phy), "failed to create phy\n");
ret = PTR_ERR(phy);
goto put_child;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] phy: rockchip-inno-usb2: Prevent incorrect error on probe
2022-06-25 21:27 [PATCH v1] phy: rockchip-inno-usb2: Prevent incorrect error on probe Peter Geis
@ 2022-07-05 6:33 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-07-05 6:33 UTC (permalink / raw)
To: Peter Geis
Cc: Heiko Stuebner, Kishon Vijay Abraham I, linux-phy,
linux-arm-kernel, linux-rockchip, linux-kernel
On 25-06-22, 17:27, Peter Geis wrote:
> If a phy supply is designated but isn't available at probe time, an
> EPROBE_DEFER is returned. Use dev_err_probe to prevent this from
> incorrectly printing during boot.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-25 21:27 [PATCH v1] phy: rockchip-inno-usb2: Prevent incorrect error on probe Peter Geis
2022-07-05 6:33 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).