From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E73B1C433EF for ; Mon, 27 Jun 2022 02:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4HOEQjXa+yDWwmF3wirPc8Rjcbau0Wb6tuFqa8sDpQU=; b=SAeww7UzJzLRtt XsIj993Fb+i2jxB8OnDXl0aW3PzcXEB4CB8bdfLVFgXQLtNk5aSFglmci5TpqPr0hWi4OzTIz058Q 7VMQF6vehXwtTYslw/iiWipFw+m0a38Q4O4LMuWSqikHNH0/pn434r5f9EdKjlYOtSqV0TqolAj3r 9LdG/Ra7e78DLE/E80bti5d+GjWOCmlInmvMxQvkWNPVbR+Dr8D1w0y68nm0n1ulAL8X5BQDzj/ne 9ItLWbTvOWyGDeyp8nb5QhkK3clD9EZThKHI7jmfPDV8ihZUgMXGvwHpHXm1DiB1BGQjDfKfTDhPC /EAamw04IjIdNLPWwDsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5e5m-00EahR-0p; Mon, 27 Jun 2022 02:03:10 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5e5i-00EafI-EC for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 02:03:07 +0000 Received: by mail-pl1-x62e.google.com with SMTP id r1so6869012plo.10 for ; Sun, 26 Jun 2022 19:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cFzsYDSniCnlBZ03HwKNu3S5QmFfxy2xvMgtRDJMZis=; b=W9NMxYS6VjeyTC2cMMP/U2hMAgucbyOeYIMRtdhZhBzWM9I5CHJvC78CT5KjWoRSaI YMzEn64lLecRyWTMhmh0DrHudZ2V8CW8H/fh2J5A0kUiPIXFaaiKzPzEaOeWTlieEib0 RzNwvSJPuZS6TGyznaBwVLM9izVf6IwyagW8sNL0vyHz9rXDH9/INPnaOfE4mNWGB6+j EHtJnShucEnJpz2SjeJ3B06AvpibDKU7g8RGBvsSTA6UqjenJhNn4rlQ3c05GJmR4qcl Lk+TrcPs0cWqt6+Kmek4rYYmJccguriPiiBOQudPQNC9JtmDL6HWcSgH0IN2z+JLduXZ gFmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cFzsYDSniCnlBZ03HwKNu3S5QmFfxy2xvMgtRDJMZis=; b=OD+9r3U40f3QvJh1P4WtOBZARz5pcSEFRetboLtZkTi3dMrQZ9APJ9ogMdAwuY5kMK Nehww4ZVM/zsLc/HPi1srrMJTa7gAiERZ734aut+ZNjR7Mve4NzNgvlmNhxerEmLe1I+ 2hYY1IJJQ5rZFSTi2nWfGaLSp0VRvEjNyogUkbmAp0ghaShMs8OLbOH/GwwxPFZt6fwL eiHI+lG9NDxrekHrbHjq05iPWIsuqieRa9cSAbBEp9OuyHMm7NpxzXQRl8//9ont8VhQ hvKqFtrJR5OLLbeuwSrst0gu3J4Iw7lCvKbho9ezJUpb9JNHOAh04VKuLT5nJF+n0h3r +fXg== X-Gm-Message-State: AJIora+JXeNzA+nLalk8gaoMvTRFLTJgEUoYWMpgBYWTGNvp5hvc6yCd JSVuD7PU6KAUKrs+qc4hOX7oUA== X-Google-Smtp-Source: AGRyM1sMApCNujHeAcMS6o2le4b1Rwn51Wk9w2AAmuhkBTXz7YYbL0AMbuIim8kFUBy3QBW5KtcrJg== X-Received: by 2002:a17:90b:4c86:b0:1ec:cc0f:32da with SMTP id my6-20020a17090b4c8600b001eccc0f32damr18286077pjb.66.1656295384629; Sun, 26 Jun 2022 19:03:04 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([103.135.249.206]) by smtp.gmail.com with ESMTPSA id g8-20020a056a00078800b0050e006279bfsm5834982pfu.137.2022.06.26.19.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 19:03:04 -0700 (PDT) Date: Mon, 27 Jun 2022 10:02:56 +0800 From: Leo Yan To: Yicong Yang Cc: gregkh@linuxfoundation.org, alexander.shishkin@linux.intel.com, james.clark@arm.com, will@kernel.org, robin.murphy@arm.com, acme@kernel.org, jonathan.cameron@huawei.com, john.garry@huawei.com, helgaas@kernel.org, lorenzo.pieralisi@arm.com, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mark.rutland@arm.com, joro@8bytes.org, shameerali.kolothum.thodi@huawei.com, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, iommu@lists.linux-foundation.org, prime.zeng@huawei.com, liuqi115@huawei.com, zhangshaokun@hisilicon.com, linuxarm@huawei.com Subject: Re: [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver Message-ID: <20220627020256.GB143063@leoy-ThinkPad-X240s> References: <20220606115555.41103-1-yangyicong@hisilicon.com> <20220606115555.41103-6-yangyicong@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220606115555.41103-6-yangyicong@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_190306_506920_4F0A37D6 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022 at 07:55:52PM +0800, Yicong Yang wrote: > From: Qi Liu > > HiSilicon PCIe tune and trace device (PTT) could dynamically tune > the PCIe link's events, and trace the TLP headers). > > This patch add support for PTT device in perf tool, so users could > use 'perf record' to get TLP headers trace data. > > Signed-off-by: Qi Liu > Signed-off-by: Yicong Yang Just one minor comment. [...] > diff --git a/tools/perf/util/hisi-ptt.h b/tools/perf/util/hisi-ptt.h > new file mode 100644 > index 000000000000..2db9b4056214 > --- /dev/null > +++ b/tools/perf/util/hisi-ptt.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * HiSilicon PCIe Trace and Tuning (PTT) support > + * Copyright (c) 2022 HiSilicon Technologies Co., Ltd. > + */ > + > +#ifndef INCLUDE__PERF_HISI_PTT_H__ > +#define INCLUDE__PERF_HISI_PTT_H__ > + > +#define HISI_PTT_PMU_NAME "hisi_ptt" > +#define HISI_PTT_AUXTRACE_PRIV_SIZE sizeof(u64) > + > +struct auxtrace_record *hisi_ptt_recording_init(int *err, > + struct perf_pmu *hisi_ptt_pmu); > + > +int hisi_ptt_process_auxtrace_info(union perf_event *event, > + struct perf_session *session); The function hisi_ptt_process_auxtrace_info() is introduced by next patch for support PTT decoding, for good practice (e.g. keep bisection), it's good to introduce function declaration and definition in one patch. With this fixing, this patch looks good to me: Reviewed-by: Leo Yan > + > +#endif > -- > 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel