* [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful
@ 2022-06-24 18:29 Marek Vasut
2022-06-27 6:08 ` (EXT) " Alexander Stein
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2022-06-24 18:29 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexander Stein, Lucas Stach, Martyn Welch,
Paul Elder, Shawn Guo
Print the name of the power domain which failed to make the error
prints actually useful for finding the error.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Martyn Welch <martyn.welch@collabora.com>
Cc: Paul Elder <paul.elder@ideasonboard.com>
Cc: Shawn Guo <shawnguo@kernel.org>
---
drivers/soc/imx/imx8m-blk-ctrl.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index 7ebc28709e945..dff7529268e4d 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -216,7 +216,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
if (IS_ERR(bc->bus_power_dev))
return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
- "failed to attach power domain\n");
+ "failed to attach power domain \"bus\"\n");
for (i = 0; i < bc_data->num_domains; i++) {
const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i];
@@ -238,7 +238,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
dev_pm_domain_attach_by_name(dev, data->gpc_name);
if (IS_ERR(domain->power_dev)) {
dev_err_probe(dev, PTR_ERR(domain->power_dev),
- "failed to attach power domain\n");
+ "failed to attach power domain \"%s\"\n",
+ data->gpc_name);
ret = PTR_ERR(domain->power_dev);
goto cleanup_pds;
}
@@ -251,7 +252,9 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
ret = pm_genpd_init(&domain->genpd, NULL, true);
if (ret) {
- dev_err_probe(dev, ret, "failed to init power domain\n");
+ dev_err_probe(dev, ret,
+ "failed to init power domain \"%s\"\n",
+ data->gpc_name);
dev_pm_domain_detach(domain->power_dev, true);
goto cleanup_pds;
}
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: (EXT) [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful
2022-06-24 18:29 [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful Marek Vasut
@ 2022-06-27 6:08 ` Alexander Stein
2022-06-27 8:16 ` Shawn Guo
2022-07-08 14:09 ` Martyn Welch
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-06-27 6:08 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Marek Vasut, Lucas Stach, Martyn Welch,
Paul Elder, Shawn Guo
Am Freitag, 24. Juni 2022, 20:29:39 CEST schrieb Marek Vasut:
> Print the name of the power domain which failed to make the error
> prints actually useful for finding the error.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Martyn Welch <martyn.welch@collabora.com>
> Cc: Paul Elder <paul.elder@ideasonboard.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/soc/imx/imx8m-blk-ctrl.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
I did something similar locally. Especially the 1st two hunks are pretty
useful.
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c
> b/drivers/soc/imx/imx8m-blk-ctrl.c index 7ebc28709e945..dff7529268e4d
> 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -216,7 +216,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device
> *pdev) bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
> if (IS_ERR(bc->bus_power_dev))
> return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> - "failed to attach power
domain\n");
> + "failed to attach power
domain \"bus\"\n");
>
> for (i = 0; i < bc_data->num_domains; i++) {
> const struct imx8m_blk_ctrl_domain_data *data =
&bc_data->domains[i];
> @@ -238,7 +238,8 @@ static int imx8m_blk_ctrl_probe(struct platform_device
> *pdev) dev_pm_domain_attach_by_name(dev, data->gpc_name);
> if (IS_ERR(domain->power_dev)) {
> dev_err_probe(dev, PTR_ERR(domain-
>power_dev),
> - "failed to attach power
domain\n");
> + "failed to attach power
domain \"%s\"\n",
> + data->gpc_name);
> ret = PTR_ERR(domain->power_dev);
> goto cleanup_pds;
> }
> @@ -251,7 +252,9 @@ static int imx8m_blk_ctrl_probe(struct platform_device
> *pdev)
>
> ret = pm_genpd_init(&domain->genpd, NULL, true);
> if (ret) {
> - dev_err_probe(dev, ret, "failed to init power
domain\n");
> + dev_err_probe(dev, ret,
> + "failed to init power domain
\"%s\"\n",
> + data->gpc_name);
> dev_pm_domain_detach(domain->power_dev,
true);
> goto cleanup_pds;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful
2022-06-24 18:29 [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful Marek Vasut
2022-06-27 6:08 ` (EXT) " Alexander Stein
@ 2022-06-27 8:16 ` Shawn Guo
2022-07-08 14:09 ` Martyn Welch
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-06-27 8:16 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Alexander Stein, Lucas Stach, Martyn Welch,
Paul Elder
On Fri, Jun 24, 2022 at 08:29:39PM +0200, Marek Vasut wrote:
> Print the name of the power domain which failed to make the error
> prints actually useful for finding the error.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Martyn Welch <martyn.welch@collabora.com>
> Cc: Paul Elder <paul.elder@ideasonboard.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful
2022-06-24 18:29 [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful Marek Vasut
2022-06-27 6:08 ` (EXT) " Alexander Stein
2022-06-27 8:16 ` Shawn Guo
@ 2022-07-08 14:09 ` Martyn Welch
2 siblings, 0 replies; 4+ messages in thread
From: Martyn Welch @ 2022-07-08 14:09 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Alexander Stein, Lucas Stach, Paul Elder, Shawn Guo
On Fri, 2022-06-24 at 20:29 +0200, Marek Vasut wrote:
> Print the name of the power domain which failed to make the error
> prints actually useful for finding the error.
>
Boot tested on top of drm-misc-next-2022-06-30 using Innolux g121x1
LVDS panel connected to NXP i.MX8MP EVK.
Tested in combination with other patches, tree found here:
https://gitlab.collabora.com/martyn/linux/-/tree/6a4cccf50ea793d9e608ccda13468f8645aff6ad
Tested-by: Martyn Welch <martyn.welch@collabora.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Martyn Welch <martyn.welch@collabora.com>
> Cc: Paul Elder <paul.elder@ideasonboard.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/soc/imx/imx8m-blk-ctrl.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c
> b/drivers/soc/imx/imx8m-blk-ctrl.c
> index 7ebc28709e945..dff7529268e4d 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -216,7 +216,7 @@ static int imx8m_blk_ctrl_probe(struct
> platform_device *pdev)
> bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
> if (IS_ERR(bc->bus_power_dev))
> return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> - "failed to attach power
> domain\n");
> + "failed to attach power domain
> \"bus\"\n");
>
> for (i = 0; i < bc_data->num_domains; i++) {
> const struct imx8m_blk_ctrl_domain_data *data =
> &bc_data->domains[i];
> @@ -238,7 +238,8 @@ static int imx8m_blk_ctrl_probe(struct
> platform_device *pdev)
> dev_pm_domain_attach_by_name(dev, data-
> >gpc_name);
> if (IS_ERR(domain->power_dev)) {
> dev_err_probe(dev, PTR_ERR(domain-
> >power_dev),
> - "failed to attach power
> domain\n");
> + "failed to attach power domain
> \"%s\"\n",
> + data->gpc_name);
> ret = PTR_ERR(domain->power_dev);
> goto cleanup_pds;
> }
> @@ -251,7 +252,9 @@ static int imx8m_blk_ctrl_probe(struct
> platform_device *pdev)
>
> ret = pm_genpd_init(&domain->genpd, NULL, true);
> if (ret) {
> - dev_err_probe(dev, ret, "failed to init power
> domain\n");
> + dev_err_probe(dev, ret,
> + "failed to init power domain
> \"%s\"\n",
> + data->gpc_name);
> dev_pm_domain_detach(domain->power_dev,
> true);
> goto cleanup_pds;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-08 14:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-24 18:29 [PATCH] soc: imx: imx8m-blk-ctrl: Make error prints useful Marek Vasut
2022-06-27 6:08 ` (EXT) " Alexander Stein
2022-06-27 8:16 ` Shawn Guo
2022-07-08 14:09 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).