From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3D9FC433EF for ; Mon, 27 Jun 2022 12:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AKB3fUnd2D1XwCrMo1UKBQvS1oYwgKFmchxTh0zm858=; b=lWjScCRE13CZr1 dOon4q4hcAgkIkM6+maf5rwbTSoPXGECgpGNOxZjmTV6l4L9WzE/gxmMIKT9njNUUMX6OhKsnVMBc CxA1PH7DEsPMvLRCCwZTAbMUyErR5lDyCQ70Txj4zu8VP0TnGzR6BKreihpZDnjbbl/GiGUILK5UB pEBFJb2yMMU5E5o6ejnQLmMDkL2+EIjvsbnt4f/htqbTZlnKCarGAO7caFZBwbGx04QBSOFuCZogI fX8T3NP0zcW1KSBMwvVIfR85puc5s9wkkUfBQgts/494ZG6Zk/olwUde6TeD/8CoUvb6XokZL8q4A Jz8vfsPbZxzPTsNHY/lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nu5-000sZv-U7; Mon, 27 Jun 2022 12:31:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5ntR-000sJ2-2J for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 12:31:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF29F176A; Mon, 27 Jun 2022 05:31:03 -0700 (PDT) Received: from e120937-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B40053F792; Mon, 27 Jun 2022 05:31:01 -0700 (PDT) From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com, adrian.slatineanu@arm.com, souvik.chakravarty@arm.com, wleavitt@marvell.com, wbartczak@marvell.com, Cristian Marussi Subject: [PATCH v3 5/9] firmware: arm_scmi: Make use of FastChannels configurable Date: Mon, 27 Jun 2022 13:30:34 +0100 Message-Id: <20220627123038.1427067-6-cristian.marussi@arm.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220627123038.1427067-1-cristian.marussi@arm.com> References: <20220627123038.1427067-1-cristian.marussi@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_053105_198355_E537B6B7 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a Kernel configuration entry used to optionally disable, globally, the usage of SCMI FastChannels even on platforms where they are available. Make such option default-no to preserve the original SCMI system behaviour of using any available FC. Signed-off-by: Cristian Marussi --- v2 --> v3 - fixed wording in Kconfig - reverted Kconfig logic _USE_ -> _AVOID_ --- drivers/firmware/arm_scmi/Kconfig | 13 +++++++++++++ drivers/firmware/arm_scmi/driver.c | 6 ++++++ 2 files changed, 19 insertions(+) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig index 1e7b7fec97d9..3fb34db01014 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -42,6 +42,19 @@ config ARM_SCMI_HAVE_MSG This declares whether a message passing based transport for SCMI is available. +config ARM_SCMI_AVOID_FASTCHANNELS + bool "Avoid using SCMI FastChannels even when available" + help + Avoid using SCMI FastChannels even if advertised as available by + the platform. + + On systems where the SCMI platform advertises the availability of + FastChannels, supported SCMI commands can be issued triggering a + one-way FastChannel request, much more quickly than using a + regular SCMI message transfer. + When set to Y forces the OSPM to use instead regular SCMI message + transfers even if FastChannels are available. If unsure say N. + config ARM_SCMI_TRANSPORT_MAILBOX bool "SCMI transport based on Mailbox" depends on MAILBOX diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 00b7f2aff4ec..76dc82ba04b3 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1298,6 +1298,12 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph, struct scmi_msg_resp_desc_fc *resp; const struct scmi_protocol_instance *pi = ph_to_pi(ph); + if (IS_ENABLED(CONFIG_ARM_SCMI_AVOID_FASTCHANNELS)) { + dev_warn_once(ph->dev, + "FastChannels usage disabled in Kconfig.\n"); + return; + } + if (!p_addr) { ret = -EINVAL; goto err_out; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel