From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D8D2C433EF for ; Tue, 28 Jun 2022 11:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bUinY+rfAWklId87Oiv1yqr9tP52tETqnYysk2y8ccA=; b=ua6wahy0xFyJlv JQiyJ6tnvgvXL4VK1NCUm1wcdM5Ghfra636SOYntj8kgJlA7WcReutCdEo9+vo/4ZRpML8uQPlHf7 GGslnzW+cEy3SwLcyltmima96usIij/txrMIUym1XdBxAqhFd/NGbi9u7f0UtTnunJccm0Q0Rgbw7 X8bcMLriYvR9WsruiKx1DbDflk2P9SkP7Sz2vU0+GPPS0GmnngPBBCGTzCuYFD83wycCHkbTG3n6I mvpMIgNUlUSeiHdTM42hGGbDswfqZFc0jiasLeWVLUWVLKKJgrY7hjhXOuBPOdUvJIMLvZ2GRVAtR 8Aa/M9Mf/72tYaDO/5HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o68zx-005paw-IR; Tue, 28 Jun 2022 11:03:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o68zt-005pZb-OR for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 11:03:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 676D9619CF; Tue, 28 Jun 2022 11:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09003C341CA; Tue, 28 Jun 2022 11:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656414187; bh=uTdZoZ1skcBJGBohuXIOVKRZtrAs0MBBTX+3FECPSPM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTFnpETkyGVGCIM4IT+CvqMTRBxfyUH2ihtD+Z6y8Fzhuz4K6ByL17dn/JqWo8U52 cnkKJSbGRShN9x+q28qb8+1m77QJFbv3jW+QYoE88uZmQ34rBdSvSZLN26Xvqs+3tQ cYVl5Fhu2urVJCiAdyRBsC++ERu6xrPgJOcZygVO/x+neqyExKrH9fDG9FZlQZpnlQ lcM6W3Mr7Olw/eiFcb1Iw6w8fAd+Qub5SNLeXBHghqtoR0eltM1t/2O+TAJ2Wy1snX YViUPVJ/3BWwr8PTT1a3nX6ZjKV/Xx3yAuq9ED4fBURDkfXglUOus9Ay1UiiqnduEk KmS0ChAUYW93A== Date: Tue, 28 Jun 2022 12:03:02 +0100 From: Will Deacon To: Zhou Guanghui Cc: akpm@linux-foundation.org, rppt@kernel.org, anshuman.khandual@arm.com, darren@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, xuqiang36@huawei.com Subject: Re: [PATCH v5] memblock,arm64: Expand the static memblock memory table Message-ID: <20220628110301.GA23703@willie-the-truck> References: <20220615102742.96450-1-zhouguanghui1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220615102742.96450-1-zhouguanghui1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_040309_915899_CF5A79DD X-CRM114-Status: GOOD ( 26.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 15, 2022 at 10:27:42AM +0000, Zhou Guanghui wrote: > In a system(Huawei Ascend ARM64 SoC) using HBM, a multi-bit ECC error > occurs, and the BIOS will mark the corresponding area (for example, 2 MB) > as unusable. When the system restarts next time, these areas are not > reported or reported as EFI_UNUSABLE_MEMORY. Both cases lead to an > increase in the number of memblocks, whereas EFI_UNUSABLE_MEMORY > leads to a larger number of memblocks. > > For example, if the EFI_UNUSABLE_MEMORY type is reported: > ... > memory[0x92] [0x0000200834a00000-0x0000200835bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0 > memory[0x93] [0x0000200835c00000-0x0000200835dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x94] [0x0000200835e00000-0x00002008367fffff], 0x0000000000a00000 bytes on node 7 flags: 0x0 > memory[0x95] [0x0000200836800000-0x00002008369fffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x96] [0x0000200836a00000-0x0000200837bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0 > memory[0x97] [0x0000200837c00000-0x0000200837dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x98] [0x0000200837e00000-0x000020087fffffff], 0x0000000048200000 bytes on node 7 flags: 0x0 > memory[0x99] [0x0000200880000000-0x0000200bcfffffff], 0x0000000350000000 bytes on node 6 flags: 0x0 > memory[0x9a] [0x0000200bd0000000-0x0000200bd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9b] [0x0000200bd0200000-0x0000200bd07fffff], 0x0000000000600000 bytes on node 6 flags: 0x0 > memory[0x9c] [0x0000200bd0800000-0x0000200bd09fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9d] [0x0000200bd0a00000-0x0000200fcfffffff], 0x00000003ff600000 bytes on node 6 flags: 0x0 > memory[0x9e] [0x0000200fd0000000-0x0000200fd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9f] [0x0000200fd0200000-0x0000200fffffffff], 0x000000002fe00000 bytes on node 6 flags: 0x0 > ... > > The EFI memory map is parsed to construct the memblock arrays before > the memblock arrays can be resized. As the result, memory regions > beyond INIT_MEMBLOCK_REGIONS are lost. > > Add a new macro INIT_MEMBLOCK_MEMORY_REGTIONS to replace nit: s/REGTIONS/REGIONS/ > INIT_MEMBLOCK_REGTIONS to define the size of the static memblock.memory > array. > > Allow overriding memblock.memory array size with architecture defined > INIT_MEMBLOCK_MEMORY_REGIONS and make arm64 to set > INIT_MEMBLOCK_MEMORY_REGIONS to 1024 when CONFIG_EFI is enabled. > > Signed-off-by: Zhou Guanghui > Acked-by: Mike Rapoport > Tested-by: Darren Hart > --- > arch/arm64/include/asm/memory.h | 9 +++++++++ > mm/memblock.c | 14 +++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index 0af70d9abede..ce8614fa376a 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -364,6 +364,15 @@ void dump_mem_limit(void); > # define INIT_MEMBLOCK_RESERVED_REGIONS (INIT_MEMBLOCK_REGIONS + NR_CPUS + 1) > #endif > > +/* > + * memory regions which marked with flag MEMBLOCK_NOMAP(for example, the memory > + * of the EFI_UNUSABLE_MEMORY type) may divide a continuous memory block into > + * multiple parts. As a result, the number of memory regions is large. > + */ > +#ifdef CONFIG_EFI > +#define INIT_MEMBLOCK_MEMORY_REGIONS (INIT_MEMBLOCK_REGIONS * 8) > +#endif > + > #include > > #endif /* __ASM_MEMORY_H */ For the arm64 bit: Acked-by: Will Deacon I'm assuming Andrew will pick this up, but please yell if you'd prefer it to go via the arm64 tree. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel