From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D4EC433EF for ; Wed, 29 Jun 2022 03:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cd+wpqUXm+r3V8ldc2S0ilOUJQfEl2qN/Uils4XGPhc=; b=EjEtYqF4RSSo0D x+ubhsCuD8gvkuhb5Bx0EZ0WWFrHrUumZj1zSGMc8iNgklGrlOE6u0BMjzjHvKeMMMCFrWDiDy1C9 koXv8AofKdl1eKscBN1qeKZ9QpMPEoXsVRshFkXa8w5jwgRbCYn4qGJZkOqUHsluiXhCO/SeZHzG6 WH1eRoo8szJfpbRhUlioq/HYxvyV7zzKDnEwHurlHmyKjSMJEoNsjxuHaFSZ8D7kBSpE6kp6nLYNs abJNJXc9cvyQeSmB9YSHvl9A6CFgo1yUqydvu8FqVlEFD2o+uupKb1eWSO/PVt8lXnVDJxSOV36zo Bt0oxOMJB1Ko2hZHIDQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6OJu-009F3h-UJ; Wed, 29 Jun 2022 03:24:51 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6OJN-009EoF-Qo for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 03:24:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA89F61D7A; Wed, 29 Jun 2022 03:24:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC686C341C6; Wed, 29 Jun 2022 03:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656473056; bh=hEKpqsCTCBYl6X3gx6o4CGg4SOmuRDZ3EoHxt9IO4QA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IhmRobJSTIP86pLtSRAiaGG98BmiqQqGSXRMjhzDITCuEpkAwp5eCrogCu1DVC4Ih e50Vdb4galVkGeIOYFbI/eDIWJ/XXq1dFSQgyj2Gl8ZeRvKdg4kmOS22Y2QsjcQm0g UgGPMw7F2ZXVKKY8j16xQvZ6UDXgfrm+9kLh/kgRp2tXl2gbss9tg1MB3RC8A5gN60 fqQjfkPXY+CIhOvcJcl2OIhwnq2PmJBxqIg8njS7vTeFcyC+OjTQRIPUoxiChWc2PA HOM0mvHoXbCDSZYWR9j9n71AS5hGnEjF+whcOpjJX03ScJmD8tMjAbk8C3uOylkekO 0E5mkTI/KcKKQ== Date: Tue, 28 Jun 2022 20:24:14 -0700 From: Jakub Kicinski To: Jonathan Lemon Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Vadim Fedorenko , Aya Levin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops Message-ID: <20220628202414.02ac8fd1@kernel.org> In-Reply-To: <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com> References: <20220626192444.29321-1-vfedorenko@novek.ru> <20220626192444.29321-4-vfedorenko@novek.ru> <20220627193436.3wjunjqqtx7dtqm6@bsd-mbp.dhcp.thefacebook.com> <7c2fa2e9-6353-5472-75c8-b3ffe403f0f3@novek.ru> <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_202417_961904_8E59D023 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Jun 2022 12:11:24 -0700 Jonathan Lemon wrote: > > > 80-column limit (here and throughout the file) > > > > I thought this rule was relaxed up to 100-columns? > > Only in exceptional cases, IIRC. checkpatch complains too. Yup, for networking I still prefer 80 chars. My field of vision is narrow. > > > 80 cols, and this should be done before ptp_ocp_complete() > > > Also, should 'goto out', not return 0 and leak resources. > > > > I don't think we have to go with error path. Driver itself can work without > > DPLL device registered, there is no hard dependency. The DPLL device will > > not be registered and HW could not be configured/monitored via netlink, but > > could still be usable. > > Not sure I agree with that - the DPLL device is selected in Kconfig, so > users would expect to have it present. I think it makes more sense to > fail if it cannot be allocated. +1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel