From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 906ABC43334 for ; Wed, 29 Jun 2022 03:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=83S8a5zLS7NBq3bZ5ZeDbXbHnLrquDwDNHGvWcb1DWI=; b=YToZZgIq8sIbwK gqk0Uo0WG9bhr4P3Guw3P/PTUWJSo+Jt/z1BM133szRVK9k2DdjAJcE39epGFXUhYZHTg59qZ5Vpv UxSeLJO0iGAabgWxGDNxYED5dzT9CsA5DwMImtvy9TsYWDwdLT5shdj4Hawq19v2qQtnUuQjjOgDx e/7I0PxkY8PKPCWIZtkPjSMPQQWEruxBvT3828e3UTtfz/ckwpruYvsE5o2mM3xTh1UmH7hiI52AN fJug1KTtiWxuTt3kvlVw1q8nGlEwWEutuUzBUAWDWD6UXUVP/F4jQonyPiSqkov5OfqUMGK3U8oLI Urk+hg8xjhXyE08CuBsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Omq-009LPp-BK; Wed, 29 Jun 2022 03:54:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Omn-009LOw-AP for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 03:54:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 845CEB82142; Wed, 29 Jun 2022 03:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C218AC34114; Wed, 29 Jun 2022 03:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656474877; bh=uGe21oy82tSdMA/YvpYvQVzqQbNQiBgl0vADr1AFTdY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lNSlP1p+ukhqJtiPg2ozJ5MLFhq2KeadAUOnIaxqNjPNALtINmszC1a778vlk/+Jv QAi+R+5uceMsmtAbOx35LGxwwsPcG0N2aZ+xHf4OAHNKpYqjQWLHKDy+z8GsRcpjI2 XfxkCtqrEMAYKbPBm+8t/6UpYntRTKDFFD3oQXjdANESi/s6807MUxASlB3AZJguBc ulLXwIGHyiIFe+nY3V7+XDNQVP4q316rjalagSZzFQqTObTNvShUZ5jr84p16jxDJo 9ztfUwwO77UzYDDz5UlTNYCA8E+GCGUhlAfZE0N8k8A/72C6N87rVJhy9/HJOQ0JE0 u89rPBXslFfCg== Date: Tue, 28 Jun 2022 20:54:35 -0700 From: Jakub Kicinski To: Christian Marangi Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Russell King , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH RFC 2/5] net: ethernet: stmicro: stmmac: first disable all queues in release Message-ID: <20220628205435.44b0c78c@kernel.org> In-Reply-To: <20220628013342.13581-3-ansuelsmth@gmail.com> References: <20220628013342.13581-1-ansuelsmth@gmail.com> <20220628013342.13581-3-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_205441_546372_7B37F5B5 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Jun 2022 03:33:39 +0200 Christian Marangi wrote: > + stmmac_disable_all_queues(priv); > + > + for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) > + hrtimer_cancel(&priv->tx_queue[chan].txtimer); IIRC this hrtimer is to check for completions. Canceling it before netif_tx_disable() looks odd, presumably until the queues are stopped the timer can get scheduled again, no? > netif_tx_disable(dev); > > if (device_may_wakeup(priv->device)) > @@ -3764,11 +3769,6 @@ static int stmmac_release(struct net_device *dev) > phylink_stop(priv->phylink); > phylink_disconnect_phy(priv->phylink); > > - stmmac_disable_all_queues(priv); > - > - for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) > - hrtimer_cancel(&priv->tx_queue[chan].txtimer); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel