From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A17DC43334 for ; Tue, 28 Jun 2022 21:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MhTzfgEoZ+HhhCybw5/KZyc4kDwBqE2THx0K7ZguXu8=; b=KFtxVgv4r+iw3X OKzJP7xqdwYXJGPNKzx0qUIPjh1dM7dQk4XzojVDuGjgjBOfvzj4GXvd7xnshIPHmQmIZB1Oifa+e BuhQ3gmrRHUyra9KnTS1G3ESrr9XKEQCEE1j4tIUS9n8PAYsKYhx2zJXgfGEEuJVurj87RjNqkYOF oELtNbhCuAfHj2W0NDwFdb3bbRJn3Y/rKbZLGhC362FIICwrhDdqeqyVkWj3eRfJEXV6JM0lW/F/b 13wkcAdHZsU6F32/LhBwJpO8RuxO8/3Pcs50RbP/DkbyoZHQzcGCD68yJp+2fshg2Ck3d5DioQNnO vyAvDmXcNTD/Qgd7NKFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6IZz-008Drb-TN; Tue, 28 Jun 2022 21:17:04 +0000 Received: from mail-io1-f53.google.com ([209.85.166.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6IZd-008Dov-Pe for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 21:16:43 +0000 Received: by mail-io1-f53.google.com with SMTP id z191so14135449iof.6 for ; Tue, 28 Jun 2022 14:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6HD4W3yTR1trUTVfpbXVBov8MqgZQbqZwaTmCO/6Gyw=; b=BVq5BmV3N7rKWECgsd6m4p6UwkK24/fW+OdgrjpP3bA/x+dbAQpwH/x6pSenoyIZAt PHJMmPvcymGj56edTZ6VEjNT1CpTi+sh+IyegUnK61X2kM6R3IjExyijox1HL2Gnw4Cl yfHCaDNVSQ+vk8mmD2AQZpmZMaMhKhFq0rb3A3BMFBop3JEOLNm98UVNMeTH1j6RLNi1 12m3Afv6ygKjZW/h9FmEZHJ9Ml11KfNQO13CbYbW5fdSxQlthbGT7ih/ljcwcjE/e38Y olgN6W5N9tlYQ5mVl0o3/XtUDYu+czU3sZOyAX8XHGHejZtJtIZDFwIyciOL7CkqB/M2 yz0Q== X-Gm-Message-State: AJIora+ljlKfv/GCmQnwKEdrpLgTDJ+m4JDZAOEoZzIxrqduhYsPtDMo th1UJiJ+5oTvKCtUD8Kw6f/Twd0AvA== X-Google-Smtp-Source: AGRyM1tAN+UKhd4ZNCy6ruF8nKrB14lOgEXw1PfT0QscrNfgDtA9XVc6TRWrOdw7ywOiRCTazGW4fA== X-Received: by 2002:a05:6638:218f:b0:33c:caf0:a61c with SMTP id s15-20020a056638218f00b0033ccaf0a61cmr67781jaj.198.1656451000493; Tue, 28 Jun 2022 14:16:40 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id q4-20020a056e020c2400b002d95c4d56d3sm6141440ilg.76.2022.06.28.14.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 14:16:40 -0700 (PDT) Received: (nullmailer pid 990409 invoked by uid 1000); Tue, 28 Jun 2022 21:16:38 -0000 Date: Tue, 28 Jun 2022 15:16:38 -0600 From: Rob Herring To: Kavyasree.Kotagiri@microchip.com Subject: Re: [PATCH v4 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Message-ID: <20220628211638.GC963202-robh@kernel.org> References: <20220617130729.12072-1-kavyasree.kotagiri@microchip.com> <20220617130729.12072-2-kavyasree.kotagiri@microchip.com> <1655474312.882258.1508989.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_141641_874623_13612E99 X-CRM114-Status: GOOD ( 22.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, krzysztof.kozlowski+dt@linaro.org, UNGLinuxDriver@microchip.com, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022 at 11:45:31AM +0000, Kavyasree.Kotagiri@microchip.com wrote: > > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri > > > --- > > > v3 -> v4: > > > - Corrected format of enum used for compatible string. > > > > > > v2 -> v3: > > > - used enum for compatible string. > > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > > - fixed dtschema errors. > > > > > > v1 -> v2: > > > - Fix title. > > > > > > .../bindings/mfd/atmel,flexcom.yaml | 104 ++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------- > > > 2 files changed, 104 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > flexcom@f0000000: spi@400:compatible:0: 'atmel,at91rm9200-spi' was > > expected > > arch/arm/boot/dts/at91-sam9x60ek.dtb > > > > flexcom@f0000000: spi@400:compatible: ['microchip,sam9x60-spi', > > 'atmel,at91rm9200-spi'] is too long > > arch/arm/boot/dts/at91-sam9x60ek.dtb > > These errors are expected because "microchip,sam9x60-spi" and "atmel,at91rm9200-spi" > are documented in Documentation/devicetree/bindings/spi/spi_atmel.txt. > which I added in description as > " description: See ../spi/spi_atmel.txt for details of SPI bindings." If that was still true, there would not be a warning because .txt files don't cause warnings. You've defined the SPI compatible here and that doesn't agree with the dts files. One of them is wrong. Normally, child nodes either just reference another schema or document everything locally. You've done a mixture which is not right. Presumably that was to avoid 'undocumented compatible' warnings. To fix that you either need to convert the SPI binding or don't use it in the example. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel