From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E331C433EF for ; Wed, 29 Jun 2022 05:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FvBxGQSLjC2NRxN3rVu5CaeTe4HQ04nk3IHHmr/idRs=; b=vWIWIMtZYVRmXm ZrRr7c+/rd1hizk99XNqGkPeB47F03AtJWUr1tw3sadTrTG99FXS5pjMGnp5/d59v3cjhzSfoR9Si WNlQzxRqliUmnF3uxrClUpY1oMpER/q+rp24Aclwm/lbTyMgae1sPOlN1YM1zXT64JGoC4DCW25hv KJcfD2b63wn/u3BANAgnRg3X/EXcSB0hrI9G3Rau+8jhj0hV4v846KRWaTFVOp9qhrEnuwibhEsaC nrsJniNVtjIx/5v5sjsmhXQeKQZj4fC43BQ6C77Pb6h7yF6g3wtTRVmzwpj2AbRpSeuplxJm4C5AM mry39+9bjJ0S9OZjyl2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Qgd-009fwv-8H; Wed, 29 Jun 2022 05:56:27 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Qga-009fvz-VG for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 05:56:26 +0000 Received: by mail-pl1-x629.google.com with SMTP id n10so13159161plp.0 for ; Tue, 28 Jun 2022 22:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zysuHUP/InQT5Fi1lB0z6tjNnC0mTo16xnyZM6YuAJw=; b=QK/5e2zQieB6A4dmexNIProsq3M79RKCnmora4GTRtVMPjkkvv3D4aT204RFEfBWx4 nId2C5ed5MHevimldiWc6Cjde/EbequTigTeiNKdBodzJkUX9bD3ohxdMQnuIO16C92c cp955TzJcSZV4gQvc+gd9U7cL8BLf4+2kKrf4Hte3bACe8eIPTlrlIg7Ph1vWkIcuXDl fIr+vIWPAyjVLyKVR71SZZjibIWSUNaAIDtHoXjlHTCVYvRZ/udaUv5cKICLS4WUOmEz Y+mN1BV0/tn9BU7nWku0MgYLRIP8nEaeWD2bIzk+D5O6mxgA5I1AkhOhyH6BrtTW/hZb a6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zysuHUP/InQT5Fi1lB0z6tjNnC0mTo16xnyZM6YuAJw=; b=FzrtHRa2pBKp5l50jLG4mVx/jlezMxDM/RL8aZcN/kkBgoZLn5dot75ZLSNOpwnOZR A3mJxPjLGVhuiINv2hYnpvTF/V7x0Yhzb9khjob9siH1/A+D051NE4GPq5fBnyOZAbXX jzHlhPnGZKNPqJii4fxV6cSEHIJfPetlOlGObFY2E/OVcJrXO33FAeyMSqrcq9qTP50y HJWEtX56DZ7+7u5qLFV9vmd3nE0TuxTHdODJ3S8mVjOZn4RTKxDVqHHLSs6VIZrC78gR IayXXvm+pGh3so8VmL7Js4F6f9d1YR6W+HCMbgZKX3ogcH0+epYVoOQnzOe6KyWXdVFH /oBw== X-Gm-Message-State: AJIora+jmQqZ0OPjbomSDGHZ4jdd4BgbtjHXb9EfiOTXQamX0NLgKCAt Z/17YU6Uwm7Io26YfF0G2tk= X-Google-Smtp-Source: AGRyM1tXAC4bhW6xMpfXOnI72qyaFcpjuVyN0Ilx++e7/GU7Zz0+Z6//cTeok3vV2AY7ITsad9MSHg== X-Received: by 2002:a17:90b:4ac7:b0:1ed:21e8:ddb2 with SMTP id mh7-20020a17090b4ac700b001ed21e8ddb2mr1929375pjb.93.1656482181452; Tue, 28 Jun 2022 22:56:21 -0700 (PDT) Received: from sebin-inspiron.bbrouter ([103.160.194.58]) by smtp.gmail.com with ESMTPSA id p12-20020aa79e8c000000b0050dc7628162sm10587451pfq.60.2022.06.28.22.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 22:56:20 -0700 (PDT) From: SebinSebastian To: Cc: mailmesebin00@gmail.com, skhan@linuxfoundation.org, Neal Liu , Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH-next] usb: gadget: dereference before null check Date: Wed, 29 Jun 2022 11:26:05 +0530 Message-Id: <20220629055605.102425-1-mailmesebin00@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_225625_049866_6CEA6E07 X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Sebin Sebastian Fix coverity warning dereferencing before null check. _ep and desc is deferenced on all paths until the check for null. Move the initilizations after the check for null. Coverity issue: 1518209 Signed-off-by: Sebin Sebastian --- drivers/usb/gadget/udc/aspeed_udc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index d75a4e070bf7..4f158030e2cc 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -341,10 +341,6 @@ static void ast_udc_stop_activity(struct ast_udc_dev *udc) static int ast_udc_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { - u16 maxpacket = usb_endpoint_maxp(desc); - struct ast_udc_ep *ep = to_ast_ep(_ep); - struct ast_udc_dev *udc = ep->udc; - u8 epnum = usb_endpoint_num(desc); unsigned long flags; u32 ep_conf = 0; u8 dir_in; @@ -355,6 +351,12 @@ static int ast_udc_ep_enable(struct usb_ep *_ep, EP_DBG(ep, "Failed, invalid EP enable param\n"); return -EINVAL; } + + u16 maxpacket = usb_endpoint_maxp(desc); + struct ast_udc_ep *ep = to_ast_ep(_ep); + struct ast_udc_dev *udc = ep->udc; + u8 epnum = usb_endpoint_num(desc); + if (!udc->driver) { EP_DBG(ep, "bogus device state\n"); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel