From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D51FFC43334 for ; Wed, 29 Jun 2022 15:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nLD7r6imnnMHK1QF2XRKXiuzBlqPsddfJ1qVxhg7lEY=; b=vdmBO/yxEUA/YV Y3d2KyDFJw443Hhv2iadfF6n7AAj1U8IdzjMcMbfbWAu8NhR4Quvj0uHbkfHfQKTb/djDcY+7+aCM LOvShNM7M6Ib1+cP2BhF2MCqx3jfuYsLqa5Iz9Hk/JgnXeq9wqqdGz6DVV3h15efi+SwpN/A40u3S 5n9VKBVCD/8oE4yIUxTNZlZZKMOUTntIW2k3zEq4LpmpgkcxON1ERi381bM8mMROVmb/ByDzfMoX1 hNHQBoNDSzdh0Or7KvRPUy7NHkFUm/fpVAqp1+A5XYti3Oyvu1PXBuG8QW3exzttzVBEBQM6X7x1w ZIa7vWlU8x/DNid0s6Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Zpn-00Cjni-RT; Wed, 29 Jun 2022 15:42:31 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Zpj-00Cjjq-FN for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 15:42:30 +0000 Received: by mail-pj1-x1035.google.com with SMTP id i8-20020a17090aee8800b001ecc929d14dso1469032pjz.0 for ; Wed, 29 Jun 2022 08:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zjOz+dOpfn/ZXFE5mwDMrps6FORF/j9B7LOEhzIHpRI=; b=FbVPit12J5B8IK/PSv8XVFtSs9xOPlBXapEoB+wCfyw2dRPon1qVG2PqTu6zo25xIQ xrBBzNlaVexwiWNkYYeGnkDa/5lNXVm+IBe0Cu49FZZ9IW4LCOcTZZjNrO7zfMV0502D +WOcPencx3piR/y1FjXNNR34/YWN47XzxiSZ3/ZdOsVCy8cpexIT+m0CbLqIR5AI1RlU YdE7PChgb8v9xzgsyjTQ0b45P4w7OZeAhOmUTN8wjuVk0JB4VFIE+PZy9RZmItYtVFm5 y7Iam1kjb3bb6kiV4dWMfrs/LOpDoA6wAVxizRE0zNkOXKw2xmOtxElRbDe2d/FBQprz 5UJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zjOz+dOpfn/ZXFE5mwDMrps6FORF/j9B7LOEhzIHpRI=; b=7kZJZjSNSX761JQt1jGeBOCc38lRE+27qTFZx+auGCe86jJkbC0r84gVD344h79v0C 98nZx0BHjBFQx8TjSPEsiZgwJWibtse5WU+oSdKnmecYwHNv+OuyEMHPwfOj8HO2lfdr CSmmypEX/GyuqbI1Sfagl/TVBIIf4KhR9RrllB4XS87CZ6rjK1eMJiK+W1dtXadyxp+D gJWxGFy89iOMe2QZFU7HOCZaVeYYnVEVDrbN1v890wBnHE+EWFPhNTMZr6PkgDyOZKKw dj3DFbwZjdHDFv5Q09qPbk6j7sBcM6tZAGyJzfCyEryJoyX5hjpzU87te8gG9+GigsaU ee9g== X-Gm-Message-State: AJIora8OS2OsMhWlm5nc0TQAOhinEuCr9RVdBLFMrBjoGfpJGqqtHpA8 NSGcIRwsi5lAiPGCK9xRKVOVdIDTblex9A== X-Google-Smtp-Source: AGRyM1vdEvlHm0F6BizyDANRwjH4Oq6d++hB0xJMIU+RcynOAm++MyplN8HyHP3T5gFMd85UuqR3kg== X-Received: by 2002:a17:902:f602:b0:16a:178a:7b0b with SMTP id n2-20020a170902f60200b0016a178a7b0bmr10989763plg.20.1656517345046; Wed, 29 Jun 2022 08:42:25 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id jh2-20020a170903328200b00161478027f5sm11590507plb.150.2022.06.29.08.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 08:42:23 -0700 (PDT) Date: Wed, 29 Jun 2022 09:42:21 -0600 From: Mathieu Poirier To: Mike Leach Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, leo.yan@linaro.org Subject: Re: [PATCH v5 0/2] Fix lockdep issues seen in CoreSight configfs interface Message-ID: <20220629154221.GA2013207@p14s> References: <20220628173004.30002-1-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220628173004.30002-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_084228_122539_095E91CA X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 06:30:02PM +0100, Mike Leach wrote: > Issues with lockdep possible deadlock scenarios have been reported when using the > coresight configfs interface handling complex configuration, when unloading modules. > > These are due to holding the main configuration mutex during configfs register, but > taking it later when accessing configfs files. > > The patches improve the clean up of configurations and update load and unload of > configurations and initialisation of configfs to fix the locking mechanisms. > > Applies to coresight/next (5.19-rc2) > Tested on DB410c (with patch [0] also applied to fix separate console boot issue). > > Fixes: eb2ec49606c2 ("coresight: syscfg: Update load API for config loadable modules") > Reported-by: Suzuki Poulose > Signed-off-by: Mike Leach > Applied. Thanks, Mathieu > [0] https://lkml.kernel.org/r/20220614124618.2830569-1-suzuki.poulose@arm.com > > Changes since v4: > No functional change - fixed comment in patch header 1/2 and error string format to > remove checkpatch warning as requested by Mathieu. > > Changes since v3: > Addressed minor issues raised by Suzuki. > > Changes since v2: > Added additional work to fix load and unload ops after issue recurred > due to file access. > > Mike Leach (2): > coresight: configfs: Fix unload of configurations on module exit > coresight: syscfg: Update load and unload operations > > .../hwtracing/coresight/coresight-config.h | 2 + > .../hwtracing/coresight/coresight-syscfg.c | 298 +++++++++++++++--- > .../hwtracing/coresight/coresight-syscfg.h | 13 + > 3 files changed, 261 insertions(+), 52 deletions(-) > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel