From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCBDC43334 for ; Wed, 29 Jun 2022 21:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E8PJzFWgMDfZmvIH+lArbejG7+BxGT/lqcYx9MrXdT4=; b=cJOuibvLKihnV9 SyjjxqQkwFw+LocXTJF9dnkUP/xAX/I3b1ek0BX3HDg4fyDbDrMGgwSyw0r0X3FQZvA2MLfsTFyYe LTMnKnV5MKyx+M5Q9gmwqly2bNvzmcUtqXMOiqTrgy8ky8ZpiCoPUrCes4hGoWHEN7Qb2bqWtuvon Dmyrzbr4E/gbQ8//3PaXVUtxdDkzMDs6mpQj9ZUtW3WXy1xcUyCv7H6/5h4Ris8EWwBAEdEfouobC qXSKe212x04wHhbB7BF9JPQIi856i/+YcQoISHmNVUYi765KDRZRkHNWlwNsc+kCe1x8IOIj2GFSp x6CanjFZvClm++IuyYVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6fCH-00E7C7-4r; Wed, 29 Jun 2022 21:26:05 +0000 Received: from mail-il1-f179.google.com ([209.85.166.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6fCE-00E7Bd-Hh for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 21:26:03 +0000 Received: by mail-il1-f179.google.com with SMTP id n14so11136448ilt.10 for ; Wed, 29 Jun 2022 14:26:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BAnlbGwaJ9TyuQs7iWeZBAejDnwxdU93bNzpne1ImGI=; b=SsTi2sKwXUQ2bq0zAkkE7/FX4Fk9M0RUNpc0uWHs1lTl0Xr3IjIhSZQYM9dYRITRV4 eOBLCxV0G/kfZJwXt2C8ekV2tB/QK9mU7J8zWytnMkMnXehWp6xe1yCddA73Jwzue6wx 4uHY7fJWBrmic6TIUbFhz8yDSkMpCFqych7HEDmcK+yiUPSLUod5H0uf5EH0dWe1lxNV xxdhU85m1Us8jjI/uG4rYQ9qj3gHeQmzIjkwKiOPdu764fZ6dgPvbijCoOXftuyhOHwU 7HMGDzkUviGRNrMYqECK0R/yE2TnSrgIXFUuTAgvucZ4cuu4uR0MYChAio+ItQW2LRXB Q38A== X-Gm-Message-State: AJIora/jmLp9hl33kcVJazJ1uCNt241raQ/dGSoobekkP/xEUWp2SAEl HeRAhXpsIRNGSUknBqQLBA== X-Google-Smtp-Source: AGRyM1uGnG/FqvK7s4eQ1jjuMvP1A15YdewxNxXJDzr+xSEfqGJY54KWk2BtpcyvzmVd7hKKmbJofg== X-Received: by 2002:a05:6e02:1214:b0:2da:705c:5f03 with SMTP id a20-20020a056e02121400b002da705c5f03mr3048170ilq.318.1656537961129; Wed, 29 Jun 2022 14:26:01 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e24-20020a5d85d8000000b006694bc50b82sm8293589ios.35.2022.06.29.14.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 14:26:00 -0700 (PDT) Received: (nullmailer pid 858117 invoked by uid 1000); Wed, 29 Jun 2022 21:25:59 -0000 Date: Wed, 29 Jun 2022 15:25:59 -0600 From: Rob Herring To: Vabhav Sharma Cc: Horia Geanta , Gaurav Jain , Pankaj Gupta , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "shawnguo@kernel.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Silvano Di Ninno , Varun Sethi Subject: Re: [EXT] Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay property Message-ID: <20220629212559.GA843061-robh@kernel.org> References: <20220530180924.1792399-1-vabhav.sharma@nxp.com> <20220530180924.1792399-2-vabhav.sharma@nxp.com> <20220605212114.GA3528129-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_142602_610324_C426C44B X-CRM114-Status: GOOD ( 26.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 05:49:30PM +0000, Vabhav Sharma wrote: > Hello Rob, > > > -----Original Message----- > > From: Rob Herring > > Sent: Monday, June 6, 2022 2:51 AM > > To: Vabhav Sharma > > Cc: Horia Geanta ; Gaurav Jain > > ; Pankaj Gupta ; > > herbert@gondor.apana.org.au; davem@davemloft.net; > > shawnguo@kernel.org; linux-crypto@vger.kernel.org; linux- > > kernel@vger.kernel.org; dl-linux-imx ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Silvano Di > > Ninno ; Varun Sethi > > Subject: [EXT] Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay > > property > > > > Caution: EXT Email > > > > On Mon, May 30, 2022 at 11:39:22PM +0530, Vabhav Sharma wrote: > > > Add entropy delay property which defines the length (in system clocks) > > > of each Entropy sample taken for TRNG configuration. > > > > > > Signed-off-by: Vabhav Sharma > > > Reviewed-by: Horia Geanta > > > Reviewed-by: Varun Sethi > > > --- > > > Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > > b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > > index 8f359f473ada..1477294eda38 100644 > > > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > > @@ -62,6 +62,12 @@ PROPERTIES > > > Definition: A standard property. Define the 'ERA' of the SEC > > > device. > > > > > > + - entropy-delay > > > + Usage: optional > > > + Value type: > > > + Definition: A property which specifies the length (in system clocks) > > > + of each Entropy sample taken. > > > + > > > > Seems like this could be common, but should be a time value (with unit > > suffix) rather than clocks. If not common, then needs a vendor prefix. > > Is this time to read a value or time between values produced? Not really clear > > from the description. > CAAM TRNG Configuration includes 16-bit field entropy-delay. This field specifies how long the oscillator is given to freely oscillate and generate a single bit of entropy. > It is specified as number of system clock cycles and this u32 type field already exist in the caam driver code with default value of 3200. However, on some platform this value can vary and support is added to read the value from device tree in order to override default value, Hope this helps to clarify. So that is how often a sample can be read? Or what happens if you read a sample too quick (in less than this delay time)? Look at other h/w and drivers see if something common makes sense here. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel