From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18C33C43334 for ; Fri, 1 Jul 2022 12:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VpoMoHyAS3oMPqZL1wBXXLNywSeynD2NswKFqExqpcE=; b=FJDF/9C4fERDoe cOksYlhOxOF8bnMT/pE0obLf742Kj7VWREXfi2IIDiPRdqK5qO4IU8nVko2ClBZhya5OYDJLk7gbc 2cx88o1kzAo7NmYspZ3NnLuWe7O36/SbrSmQGvktSQWdCvUZ7+P4qk+SsZyM3yG9os1bJczAzXXrH NjAYiSE8/FKIoHoEt1bLEIeJH3VLAm9eOcLf12Gr178ReLxBVelCADwjXURX+0cXcZ0hj0mNNsVJX pYVKAMb+6R7UgAYIJa4J0VPKr4iU8yBimWX0eNLQZQ3aK5VRfAhsaiZhoEEghKxT32aEWwLnmLcqG bTdUnzTYbWaU67z0Ip5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7FrV-004odB-1J; Fri, 01 Jul 2022 12:35:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7FrP-004oaw-9Y for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 12:35:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC7FC113E; Fri, 1 Jul 2022 05:34:54 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6276D3F792; Fri, 1 Jul 2022 05:34:53 -0700 (PDT) Date: Fri, 1 Jul 2022 13:34:50 +0100 From: Sudeep Holla To: huhai <15815827059@163.com> Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, luriwen@kylinos.cn, liuyun01@kylinos.cn, huhai , Sudeep Holla Subject: Re: [PATCH] firmware: arm_scpi: Fix error handle when scpi probe failed Message-ID: <20220701123450.rdqffbyubuu63iph@bogus> References: <20220701061606.151366-1-15815827059@163.com> <20220701094212.snsnbdjc7hia5oti@bogus> <1752bac0.5d05.181b93873da.Coremail.15815827059@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1752bac0.5d05.181b93873da.Coremail.15815827059@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_053459_474292_60526FD0 X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMDEsIDIwMjIgYXQgMDY6MDQ6NTNQTSArMDgwMCwgaHVoYWkgd3JvdGU6Cj4g Cj4gc2NwaV9pbmZvIGlzIGEgZ2xvYmFsIHZhcmlhYmxl77yMIHdlIG11c3Qgc2V0IGl0IHRvIE5V TEwgd2hlbiBpdCBpcyBub3QgdmFsaWQKCkhvdyBhYm91dCBub3QgYXNzaWduaW5nIHRoZSBnbG9i YWwgdmFyaWFibGUgdW50aWwgdGhlIGVuZCBvZiB0aGUgcHJvYmUgPwpTb21ldGhpbmcgbGlrZSBi ZWxvdzoKClJlZ2FyZHMsClN1ZGVlcAoKLS0+OAoKZGlmZiAtLWdpdCBpL2RyaXZlcnMvZmlybXdh cmUvYXJtX3NjcGkuYyB3L2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjcGkuYwppbmRleCBkZGYwYjlm ZjllMTUuLjU0NjM1MDE3MzVmZiAxMDA2NDQKLS0tIGkvZHJpdmVycy9maXJtd2FyZS9hcm1fc2Nw aS5jCisrKyB3L2RyaXZlcnMvZmlybXdhcmUvYXJtX3NjcGkuYwpAQCAtOTEzLDEzICs5MTMsMTQg QEAgc3RhdGljIGludCBzY3BpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAg ICAgICAgc3RydWN0IHJlc291cmNlIHJlczsKICAgICAgICBzdHJ1Y3QgZGV2aWNlICpkZXYgPSAm cGRldi0+ZGV2OwogICAgICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSBkZXYtPm9mX25vZGU7 CisgICAgICAgc3RydWN0IHNjcGlfZHJ2aW5mbyAqc2NwaV9kcnZpbmZvOwoKLSAgICAgICBzY3Bp X2luZm8gPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKnNjcGlfaW5mbyksIEdGUF9LRVJORUwp OwotICAgICAgIGlmICghc2NwaV9pbmZvKQorICAgICAgIHNjcGlfZHJ2aW5mbyA9IGRldm1fa3ph bGxvYyhkZXYsIHNpemVvZigqc2NwaV9kcnZpbmZvKSwgR0ZQX0tFUk5FTCk7CisgICAgICAgaWYg KCFzY3BpX2RydmluZm8pCiAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKCiAgICAgICAg aWYgKG9mX21hdGNoX2RldmljZShsZWdhY3lfc2NwaV9vZl9tYXRjaCwgJnBkZXYtPmRldikpCi0g ICAgICAgICAgICAgICBzY3BpX2luZm8tPmlzX2xlZ2FjeSA9IHRydWU7CisgICAgICAgICAgICAg ICBzY3BpX2RydmluZm8tPmlzX2xlZ2FjeSA9IHRydWU7CgogICAgICAgIGNvdW50ID0gb2ZfY291 bnRfcGhhbmRsZV93aXRoX2FyZ3MobnAsICJtYm94ZXMiLCAiI21ib3gtY2VsbHMiKTsKICAgICAg ICBpZiAoY291bnQgPCAwKSB7CkBAIC05MjcsMTkgKzkyOCwxOSBAQCBzdGF0aWMgaW50IHNjcGlf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKICAgICAgICAgICAgICAgIHJldHVy biAtRU5PREVWOwogICAgICAgIH0KCi0gICAgICAgc2NwaV9pbmZvLT5jaGFubmVscyA9IGRldm1f a2NhbGxvYyhkZXYsIGNvdW50LCBzaXplb2Yoc3RydWN0IHNjcGlfY2hhbiksCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHRlBfS0VSTkVMKTsKLSAgICAgICBpZiAo IXNjcGlfaW5mby0+Y2hhbm5lbHMpCisgICAgICAgc2NwaV9kcnZpbmZvLT5jaGFubmVscyA9Cisg ICAgICAgICAgICAgICBkZXZtX2tjYWxsb2MoZGV2LCBjb3VudCwgc2l6ZW9mKHN0cnVjdCBzY3Bp X2NoYW4pLCBHRlBfS0VSTkVMKTsKKyAgICAgICBpZiAoIXNjcGlfZHJ2aW5mby0+Y2hhbm5lbHMp CiAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKCi0gICAgICAgcmV0ID0gZGV2bV9hZGRf YWN0aW9uKGRldiwgc2NwaV9mcmVlX2NoYW5uZWxzLCBzY3BpX2luZm8pOworICAgICAgIHJldCA9 IGRldm1fYWRkX2FjdGlvbihkZXYsIHNjcGlfZnJlZV9jaGFubmVscywgc2NwaV9kcnZpbmZvKTsK ICAgICAgICBpZiAocmV0KQogICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKCi0gICAgICAgZm9y ICg7IHNjcGlfaW5mby0+bnVtX2NoYW5zIDwgY291bnQ7IHNjcGlfaW5mby0+bnVtX2NoYW5zKysp IHsKKyAgICAgICBmb3IgKDsgc2NwaV9kcnZpbmZvLT5udW1fY2hhbnMgPCBjb3VudDsgc2NwaV9k cnZpbmZvLT5udW1fY2hhbnMrKykgewogICAgICAgICAgICAgICAgcmVzb3VyY2Vfc2l6ZV90IHNp emU7Ci0gICAgICAgICAgICAgICBpbnQgaWR4ID0gc2NwaV9pbmZvLT5udW1fY2hhbnM7Ci0gICAg ICAgICAgICAgICBzdHJ1Y3Qgc2NwaV9jaGFuICpwY2hhbiA9IHNjcGlfaW5mby0+Y2hhbm5lbHMg KyBpZHg7CisgICAgICAgICAgICAgICBpbnQgaWR4ID0gc2NwaV9kcnZpbmZvLT5udW1fY2hhbnM7 CisgICAgICAgICAgICAgICBzdHJ1Y3Qgc2NwaV9jaGFuICpwY2hhbiA9IHNjcGlfZHJ2aW5mby0+ Y2hhbm5lbHMgKyBpZHg7CiAgICAgICAgICAgICAgICBzdHJ1Y3QgbWJveF9jbGllbnQgKmNsID0g JnBjaGFuLT5jbDsKICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqc2htZW0gPSBv Zl9wYXJzZV9waGFuZGxlKG5wLCAic2htZW0iLCBpZHgpOwoKQEAgLTk4Niw0MyArOTg3LDQ0IEBA IHN0YXRpYyBpbnQgc2NwaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogICAg ICAgICAgICAgICAgcmV0dXJuIHJldDsKICAgICAgICB9CgotICAgICAgIHNjcGlfaW5mby0+Y29t bWFuZHMgPSBzY3BpX3N0ZF9jb21tYW5kczsKKyAgICAgICBzY3BpX2RydmluZm8tPmNvbW1hbmRz ID0gc2NwaV9zdGRfY29tbWFuZHM7CgotICAgICAgIHBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYs IHNjcGlfaW5mbyk7CisgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgc2NwaV9kcnZp bmZvKTsKCi0gICAgICAgaWYgKHNjcGlfaW5mby0+aXNfbGVnYWN5KSB7CisgICAgICAgaWYgKHNj cGlfZHJ2aW5mby0+aXNfbGVnYWN5KSB7CiAgICAgICAgICAgICAgICAvKiBSZXBsYWNlIHdpdGgg bGVnYWN5IHZhcmlhbnRzICovCiAgICAgICAgICAgICAgICBzY3BpX29wcy5jbGtfc2V0X3ZhbCA9 IGxlZ2FjeV9zY3BpX2Nsa19zZXRfdmFsOwotICAgICAgICAgICAgICAgc2NwaV9pbmZvLT5jb21t YW5kcyA9IHNjcGlfbGVnYWN5X2NvbW1hbmRzOworICAgICAgICAgICAgICAgc2NwaV9kcnZpbmZv LT5jb21tYW5kcyA9IHNjcGlfbGVnYWN5X2NvbW1hbmRzOwoKICAgICAgICAgICAgICAgIC8qIEZp bGwgcHJpb3JpdHkgYml0bWFwICovCiAgICAgICAgICAgICAgICBmb3IgKGlkeCA9IDA7IGlkeCA8 IEFSUkFZX1NJWkUobGVnYWN5X2hwcmlvcml0eV9jbWRzKTsgaWR4KyspCiAgICAgICAgICAgICAg ICAgICAgICAgIHNldF9iaXQobGVnYWN5X2hwcmlvcml0eV9jbWRzW2lkeF0sCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2NwaV9pbmZvLT5jbWRfcHJpb3JpdHkpOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNjcGlfZHJ2aW5mby0+Y21kX3ByaW9yaXR5KTsKICAgICAg ICB9CgotICAgICAgIHJldCA9IHNjcGlfaW5pdF92ZXJzaW9ucyhzY3BpX2luZm8pOworICAgICAg IHJldCA9IHNjcGlfaW5pdF92ZXJzaW9ucyhzY3BpX2RydmluZm8pOwogICAgICAgIGlmIChyZXQp IHsKICAgICAgICAgICAgICAgIGRldl9lcnIoZGV2LCAiaW5jb3JyZWN0IG9yIG5vIFNDUCBmaXJt d2FyZSBmb3VuZFxuIik7CiAgICAgICAgICAgICAgICByZXR1cm4gcmV0OwogICAgICAgIH0KCi0g ICAgICAgaWYgKHNjcGlfaW5mby0+aXNfbGVnYWN5ICYmICFzY3BpX2luZm8tPnByb3RvY29sX3Zl cnNpb24gJiYKLSAgICAgICAgICAgIXNjcGlfaW5mby0+ZmlybXdhcmVfdmVyc2lvbikKKyAgICAg ICBpZiAoc2NwaV9kcnZpbmZvLT5pc19sZWdhY3kgJiYgIXNjcGlfZHJ2aW5mby0+cHJvdG9jb2xf dmVyc2lvbiAmJgorICAgICAgICAgICAhc2NwaV9kcnZpbmZvLT5maXJtd2FyZV92ZXJzaW9uKQog ICAgICAgICAgICAgICAgZGV2X2luZm8oZGV2LCAiU0NQIFByb3RvY29sIGxlZ2FjeSBwcmUtMS4w IGZpcm13YXJlXG4iKTsKICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICBkZXZfaW5mbyhkZXYs ICJTQ1AgUHJvdG9jb2wgJWx1LiVsdSBGaXJtd2FyZSAlbHUuJWx1LiVsdSB2ZXJzaW9uXG4iLAog ICAgICAgICAgICAgICAgICAgICAgICAgRklFTERfR0VUKFBST1RPX1JFVl9NQUpPUl9NQVNLLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcGlfaW5mby0+cHJvdG9jb2xfdmVy c2lvbiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NwaV9kcnZpbmZvLT5w cm90b2NvbF92ZXJzaW9uKSwKICAgICAgICAgICAgICAgICAgICAgICAgIEZJRUxEX0dFVChQUk9U T19SRVZfTUlOT1JfTUFTSywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzY3Bp X2luZm8tPnByb3RvY29sX3ZlcnNpb24pLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNjcGlfZHJ2aW5mby0+cHJvdG9jb2xfdmVyc2lvbiksCiAgICAgICAgICAgICAgICAgICAg ICAgICBGSUVMRF9HRVQoRldfUkVWX01BSk9SX01BU0ssCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc2NwaV9pbmZvLT5maXJtd2FyZV92ZXJzaW9uKSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzY3BpX2RydmluZm8tPmZpcm13YXJlX3ZlcnNpb24pLAogICAg ICAgICAgICAgICAgICAgICAgICAgRklFTERfR0VUKEZXX1JFVl9NSU5PUl9NQVNLLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcGlfaW5mby0+ZmlybXdhcmVfdmVyc2lvbiks CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2NwaV9kcnZpbmZvLT5maXJtd2Fy ZV92ZXJzaW9uKSwKICAgICAgICAgICAgICAgICAgICAgICAgIEZJRUxEX0dFVChGV19SRVZfUEFU Q0hfTUFTSywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzY3BpX2luZm8tPmZp cm13YXJlX3ZlcnNpb24pKTsKLSAgICAgICBzY3BpX2luZm8tPnNjcGlfb3BzID0gJnNjcGlfb3Bz OworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcGlfZHJ2aW5mby0+ZmlybXdh cmVfdmVyc2lvbikpOworICAgICAgIHNjcGlfZHJ2aW5mby0+c2NwaV9vcHMgPSAmc2NwaV9vcHM7 CisgICAgICAgc2NwaV9pbmZvID0gc2NwaV9kcnZpbmZvOwoKICAgICAgICByZXR1cm4gZGV2bV9v Zl9wbGF0Zm9ybV9wb3B1bGF0ZShkZXYpOwogfQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK