Re: [PATCH 1/8] arm: align find_bit declarations with generic kernel

Andy Shevchenko
2022-07-02T11:57:43Z

On Fri, Jul 01, 2022 at 05:54:23AM -0700, Yury Norov wrote:
> ARM has their own implementation for find_bit functions, and function
> declarations are different with those in generic headers. Fix it.

...

> -extern int _find_first_zero_bit_le(const unsigned long *p, unsigned size);
> -extern int _find_next_zero_bit_le(const unsigned long *p, int size, int offset);
> -extern int _find_first_bit_le(const unsigned long *p, unsigned size);
> -extern int _find_next_bit_le(const unsigned long *p, int size, int offset);
> +unsigned long _find_first_zero_bit_le(const unsigned long *p, unsigned long size);
> +unsigned long _find_next_zero_bit_le(const unsigned long *p,
> + unsigned long size, unsigned long offset);
> +unsigned long _find_first_bit_le(const unsigned long *p, unsigned long size);

> +unsigned long _find_next_bit_le(const unsigned long *p,
> + unsigned long size, unsigned long offset);

Indentation seems broken.

Also for all: is double space required?

...

> +unsigned long _find_next_bit_be(const unsigned long *p,
> + unsigned long size, unsigned long offset);

Indentation of the second line is broken (u in 'unsigned' should be in the same
column as 'const').

--
With Best Regards,
Andy Shevchenko