From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A042C43334 for ; Fri, 1 Jul 2022 14:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O5Ln17GRLFHzMHbj1k9IehfOcbPIE/gDz1fccj2j1Ls=; b=gMKmgNwg9JGBGD zC3dD4s2kTNsxc1Ry0dHqTOmHF3Z85wyiTGB86AIlSAtazhwHchy6TKqJwhKKXHZ5QcfbsxZS5CiP DSXUa4d6K3VV2lPL4ILrYWdoTw8gY1MCUkiCMNj7jBxTpphbeDzgbQCAiH+Zdofq+IVmODVncuUcs ptg06qi8nzsd5bbJgBrdibneeQbtZ2ISl3yvZmNP5alAc/pvGi0gNH9PL6Hp2a83EgrVoF6jMAR3S oAlu1lcWo4Hpr6IWJembDxq2fAdEdG2rNE6hhJzWrw9JmFRMYfK8WiWcoXpC6DY2EBAA3Ap8zmcIt G4bSzibvl5vQE2s5vJYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7HEy-005DxH-GM; Fri, 01 Jul 2022 14:03:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7HEn-005Dtd-Gd for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 14:03:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 938B6113E; Fri, 1 Jul 2022 07:03:11 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BC693F792; Fri, 1 Jul 2022 07:03:09 -0700 (PDT) Date: Fri, 1 Jul 2022 15:03:07 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com, adrian.slatineanu@arm.com, souvik.chakravarty@arm.com, wleavitt@marvell.com, wbartczak@marvell.com Subject: Re: [PATCH v3 5/9] firmware: arm_scmi: Make use of FastChannels configurable Message-ID: <20220701140307.upgfn4qpxhl63syg@bogus> References: <20220627123038.1427067-1-cristian.marussi@arm.com> <20220627123038.1427067-6-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220627123038.1427067-6-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_070313_634701_03D36B79 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 27, 2022 at 01:30:34PM +0100, Cristian Marussi wrote: > Add a Kernel configuration entry used to optionally disable, globally, the > usage of SCMI FastChannels even on platforms where they are available. > > Make such option default-no to preserve the original SCMI system behaviour > of using any available FC. > > Signed-off-by: Cristian Marussi > --- > v2 --> v3 > - fixed wording in Kconfig > - reverted Kconfig logic _USE_ -> _AVOID_ > --- > drivers/firmware/arm_scmi/Kconfig | 13 +++++++++++++ > drivers/firmware/arm_scmi/driver.c | 6 ++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > index 1e7b7fec97d9..3fb34db01014 100644 > --- a/drivers/firmware/arm_scmi/Kconfig > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -42,6 +42,19 @@ config ARM_SCMI_HAVE_MSG > This declares whether a message passing based transport for SCMI is > available. > > +config ARM_SCMI_AVOID_FASTCHANNELS > + bool "Avoid using SCMI FastChannels even when available" Without default, won't this prompt user now ? I would have explicit default n if we are adding this. But why do we need this is my question ? This would be a quirk IMO on systems where FC is broken. I don't want people to enable this during testing and ship f/w with FC broken(or not developed yet). We can add this if some platforms really need this as a quirk in the future. Thoughts ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel