From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AF07C43334 for ; Fri, 1 Jul 2022 14:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2gh2GMrg7BqEH7JFRjeqrMXdVLw+/uBt5+WVC1ahBH0=; b=hElNBEnwkTMLC6 hSZZfgxQ7c4Gkm64ncBwik3vMfqRIy9GJoYtea55GG06pIFyQbJnM+ZUkdmgGJflYP29HHZho5VKs k9gb+lEIgEEgEkQgRis3BKgtyb4zTRfiJw5co33ngXZR5AHK2e7S5IRnBrPQtmX1WtOgAlLGoppL9 zTW19FaKyfHcTtNVJPC8qo7cm0ojnWPkbisfPI4cN0EBJecBNPcTm/NG++jl0P05tZ08MvQcDXYnc byI/scXk178MPLxs5StfyC8Y5gRQ2V6NX3OTLBqpCo3mOxiJBJl3WTA4rlmhVX/laKphvFOZFFsaz 5PkxtDWlSAkGyXHzNKSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7HLL-005Fke-1W; Fri, 01 Jul 2022 14:09:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7HLF-005Fiz-Ej for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 14:09:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E60F113E; Fri, 1 Jul 2022 07:09:50 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 808383F792; Fri, 1 Jul 2022 07:09:48 -0700 (PDT) Date: Fri, 1 Jul 2022 15:09:46 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com, adrian.slatineanu@arm.com, souvik.chakravarty@arm.com, wleavitt@marvell.com, wbartczak@marvell.com Subject: Re: [PATCH v3 8/9] firmware: arm_scmi: Add scmi_driver optional setup/teardown callbacks Message-ID: <20220701140946.uar5ohadyjksf2ka@bogus> References: <20220627123038.1427067-1-cristian.marussi@arm.com> <20220627123038.1427067-9-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220627123038.1427067-9-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_070953_587937_D3D19EB0 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 27, 2022 at 01:30:37PM +0100, Cristian Marussi wrote: > Add optional .setup and .teardown methods to the scmi_driver descriptor: > such callbacks, if provided, will be called by the SCIM core at driver > registration time, so that, an SCMI driver, registered as usual with the > module_scmi_driver() helper macro, can provide custom callbacks to be > run once for all at module load/unload time to perform specific setup > or teardown operations before/after .probe and .remove steps. > What can't the driver call this setup/teardown on its own before/after calling scmi_driver_register/unregister ? Based on the usage in 9/9, I guess it is mainly to use the module_scmi_driver ? If so, I would avoid using that or have another macro to manage this setup/teardown(once there are multiple users for that). IMO, it doesn't make sense to add callbacks to do things that are outside the scope of scmi drivers. No ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel