From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13935C43334 for ; Fri, 1 Jul 2022 15:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E8TdJJOWfGzwYY8BPWv6Z3RgiflhPCA3KTDqeWYfz3U=; b=y9NqoKIXlNOZUa ntUIhBOsEIV/jsUVRaiYXi9uG52/HBen7ik2WYBkaN0SeF+Sjge1yxkJCko5+yZ2k9t2rQ1U4X6u5 TrCN3b1ZO97aZuj8DUgDaHw/o7IoDB4TbwaEMppAm/8X6NC0jO3pOOifzv1jjAdup8iuOWyOhRUoz fBpEuAerT5IgAeVf1grgOBlEaOS9qpTOh+x1DQdWFuTz7EwNra+wjzZ2FDPvt/S6EClL0lsd9QPnO CsdclyF1uXPu9r1HV9EVnhqAY3nKOxNVKjqhANFLEfDDH3PhJy479MwdXegHspHS6kEGW8sYQcBgk aeOKqt0/I3d8GLGDi9mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7IPl-005cP8-78; Fri, 01 Jul 2022 15:18:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7IPi-005cNV-Br for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 15:18:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCA9F113E; Fri, 1 Jul 2022 08:18:33 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC4CA3F66F; Fri, 1 Jul 2022 08:18:31 -0700 (PDT) Date: Fri, 1 Jul 2022 16:18:29 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com, adrian.slatineanu@arm.com, souvik.chakravarty@arm.com, wleavitt@marvell.com, wbartczak@marvell.com, Sudeep Holla Subject: Re: [PATCH v3 8/9] firmware: arm_scmi: Add scmi_driver optional setup/teardown callbacks Message-ID: <20220701151829.j2blytsgma5so6ox@bogus> References: <20220627123038.1427067-1-cristian.marussi@arm.com> <20220627123038.1427067-9-cristian.marussi@arm.com> <20220701140946.uar5ohadyjksf2ka@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_081834_508821_E7C78B5F X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 04:09:05PM +0100, Cristian Marussi wrote: > On Fri, Jul 01, 2022 at 03:09:46PM +0100, Sudeep Holla wrote: > > On Mon, Jun 27, 2022 at 01:30:37PM +0100, Cristian Marussi wrote: > > > Add optional .setup and .teardown methods to the scmi_driver descriptor: > > > such callbacks, if provided, will be called by the SCIM core at driver > > > registration time, so that, an SCMI driver, registered as usual with the > > > module_scmi_driver() helper macro, can provide custom callbacks to be > > > run once for all at module load/unload time to perform specific setup > > > or teardown operations before/after .probe and .remove steps. > > > > > > > What can't the driver call this setup/teardown on its own before/after > > calling scmi_driver_register/unregister ? > > > > > Based on the usage in 9/9, I guess it is mainly to use the > > module_scmi_driver ? If so, I would avoid using that or have another > > macro to manage this setup/teardown(once there are multiple users for that). > > IMO, it doesn't make sense to add callbacks to do things that are outside > > the scope of scmi drivers. No ? > > > > This is exactly what I was doing in fact :D at first ... defining a normal > init/exit from where I called what I needed at first and then ivoke the > scmi_driver_register()...so bypassing/not using the module_scmi-driver macro > indeed...then I realized I needed something similar also for the SCMI Test > driver, so I tried to unify; in both cases indeed the required ops to be > done before the scmi_driver_register are NOT scmi related things. > > So I can drop this if you prefer and use bare module_init/exit that > calls scmi_driver_register() after having setup what needed for the > specific driver initialization (before probe)...I was not really > convinced it was worth this level of unification. > We can add macro for that too if there is another user for this. i.e. if and when we merge the test code using something similar, we can wrap them in a macro module_scmi_driver_setup_teardown(driver, setup, teardown) and simplify things for the users. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel