* [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity
@ 2022-07-04 11:36 Marek Behún
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
2022-07-18 10:42 ` [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Gregory CLEMENT
0 siblings, 2 replies; 4+ messages in thread
From: Marek Behún @ 2022-07-04 11:36 UTC (permalink / raw)
To: Gregory Clement, linux-arm-kernel
Cc: pali, Josef Schlehofer, Marek Behún
The marvell PHY driver changes the LED[0] pin function to "On - 1000
Mbps Link, Off - Else".
Turris Omnia expects that the function is "On - Link, Blink - Activity,
Off - No link".
Use the `marvell,reg-init` DT property to change the function.
In the future, once netdev trigger will support HW offloading, we will
be able to have this configured via the combination of PHY driver and
leds-turris-omnia driver.
Signed-off-by: Marek Behún <kabel@kernel.org>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f4878df39753..1583c4b14ae8 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -397,7 +397,8 @@ &mdio {
phy1: ethernet-phy@1 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <1>;
- marvell,reg-init = <3 18 0 0x4985>;
+ marvell,reg-init = <3 18 0 0x4985>,
+ <3 16 0xfff0 0x0001>;
/* irq is connected to &pcawan pin 7 */
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node
2022-07-04 11:36 [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Marek Behún
@ 2022-07-04 11:36 ` Marek Behún
2022-07-18 10:43 ` Gregory CLEMENT
2022-07-18 10:42 ` [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Gregory CLEMENT
1 sibling, 1 reply; 4+ messages in thread
From: Marek Behún @ 2022-07-04 11:36 UTC (permalink / raw)
To: Gregory Clement, linux-arm-kernel
Cc: pali, Josef Schlehofer, Marek Behún
The LED controller node is disabled because the leds-turris-omnia driver
does not support setting the LED blinking to be controlled by the MCU.
The patches for that have now been sent [1], so let's enable the node.
[1] https://lore.kernel.org/linux-leds/20220704105955.15474-1-kabel@kernel.org/T/
Signed-off-by: Marek Behún <kabel@kernel.org>
---
arch/arm/boot/dts/armada-385-turris-omnia.dts | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index 1583c4b14ae8..d1e0db6e5730 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -191,15 +191,13 @@ led-controller@2b {
reg = <0x2b>;
#address-cells = <1>;
#size-cells = <0>;
+ status = "okay";
/*
* LEDs are controlled by MCU (STM32F0) at
* address 0x2b.
*
- * The driver does not support HW control mode
- * for the LEDs yet. Disable the LEDs for now.
- *
- * Also LED functions are not stable yet:
+ * LED functions are not stable yet:
* - there are 3 LEDs connected via MCU to PCIe
* ports. One of these ports supports mSATA.
* There is no mSATA nor PCIe function.
@@ -210,7 +208,6 @@ led-controller@2b {
* B. Again there is no such function defined.
* For now we use LED_FUNCTION_INDICATOR
*/
- status = "disabled";
multi-led@0 {
reg = <0x0>;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
@ 2022-07-18 10:43 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2022-07-18 10:43 UTC (permalink / raw)
To: Marek Behún, linux-arm-kernel
Cc: pali, Josef Schlehofer, Marek Behún
Marek Behún <kabel@kernel.org> writes:
> The LED controller node is disabled because the leds-turris-omnia driver
> does not support setting the LED blinking to be controlled by the MCU.
>
> The patches for that have now been sent [1], so let's enable the node.
>
> [1] https://lore.kernel.org/linux-leds/20220704105955.15474-1-kabel@kernel.org/T/
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index 1583c4b14ae8..d1e0db6e5730 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -191,15 +191,13 @@ led-controller@2b {
> reg = <0x2b>;
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "okay";
>
> /*
> * LEDs are controlled by MCU (STM32F0) at
> * address 0x2b.
> *
> - * The driver does not support HW control mode
> - * for the LEDs yet. Disable the LEDs for now.
> - *
> - * Also LED functions are not stable yet:
> + * LED functions are not stable yet:
> * - there are 3 LEDs connected via MCU to PCIe
> * ports. One of these ports supports mSATA.
> * There is no mSATA nor PCIe function.
> @@ -210,7 +208,6 @@ led-controller@2b {
> * B. Again there is no such function defined.
> * For now we use LED_FUNCTION_INDICATOR
> */
> - status = "disabled";
>
> multi-led@0 {
> reg = <0x0>;
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity
2022-07-04 11:36 [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Marek Behún
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
@ 2022-07-18 10:42 ` Gregory CLEMENT
1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2022-07-18 10:42 UTC (permalink / raw)
To: Marek Behún, linux-arm-kernel
Cc: pali, Josef Schlehofer, Marek Behún
Marek Behún <kabel@kernel.org> writes:
> The marvell PHY driver changes the LED[0] pin function to "On - 1000
> Mbps Link, Off - Else".
>
> Turris Omnia expects that the function is "On - Link, Blink - Activity,
> Off - No link".
>
> Use the `marvell,reg-init` DT property to change the function.
>
> In the future, once netdev trigger will support HW offloading, we will
> be able to have this configured via the combination of PHY driver and
> leds-turris-omnia driver.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4878df39753..1583c4b14ae8 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -397,7 +397,8 @@ &mdio {
> phy1: ethernet-phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> - marvell,reg-init = <3 18 0 0x4985>;
> + marvell,reg-init = <3 18 0 0x4985>,
> + <3 16 0xfff0 0x0001>;
>
> /* irq is connected to &pcawan pin 7 */
> };
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-18 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 11:36 [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Marek Behún
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
2022-07-18 10:43 ` Gregory CLEMENT
2022-07-18 10:42 ` [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).