From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5582AC433EF for ; Tue, 5 Jul 2022 16:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2zrbgqYZpOfykG1v0k9Gqp6oWXus2gFCmwnq3IZCTME=; b=MkX0QpJ06Nw+Rt PwzjFMpmyQP0zLahv1TLYML3bTglIoFAGft7MoBcBH2lyIs+zU81FDLAKE2up2hJd+3OAoV+a2HM+ xweOUC3rOYE4QEUej+E1L7uri/MkZ8hElxOXcohFgUsncsP9zkgTQOWrtH3gRJoFV3cruRzQlFq/3 REGYvelSpX1MFYQqNjNaVN7W0gpW/oA40j88rQ7IoGgxsq+yYfyKyZA2Eixw5N4dJ1FEg9kh9nBBV uHVJIO6yflV174wOqPkl2Hiblw39tb6IC2X36k1bzIc2VzLPvFAP/GqL3029zRz5MOD4Xi/NR7QzG PE1w5Ou5xIV3cc89Ey3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8lkP-001axr-6d; Tue, 05 Jul 2022 16:50:01 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8lkK-001avd-8x; Tue, 05 Jul 2022 16:49:58 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4244D66015BA; Tue, 5 Jul 2022 17:49:53 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657039794; bh=O8jFid3HFahUb6CdvHaa5HDpKka2L1ZdaQ61QOug694=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V8wRfYT+p8U2kki+8gVIOMH8qrhWZdeUXZ3zh8edA5On+1977a/tPGDlt5HSWbkXM WqgL3BVXmCdpvJVnEmU/kyXca09aKSa2JF/cPUybSj89B+hVUxGNK6i7AnKOGkmcig j+N1Si6n6rkUbPnkif7i0P7iR/UNGy/mmLgvhhMTcsxqsCFxe9rkbpUmhhp9BfPRr1 LWW12vjnsCz+a7sA8rH6zmQzHd275mUSku6bEVsbZFhoEvYUm6K7yZQtLyJhyMObQ1 h92pCxPRInF63LdDsUbcgUAV0VJvkgcWKnqsH/vzkHuTOwbT5tCHh7vSZHVIY1oEGX 9eix4tSIEjAFw== Date: Tue, 5 Jul 2022 12:49:49 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sean.wang@mediatek.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp Message-ID: <20220705164949.x7k542iugl6uffpx@notapiano> References: <20220630131543.225554-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630131543.225554-1-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_094956_520637_5D39B325 X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 30, 2022 at 03:15:43PM +0200, AngeloGioacchino Del Regno wrote: > As was already done for MT8192 in commit b52e695324bb ("dt-bindings: > pinctrl: mt8192: Add drive-strength-microamp"), replace the custom > mediatek,drive-strength-adv property with the standardized pinconf > 'drive-strength-microamp' one. > = > Similarly to the mt8192 counterpart, there's no user of property > 'mediatek,drive-strength-adv', hence removing it is safe. > = > Fixes: 69c3d58dc187 ("dt-bindings: pinctrl: mt8195: Add mediatek,drive-st= rength-adv property") > Signed-off-by: AngeloGioacchino Del Regno Ideally we'd prevent using drive-strength-microamp together with drive-stre= ngth, like I intended to do on v2 of the patch [1], just as an extra sanity check= . But that could be added later on top, so Reviewed-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas [1] https://lore.kernel.org/all/20220531221954.160036-2-nfraprado@collabora= .com/ > --- > .../bindings/pinctrl/pinctrl-mt8195.yaml | 27 ++----------------- > 1 file changed, 2 insertions(+), 25 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yam= l b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > index b0fea44403e7..85e96a5e1708 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > @@ -100,31 +100,8 @@ patternProperties: > drive-strength: > enum: [2, 4, 6, 8, 10, 12, 14, 16] > = > - mediatek,drive-strength-adv: > - description: | > - Describe the specific driving setup property. > - For I2C pins, the existing generic driving setup can only = support > - 2/4/6/8/10/12/14/16mA driving. But in specific driving set= up, they > - can support 0.125/0.25/0.5/1mA adjustment. If we enable sp= ecific > - driving setup, the existing generic setup will be disabled. > - The specific driving setup is controlled by E1E0EN. > - When E1=3D0/E0=3D0, the strength is 0.125mA. > - When E1=3D0/E0=3D1, the strength is 0.25mA. > - When E1=3D1/E0=3D0, the strength is 0.5mA. > - When E1=3D1/E0=3D1, the strength is 1mA. > - EN is used to enable or disable the specific driving setup. > - Valid arguments are described as below: > - 0: (E1, E0, EN) =3D (0, 0, 0) > - 1: (E1, E0, EN) =3D (0, 0, 1) > - 2: (E1, E0, EN) =3D (0, 1, 0) > - 3: (E1, E0, EN) =3D (0, 1, 1) > - 4: (E1, E0, EN) =3D (1, 0, 0) > - 5: (E1, E0, EN) =3D (1, 0, 1) > - 6: (E1, E0, EN) =3D (1, 1, 0) > - 7: (E1, E0, EN) =3D (1, 1, 1) > - So the valid arguments are from 0 to 7. > - $ref: /schemas/types.yaml#/definitions/uint32 > - enum: [0, 1, 2, 3, 4, 5, 6, 7] > + drive-strength-microamp: > + enum: [125, 250, 500, 1000] > = > bias-pull-down: > oneOf: > -- = > 2.35.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel