From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0A55C433EF for ; Tue, 5 Jul 2022 20:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X5aTUQVONqGKwgxfiNO2lPtqD2M5WW2I4d820JV0CRk=; b=fm79GuHJ4qZZsJ glmfHQ5hwerwGcspQCfRlnjoPPpqeDLRMNt9EGQ/zNfS5JSm//NuB1u/c4Aq1COYdxkpUAjAiUEp7 nCE/nJtPztx+Md5IHjllUHyKTI4TLcm9ocYzJZT3a+mKUwGRMFGN1ezJ0E2NHZqnfg9+fa+TX6NIj d7p1rrorqpvcd4LyIziiYFuBjAAixCRyZFBntCr+okCC6ymMwWu56Drnw20jtsKcRbt/9atbjOKK2 3/OFNWgm1gtWhNPzOVhoEecQCkIcJCJ6h3ckMbgccVK+ABlNKE6d48PGwQoEXOf0MGy7tT1UNfOcT AhTeVaVuHHeIKv2LE30g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8pHe-002eAB-T8; Tue, 05 Jul 2022 20:36:34 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8pHb-002e96-Lw; Tue, 05 Jul 2022 20:36:33 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0AC7B660180F; Tue, 5 Jul 2022 21:36:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657053387; bh=OrwB8qOVDqFzOmPNBZc6oHWmrOYIVjhvGlY/DI5Fmbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lwmHEE/rRolwWUxTzRAtTvFqraneOsrTub3hjYLXaYUxiqQYrpdmBj+MUr4E5kfbV elmrfnZhaM09/ZMNfJ3hs+xT3nx9DgjMZPklZIp2l+bJCUJ2iBR2YSiAAcE/FEQcy3 j0/S0tKcRLHASd1Adsa/qfkAZyPRiuEOzW8WOHP8O1g8vlkew1/E5mIIpYPdWgCyKp u7J/UHsDpavuRqlwAg4GOpnBWlVYS5nTT/qen3z3vRnxxtW3BMvvqCbWtPY00On4ka sY7J+WcNHBCEltQdD7sc1FWNRFLsHF9WypC9Of9jPxTA8cNr3RM3iznimFj3IyaNMI g1d0jZSQ5gQBw== Date: Tue, 5 Jul 2022 16:36:21 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 2/4] dt-bindings: usb: mtk-xhci: Make all clocks required Message-ID: <20220705203621.hunczzwfhiwpcrhy@notapiano> References: <20220623193702.817996-1-nfraprado@collabora.com> <20220623193702.817996-3-nfraprado@collabora.com> <93c6b7201533325cf7758637dd194a372f3c00c6.camel@mediatek.com> <20220629185546.z6rn7xp3ejpmaupi@notapiano> <20220701213702.GA1591697-robh@kernel.org> <5f85280ea5fd0d4b445307a13a70c3e3fe552ccf.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5f85280ea5fd0d4b445307a13a70c3e3fe552ccf.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_133632_108804_E2324030 X-CRM114-Status: GOOD ( 39.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 02, 2022 at 04:24:12PM +0800, Chunfeng Yun wrote: > On Fri, 2022-07-01 at 15:37 -0600, Rob Herring wrote: > > On Wed, Jun 29, 2022 at 02:55:46PM -0400, N=EDcolas F. R. A. Prado > > wrote: > > > On Tue, Jun 28, 2022 at 08:57:45AM +0800, Chunfeng Yun wrote: > > > > Hi N=EDcolas, > > > > = > > > > On Thu, 2022-06-23 at 15:37 -0400, N=EDcolas F. R. A. Prado wrote: > > > > > All of the clocks listed in the binding are always wired to the > > > > > XHCI > > > > > controller hardware blocks on all SoCs. The reason some clocks > > > > > were > > > > > made > > > > > optional in the binding was to account for the fact that > > > > > depending on > > > > > the SoC, some of the clocks might be fixed (ie not controlled > > > > > by > > > > > software). > > > > > = > > > > > Given that the devicetree should represent the hardware, make > > > > > all > > > > > clocks > > > > > required in the binding. Subsequent patches will make the DTS > > > > > changes > > > > > to > > > > > specify fixed-clocks for the clocks that aren't controllable. > > > > > = > > > > > Signed-off-by: N=EDcolas F. R. A. Prado > > > > > = > > > > > --- > > > > > = > > > > > Changes in v2: > > > > > - Undid clock list changes that allowed middle clocks to be > > > > > missing > > > > > from > > > > > v1 and made all clocks required instead > > > > > - Rewrote commit message and title > > > > > = > > > > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | > > > > > 4 + > > > > > --- > > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > = > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/usb/mediatek,mtk- > > > > > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk- > > > > > xhci.yaml > > > > > index 63cbc2b62d18..1444d18ef9bc 100644 > > > > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk- > > > > > xhci.yaml > > > > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk- > > > > > xhci.yaml > > > > > @@ -67,7 +67,6 @@ properties: > > > > > maxItems: 1 > > > > > = > > > > > clocks: > > > > > - minItems: 1 > > > > > items: > > > > > - description: Controller clock used by normal mode > > > > > - description: Reference clock used by low power mode > > > > > etc > > > > > @@ -76,9 +75,8 @@ properties: > > > > > - description: controller clock > > > > > = > > > > > clock-names: > > > > > - minItems: 1 > > > > > items: > > > > > - - const: sys_ck # required, the following ones are > > > > > optional > > > > > + - const: sys_ck > > > > > - const: ref_ck > > > > > - const: mcu_ck > > > > > - const: dma_ck > > > > = > > > > This patch causes more check warning, I prefer to leave dt- > > > > bindings > > > > unchanged, but just fix mt8195's dts warning instead, thanks a > > > > lot > > > = > > > Hi Chunfeng, > > > = > > > the warnings reported by Rob's bot only happen if patches 3 and 4 > > > aren't applied > > > to adapt the devicetrees. They are ABI breaking changes, but I > > > understood this > > > as the desired solution from the discussion we had with Krzysztof > > > on v1 [1]. > > = > > The warnings have nothing to do with patches 3 and 4 as those are > > for = > > dts files. It's examples in bindings that are the problem. Sorry, you're right, I misread the errors. > Yes, I mean almost all existing dts supporting mtk-xhci will also cause > similar warnings, as changes in patches 3, 4; > = > It seems less flexible to make all clock required, not only changes all > existing ones but also need more changes if additional clock is added. Yes, that's a valid concern. I must have misunderstood the discussion in v1 then. So, I'm going to send a revert for this change and send a new patch adding = fixed clocks on the dts for just mt8192 and mt8195 to fix the dtbs_check warnings. Does that sound good? Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel