From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAEB2C433EF for ; Wed, 6 Jul 2022 12:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l+7/PP0/iWLKp+YIm1LAZfL5PVsfCA7BiI79gkookQk=; b=QQZ/qKBojEzuig rY1AOG1M5MbM151niJJTFUAZR0HpznVVrDzpVZFKKF9gsWgh9QzS9zfqGRrVANlmpPLzCxoIlrmmZ SStTkPNKukx0pKo9B3nkTzZVnCjDHfy1Kma6SmEUDe+/Cm6oiopK8z2g2FPpUSKjL+ReL9S4VnVUO Fb4ktPkccnV5rAzjdyK0bJqJcLlehXyhYtrsMzaVQKXqQ5gLeC8I2+iUs10xHlrRJ9C3NmRu/XHLP UH9C4laGtPT2W6p9J+O+kHv1u+8pDk/lP6FbrWwf7VZRd5O0Tz0s2UQZ0r+YwMuojfqC0CT5SGNWo bUfM3y0nobfmCbZY9q5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o94Lm-009zF0-2J; Wed, 06 Jul 2022 12:41:50 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o94Lj-009zAo-8N; Wed, 06 Jul 2022 12:41:48 +0000 Received: by mail-pf1-x436.google.com with SMTP id e16so1486503pfm.11; Wed, 06 Jul 2022 05:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XSmJd1bpU0glTVAxiyaH+IAuqRCtmm6vBt6ZWeEWSjI=; b=QRp7RubZClq6VYpat3y7q7HgKvGpPDnUrXiBo2fA8t1m9ENWJlkgWy6suTgQ073Qm5 vZOSKTR+bf5nqBaQW3a0NAT00pXGvyykNnKassuTkserwnZbMs3ObFyQS/DkwSWpAZJH +0zw+b2uu38SFluU6AF274EECmeD/mw0Z3i85z7wzsoGBQKFMfT//07c2ZYATEoJ1XLA 4pBHjaHT8HCtVri77+gDja7aQzhkxxnS3i5bOqVRQASpBDLtbEEJxbod77G6jzH5fn4K MhhPi3DG33KpOM1Mi8iG2d4mSW62cokXWNi0WQl3bsn5CWFrRmMXyMu2QQr4JJa26uEB 8cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=XSmJd1bpU0glTVAxiyaH+IAuqRCtmm6vBt6ZWeEWSjI=; b=anmOn5BWf4WEHy/sUi6ybczvBba1YvVowEpFKwUfXUXWPykqWHaXRdY2JqXw/GoO1D C0cCbIGTf7hhTOrHdLZAI/b4M9nz72sd0HQVPYbHsCK1LMFN/gG0G3XoOASxQLJyPHyF LCKiRGuVqyLrOhX2hn8W6wFJjwr7R54XLuNwr5jrMXKQB9cgaOMN/J3OLLhqftj/rCTL iuPYj/hyv33daY3d1drRFIQb9VgoyjLC0wT750y99MdYXbnehRQCHOnomDGz1v6mqAlI 8SQOJbHx0iLyx7ju+SS8LMiVb3Xwd0lZclG8/66RvhnBmcOmNAcBsiC/zsBA2s8VL2j5 w3gg== X-Gm-Message-State: AJIora8xm376rSqv9zpnbpjDsOR6Hw3SY1OkdAHAGXn/YnnJIrPdLhda OTdSwFqFxKJPzx2NEKBNEQM= X-Google-Smtp-Source: AGRyM1uq149T+UXOfXySCa+9sRr+0vARPC9zynC8iC6s8O2zbU7cQlw3n/jsJ2VkbAOuz/BbF5u+2A== X-Received: by 2002:a63:d94a:0:b0:412:6e04:dc26 with SMTP id e10-20020a63d94a000000b004126e04dc26mr8800555pgj.539.1657111301178; Wed, 06 Jul 2022 05:41:41 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y18-20020a17090322d200b0016bdc98730bsm7829564plg.151.2022.07.06.05.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 05:41:40 -0700 (PDT) Date: Wed, 6 Jul 2022 05:41:39 -0700 From: Guenter Roeck To: Jerome Brunet Cc: Neil Armstrong , Philippe Boos , Wim Van Sebroeck , Kevin Hilman , Martin Blumenstingl , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] watchdog: meson: keep running if already active Message-ID: <20220706124139.GB492220@roeck-us.net> References: <20220705142444.17063-1-pboos@baylibre.com> <1jmtdnwd7y.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1jmtdnwd7y.fsf@starbuckisacylon.baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_054147_339280_42A5BB27 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 05, 2022 at 09:29:35PM +0200, Jerome Brunet wrote: > > On Tue 05 Jul 2022 at 16:39, Neil Armstrong wrote: > > > Hi, > > > > On 05/07/2022 16:24, Philippe Boos wrote: > >> If the watchdog is already running (e.g.: started by bootloader) then > >> the kernel driver should keep the watchdog active but the amlogic driver > >> turns it off. > >> Let the driver fix the clock rate then restart the watchdog if it was > >> previously active. > >> Reviewed-by: Jerome Brunet > > > > Please drop this review tag since it was done off-list > > Indeed a review was done off-list. > > Reviewed-by says a review has been done. I was not aware this applied to > public reviews only. I probably missed that, would you mind pointing me > to that rule please ? > Public or not doesn't really matter. However, you can only apply a Reviewed-by: tag (or any tag, really) if you explicitly received one. The exchange seems to suggest that you did not receive that tag. Please never add any tags on your own. On the other side, if the reviewer did send a Reviewed-by: tag off list, I would kindly ask the reviewer to not do that in the future to avoid misunderstandings. If you don't want your Reviewed-by: tag attached to a patch, don't send one. Not everyone will even realize that you sent your tag off-list, and no one can be expected to know that you didn't really mean it when you sent your tag. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel