From: Nishanth Menon <nm@ti.com>
To: Jai Luthra <j-luthra@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-am625-sk: Add audio output support
Date: Wed, 6 Jul 2022 18:31:01 -0500 [thread overview]
Message-ID: <20220706233101.zrrzeaa62fgvd5g4@huddling> (raw)
In-Reply-To: <20220620102750.32718-4-j-luthra@ti.com>
On 15:57-20220620, Jai Luthra wrote:
> Add nodes for audio codec and sound card, enable the audio serializer
> (McASP1) under use and update pinmux. Disable all other McASP nodes.
>
> Audio input is currently not working properly, so the RX port on McASP1
> is disabled for now, until the issue is debugged.
>
> The serializer is shared between HDMI and codec. By default codec is
> used for output, but it can be toggled to HDMI using a FET switch
> connected to the MCASP1_FET_SEL (J24) header on the board.
>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
[...]
> + main_mcasp1_pins_default: main-mcasp1-pins-default {
> + pinctrl-single,pins = <
> + AM62X_IOPAD(0x0090, PIN_INPUT, 2) /* (M24) GPMC0_BE0N_CLE.MCASP1_ACLKX */
> + AM62X_IOPAD(0x0098, PIN_INPUT, 2) /* (U23) GPMC0_WAIT0.MCASP1_AFSX */
> + AM62X_IOPAD(0x008c, PIN_OUTPUT, 2) /* (L25) GPMC0_WEN.MCASP1_AXR0 */
> + AM62X_IOPAD(0x0084, PIN_INPUT, 2) /* (L23) GPMC0_ADVN_ALE.MCASP1_AXR2 */
> + >;
> + };
> };
>
> &wkup_uart0 {
> @@ -352,6 +401,18 @@
> pinctrl-names = "default";
> pinctrl-0 = <&main_gpio1_ioexp_intr_pins_default>;
> };
> +
> + tlv320aic3106: audio-codec@1b {
> + #sound-dai-cells = <0>;
> + compatible = "ti,tlv320aic3106";
I cant pick up a patch with compatibles that are'nt converted to yaml.
Please convert to yaml in master and then post.
> + reg = <0x1b>;
> +
> + /* Regulators */
> + AVDD-supply = <&vcc_3v3_sys>;
> + IOVDD-supply = <&vcc_3v3_sys>;
> + DRVDD-supply = <&vcc_3v3_sys>;
> + DVDD-supply = <&vcc_1v8>;
> + };
> };
>
> &main_i2c2 {
> @@ -412,6 +473,34 @@
> };
> };
>
> +&mcasp0 {
> + status = "disabled";
> +};
> +
> +&mcasp1 {
> + status = "okay";
we don't need to set okay on a node that is ok by default.
> + #sound-dai-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mcasp1_pins_default>;
> +
> + op-mode = <0>; /* MCASP_IIS_MODE */
> + tdm-slots = <2>;
> +
> + serial-dir = < /* 0: INACTIVE, 1: TX, 2: RX */
> + 1 0 0 0
> + 0 0 0 0
> + 0 0 0 0
> + 0 0 0 0
> + >;
> + tx-num-evt = <32>;
> + rx-num-evt = <32>;
> +};
> +
> +&mcasp2 {
> + status = "disabled";
> +};
> +
> &mailbox0_cluster0 {
> mbox_m4_0: mbox-m4-0 {
> ti,mbox-rx = <0 0 0>;
>
> --
> 2.17.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-06 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:27 [PATCH v4 0/2] arm64: ti: k3-am62: Enable audio output Jai Luthra
2022-06-20 10:27 ` [PATCH v4 1/2] arm64: dts: ti: k3-am62-main: Add McASP nodes Jai Luthra
2022-06-20 10:27 ` [PATCH v4 2/2] arm64: dts: ti: am625-sk: Add audio output support Jai Luthra
2022-06-20 10:35 ` Jai Luthra
2022-06-20 10:27 ` [PATCH v4 2/2] arm64: dts: ti: k3-am625-sk: " Jai Luthra
2022-07-06 23:31 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706233101.zrrzeaa62fgvd5g4@huddling \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox