From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40D86C43334 for ; Mon, 11 Jul 2022 14:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2mWmzu3UhlHNyl9GmdFv6bAFDjF0b0d7YgmY/VlPjhE=; b=P2KNuoa+GhinT6 6PqX5LtVl1uKtU+9QiOy/iQYBACtxgSTfRtvtU5vbMejrI6L+rq6B1pICzPd/FZcw5TNBAWyzmyN8 V33VUI5vZP1nd+trF76GdrmrmuUzxQyFt9mVpU3DSWvXAlIITOvjBGOGeE6LKricWWY3Ip9Nowr+s g/82UQZeS/1bskUdMXmSB2l9IkaCeGFyWWro6/UdwTftIQoaKr+bLIzUY4MMTTaLIf7FduUwy0sYY ySB0hF89dgLOFT+34pi54QEVvuKq29owWMvjo2FVWq5M/DuofgefaPM8MrSnoLK7v0Xkm4J7wqlAM CIFpq/XNhME8OqsROc1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAuX3-002Nzk-Cf; Mon, 11 Jul 2022 14:37:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAuX0-002Nxi-G8; Mon, 11 Jul 2022 14:37:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4F4B1596; Mon, 11 Jul 2022 07:36:59 -0700 (PDT) Received: from bogus (unknown [10.57.39.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1FCB3F70D; Mon, 11 Jul 2022 07:36:53 -0700 (PDT) Date: Mon, 11 Jul 2022 15:35:42 +0100 From: Sudeep Holla To: Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Sudeep Holla , Greg Kroah-Hartman , "Rafael J . Wysocki" , Daire McNamara , Conor Dooley , Niklas Cassel , Damien Le Moal , Geert Uytterhoeven , Zong Li , Emil Renner Berthing , Jonas Hahnfeld , Guo Ren , Anup Patel , Atish Patra , Heiko Stuebner , Philipp Tomsich , Rob Herring , Marc Zyngier , Viresh Kumar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice Goglin Subject: Re: [PATCH v3 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: <20220711143542.nlq6a5nuh4nouomo@bogus> References: <20220709152354.2856586-1-mail@conchuod.ie> <20220709152354.2856586-2-mail@conchuod.ie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220709152354.2856586-2-mail@conchuod.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_073702_598102_A21302A9 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 09, 2022 at 04:23:54PM +0100, Conor Dooley wrote: > From: Conor Dooley > > arm64's method of defining a default cpu topology requires only minimal > changes to apply to RISC-V also. The current arm64 implementation exits > early in a uniprocessor configuration by reading MPIDR & claiming that > uniprocessor can rely on the default values. > > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > topology: Stop using MPIDR for topology information")', because the > current code just assigns default values for multiprocessor systems. > > With the MPIDR references removed, store_cpu_topolgy() can be moved to > the common arch_topology code. > Looks good. FWIW, Reviewed-by: Sudeep Holla > CC: stable@vger.kernel.org However, while I understand the reason why this is needed in stable trees for RISC-V, I am not sure if we want this for stable tree at-least on arm64. I leave that part to Greg and Will. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel