From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D0AC433EF for ; Mon, 11 Jul 2022 22:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p+XvJ8aDM9X6qeQL7ROWLt6l5MOvlPSKs9ratZOXtxk=; b=tj56+4ok+JuH3S B8PtmRhcVr35BG7+mpPO21tFpli4JBw2JHq0RSOG1EEA4kjx+P7vd3LtnYUmkA0k1MRMn/E/0nJX9 xx/I6cjaay9sW0e5nValYTDpCRdPdnTN5vAPAQZi0fV38yUTaP1QNF2eDsor9bTy9JsgYu8/aBD66 XCdv8QBdAASUNqa7Oytz0XXVNrsjAyvEOmJPDot8mhZ1/n/+YS9rWXtH8GOn6R6p9G4O2WRCA+XtA xaWeg3BYwCXuoiP3jrz3I/TvMBnrZduBLHpEdTtwj4ONeKSVhkpghC9/qFHZK5Uv5Dk0mbA9uyDar fA+1h1D3BnMZv5ZcPD0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB1wM-005HpC-Eh; Mon, 11 Jul 2022 22:31:42 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB1wJ-005Ho7-8p; Mon, 11 Jul 2022 22:31:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81E08B815F3; Mon, 11 Jul 2022 22:31:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7317C34115; Mon, 11 Jul 2022 22:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657578695; bh=ZL3TQAfBSmk88tbrJpOmYI/DhBKsXihG4ur1c9u/6CE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QtJ45TwDZh+xTseD9Q7Supflim9NOmwQnMYu1GnBsZen5AI4G88aNxeC08vWmvjSp fNsYmzSznBL72MKmU2EAVwkuPE+QISPpc/NP7g0ZEVAqa7TocWxGfDYz4a/U/vO8mi nvDV87fgN2s6Rt0pVAPruKZJBBvPjCVeASosS7loZwKJFb/2wJBhDNRZk8Y6Wmd8ze PNh9klXnqkV4gjjI3SYVne02mJ+IrIeshlIQyQVwXsNEZ1Ka0gReOMBRUmMMKcV71M VGrUcwGf2n2hst0JLqHPH7SJX+xegIde9+jvPPelECh/swLvBxIPMhbGnigPVIT+6q FKAIKevSOy06g== Date: Mon, 11 Jul 2022 15:31:25 -0700 From: Jakub Kicinski To: Biao Huang Cc: David Miller , Matthias Brugger , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Paolo Abeni , Maxime Coquelin , AngeloGioacchino Del Regno , , , , , , Subject: Re: [PATCH net v3] stmmac: dwmac-mediatek: fix clock issue Message-ID: <20220711153125.74442bce@kernel.org> In-Reply-To: <20220708083937.27334-2-biao.huang@mediatek.com> References: <20220708083937.27334-1-biao.huang@mediatek.com> <20220708083937.27334-2-biao.huang@mediatek.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_153139_495991_281A9E5F X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 8 Jul 2022 16:39:37 +0800 Biao Huang wrote: > Since clocks are handled in mediatek_dwmac_clks_config(), > remove the clocks configuration in init()/exit(), and > invoke mediatek_dwmac_clks_config instead. > > This issue is found in suspend/resume test. Please improve the commit message so that it answers the questions Matthias had and repost. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel