From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98CEBC43334 for ; Wed, 13 Jul 2022 16:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=AkOmgjmb7FrD/geAcOrWHuLip79OTGuPpXjfPIfcVgY=; b=FZ+HPYJHOoK2Qs Cil/deKcOCO4MajcCZ4QdTST7q391+CCl4faIsx/FKubO+j/hur1LtU5Ha2l/nFx01+wEXkk8qWdB y+izOmMNUfREgd8sdJCNiM0F2n8ty6rQpPJu2rQxs68atB/VuqTKmB12ifZTDXRWac+9s0dOLnnPw Dju6CCjPc1jSNYQVoIxogjeMRVwGRKrXYZXHh5W07vM4ClPJgfcdWsoo6cJsLCCQ15yMAuX8KLDJO iG7l216RRk15TiiQyGYkbaDL9OCCTNmRJzK/E+Gnw0EYvcfMx2tJbYa8XPlnUV0cHVPTOwXQltbJ9 qlScWM8TcBJntdAe6hlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBfUx-005maH-9x; Wed, 13 Jul 2022 16:46:03 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBfUu-005mXI-DS for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 16:46:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6D0A4B820E8; Wed, 13 Jul 2022 16:45:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9CDBC341C6; Wed, 13 Jul 2022 16:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657730756; bh=YyGcbZI3NL+Y5QVRHRBFY4N+xrsu0kQktnkufuB1ylA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JtQcrHn+iu4Eljtfil3G+w7ZnCIPnV/De30FpvG+OHvYj36UIb5UT1YpVDdafVwMo Uj5us1IxN+NAxZQkdLOWXkYXyJCNdoroNMnLxH9GCEAqEmodRqoub0jmLGJF39/c/m wq/R4WRukhVKfYaXhp5aa6gXbwyVN17Jw453LpwclumMbDgcdc8pOflJMzCvabaY0N QVUOTicRojC0z4KssmMQHp7MkPqjNE0GGLTZ05ZvNvlv8fmZm4D3m/hPuLxsSNX0zb RQIxkEIYqOAVEVmfxxjfob6rrr+pg+oHO17nC2ebQJM0cJlqCj2c+mOgyMR+hJcmoi ub+5AYgaFGhug== Date: Wed, 13 Jul 2022 11:45:54 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v14 0/17] PCI: imx6: refine codes and add the error propagation Message-ID: <20220713164554.GA833183@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220711222959.GA701423@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_094600_654320_845E4282 X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 05:29:59PM -0500, Bjorn Helgaas wrote: > On Fri, Jul 01, 2022 at 11:25:18AM +0800, Richard Zhu wrote: > > ... > > Bjorn Helgaas (5): > > PCI: imx6: Move imx6_pcie_grp_offset(), imx6_pcie_configure_type() > > earlier > > PCI: imx6: Move PHY management functions together > > PCI: imx6: Move imx6_pcie_enable_ref_clk() earlier > > PCI: imx6: Factor out ref clock disable to match enable > > PCI: imx6: Disable clocks in reverse order of enable > > > > Richard Zhu (12): > > PCI: imx6: Move imx6_pcie_clk_disable() earlier > > PCI: imx6: Collect clock enables in imx6_pcie_clk_enable() > > PCI: imx6: Propagate .host_init() errors to caller > > PCI: imx6: Disable i.MX6QDL clock when disabling ref clocks > > PCI: imx6: Call host init function directly in resume > > PCI: imx6: Turn off regulator when system is in suspend mode > > PCI: imx6: Move regulator enable out of > > imx6_pcie_deassert_core_reset() > > PCI: imx6: Mark the link down as non-fatal error > > PCI: imx6: Reduce resume time by only starting link if it was up > > before suspend > > PCI: imx6: Do not hide phy driver callbacks and refine the error > > handling > > PCI: imx6: Reformat suspend callback to keep symmetric with resume > > PCI: imx6: Move the imx6_pcie_ltssm_disable() earlier > > > > drivers/pci/controller/dwc/pci-imx6.c | 661 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------- > > 1 file changed, 358 insertions(+), 303 deletions(-) > > Applied to pci/ctrl/imx6 for v5.20, thanks a lot for all your work > here! I updated the branch with Lucas' acks and with the minor imx6_pcie_start_link() return value check he suggested. I did not do anything about the missing IMX8MQ case in imx6_pcie_ltssm_disable() or the PHY init or regulator or shutdown issues. If you want changes there, please make them starting with the pci/ctrl/imx6 branch and I can just replace it: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ctrl/imx6&id=7d652ce95e70 Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel