From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38A8FC433EF for ; Thu, 14 Jul 2022 15:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w3QFkpyyQbO8xTBUnCcJt8VsHsVcvpiPfMCnDg/S7KI=; b=js1fD9fx/Ty9U+ BNwNe/U1tAD/+4iQPGT/nQvL550zWDF/zITe03hHCiXollFc9YZlzvtjdqoY7PYp0dckja67xXjZw aAOjSV7EpRa3Oe4AGPg9r6lfkhJC7K7PlA9IN0TGE56Cd7cfH7drz6ebOupNC+C3B6YK0erfwdJol ozJrqwGCj9A+iyZQGbOBxFXQqewfaDihSxS9+f2b68YvsVK4dGZHT8dMU3fvivkpLQdnpK/3Ng9GU q2spKaW3Eaxiqk1UtE0Y920VtPwGy/VrWP9nVoRO9uzRK9+t/kqf0JQ8Z98m4wtgyGew2wB4f9A4u ccmfl/Fw0kLVpTcKsD8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC0dq-00FcPs-Ux; Thu, 14 Jul 2022 15:20:39 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC0dl-00FcLV-8X for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 15:20:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DACD6B8271C; Thu, 14 Jul 2022 15:20:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BF0DC341C8; Thu, 14 Jul 2022 15:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657812030; bh=AwfmzeeBLDFpkpiMy+JT9JpojGra6eCY8Mz6ZVZbALo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uOJVpLdoWJc6/FS5BwMlKRFZxkEkRHnk4eQpNcwCV1hEHXu8ocaiI+NRvsx2g5hDv qgekRp3I76r2SAUAsbriWlVudC+zes5Cx8W6BbQ2DDHGwr8nq1g+eKUjtCwa/ZKj3z bAJIsZ+aFjgUGMF9s6SR02mycyIsztbRCoqv0ZbXmzAjeibqGEaaSnU58FJBj8iNgT dvyt6S0kN9F2NkKxlJZPh2VW0q8+Gk5PUGFf9NBdMXjpsEUzOfxNM7WSk3TODhU6bR GoRGB4Dw9x/6JKQnG7B0RiFgwlY9K8vFPzUK54jyiOieiJ8JGTZ0Lkbsrq6iT9mqdF 7js9ft3nfamSA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oC0dg-007UVL-GK; Thu, 14 Jul 2022 16:20:28 +0100 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: James Morse , Suzuki K Poulose , Alexandru Elisei , Oliver Upton , Reiji Watanabe , Schspa Shi , kernel-team@android.com Subject: [PATCH v2 04/20] KVM: arm64: Rely on index_to_param() for size checks on userspace access Date: Thu, 14 Jul 2022 16:20:08 +0100 Message-Id: <20220714152024.1673368-5-maz@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220714152024.1673368-1-maz@kernel.org> References: <20220714152024.1673368-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, oliver.upton@linux.dev, reijiw@google.com, schspa@gmail.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_082033_541548_95705797 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org index_to_param() already checks that we use 64bit accesses for all registers accessed from userspace. However, we have extra checks in other places, which is pretty confusing. Get rid on these checks. Signed-off-by: Marc Zyngier --- arch/arm64/kvm/sys_regs.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 0fbdb21a3600..5dbe0f4b8167 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -2871,9 +2871,6 @@ int kvm_arm_sys_reg_get_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX) return demux_c15_get(reg->id, uaddr); - if (KVM_REG_SIZE(reg->id) != sizeof(__u64)) - return -ENOENT; - err = get_invariant_sys_reg(reg->id, uaddr); if (err != -ENOENT) return err; @@ -2906,9 +2903,6 @@ int kvm_arm_sys_reg_set_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX) return demux_c15_set(reg->id, uaddr); - if (KVM_REG_SIZE(reg->id) != sizeof(__u64)) - return -ENOENT; - err = set_invariant_sys_reg(reg->id, uaddr); if (err != -ENOENT) return err; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel