From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71AA8C43334 for ; Thu, 14 Jul 2022 20:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=xoZbo7/dsLObJbWjy0pUiyA/6D9ZqQ8D7gE9cDOkNGo=; b=bTHSETMLpG3JFb Gm3oyc6tcV/X2eiOo1IBpDfwZgjsVZwtSI75cPLtjNZ6fthOhe2XItwofLKfiUymykhfb7UnPlt6S 5nOfFcrAuYtclemlF5XMHB/h+1rJssR9NTRTQvQVbdBs7K4Ye2Gkd2YcjS8W/g9lrk5MkDX/3eBOm C9WRuFXg09tKEfvDg49IS1WMrJ2iQKNrcdDSRWggd5hH+X+Qja632uJEiMGUiEfi0P9LTs1N+QeHz 23WZJqULjFYvp54CCL9cNxcVjwEMpotR0sN05lxVjSpGfRM/pe9m+uT8U6tSASPXm8/TV/Htx4D3E S+ogKTmjZEhFAvh+K1vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC54t-001TW4-6E; Thu, 14 Jul 2022 20:04:51 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC54p-001TVf-RX for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 20:04:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11B2A6221E; Thu, 14 Jul 2022 20:04:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF069C34114; Thu, 14 Jul 2022 20:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657829086; bh=dJZgDK6qkBq1IwGZe1zOEzp1bWX9huz0JVAX615cico=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=TFjIUwbs/oPqF3/CccRpHfjuHEbv1cpunaNRfTFlK/a/jf53P7ZY4Q/FQi29P5l2E 2ZTs+syenSEL6qljRTsj95VSFmS1NqMXMneeDvN3dImBJzRe4wvZNyeR8O2EBt2VSU UR/x21x7VMO6duebUmSfvLakZakb8uKNKbZBtoBRPxMQbaG1tA/o0jQy7nEjwr7Pul fOuQbe4KstDRjEuCnoy0w1FgRcOVNyXRfiO0ABHv9aSpJvzPMNkgEMQd5hQve+hf/U R7nuFhAmqPnKEftixFTpCNRM0wFu25rgYSq01rv1WT/oigRtX74RGHGzZApzc9XOmj KlLfMgEf2CYQQ== Date: Thu, 14 Jul 2022 15:04:43 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: kernel test robot , kbuild-all@lists.01.org, Lorenzo Pieralisi , Bjorn Helgaas , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU Message-ID: <20220714200443.GA1036464@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220714185700.6137-1-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_130447_986707_6D97C0E6 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc linux-pci, update Lorenzo's email addr] Hi Pali, Thanks for cc'ing me. I think your previous notes didn't include linux-pci or me, so I missed them. It looks like bc02973a06a6 was merged via the PCI tree for v5.17 [1], so we should probably merge the fix the same way. Russell, let me know if you object. Otherwise, I put it on pci/misc for v5.20. [1] https://lore.kernel.org/r/20220114155608.GA557997@bhelgaas On Thu, Jul 14, 2022 at 08:57:00PM +0200, Pali Roh=E1r wrote: > Custom ARM version of pci_remap_iospace() is implemented only for MMU > kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU. > > See compilation failures: > https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/ > https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/ > https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/ > https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/ > = > Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_r= emap_iospace()") > Reported-by: kernel test robot > Signed-off-by: Pali Roh=E1r > = > --- > = > PING!!!! Is somebody interested in fixing these compile errors? As nobody > answered to my emails where I proposed this fix more than half year ago a= nd > asked for opinion... > = > https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/ > https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ > https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/ > https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/ > https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/ > = > If nobody is interested then please STOP sending me these Intel "0-DAY CI > Kernel Test Service" emails. Thanks! > --- > arch/arm/include/asm/io.h | 2 ++ > 1 file changed, 2 insertions(+) > = > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index eba7cbc93b86..47cf79229b7c 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h > @@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type); > static inline void pci_ioremap_set_mem_type(int mem_type) {} > #endif > = > +#ifdef CONFIG_MMU > struct resource; > = > #define pci_remap_iospace pci_remap_iospace > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr); > +#endif > = > /* > * PCI configuration space mapping function. > -- = > 2.20.1 > = > = > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel