From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 917DCC433EF for ; Fri, 15 Jul 2022 16:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=UsUiOSIXVujvak1uarDXzCE36Jvvmrfnbh33bNewj7c=; b=J1j8MOOkdwie8c VZD05u/GEV8NKOU0hfIAOsY+dUAG3UQuGp7o0LedaJohzrWsgrBSFD920ZWPGpjG/MYWhmZRk15oz KwZfKaOuaHL1+yqShl4IGcPSdsZV75bm9VYHTctEEvAwgSj6bgsVC27N9/2644bgLRsTheJTVzVlS CDN3zX3QfMk+OGa05F0mE7EWBKvmp5dq8CZFXFtXjVSovpgoPnHnMd32FEAl1IrKuh6o9mBmrevcF fiAad1FlM/9JrVd61fIiSiHyLQ+bS6uSX86TxMDwNnreMOJ2s1+xS7r88qiM2sxir1COIbo5jp0F1 14L9zmhW7r9MxxPM2zOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCOUe-008vyN-8o; Fri, 15 Jul 2022 16:48:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCOUa-008vww-Ij for linux-arm-kernel@lists.infradead.org; Fri, 15 Jul 2022 16:48:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD935B82D5B; Fri, 15 Jul 2022 16:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29114C34115; Fri, 15 Jul 2022 16:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657903717; bh=7nCXiwhGkmmW2s7T5Yi43qsIhqbsZvIWOtkF2dkQC9s=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sSVK6zWm9ogupRm0gxfDMjRI8ElePOS+x+8CyYUFHQTS4VtN9vLPA+yr1QEYl6wA4 HUD4jWOi+9okoxF/KUhv7B8XFhdADLkwoGvo8ntFC+fAlJpSPJvYPno4jfZURA6WKg GIv0F3Y4bciNBt9Br1/4CltCL1bIK/gbbLlNrQDGQ1UJJoD3vhs4dW2ZRu6SJov4jH xfM+TTW0WtgiVWug1ym+wfD8FgmRLnFPgfIHrEY2IZOPAWDtXLLcPQCcjECaBglvAH SkLZhKytdZg5VyVxVaoUi11M1XTKL1YfbfXqerpwti8d3VeffDd727qey28g6uo9Mk 76ickshCb/cpA== Date: Fri, 15 Jul 2022 11:48:35 -0500 From: Bjorn Helgaas To: Arnd Bergmann Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , kernel test robot , kbuild-all@lists.01.org, Lorenzo Pieralisi , Bjorn Helgaas , Russell King , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU Message-ID: <20220715164835.GA1138891@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_094840_791462_3DC293A6 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 14, 2022 at 10:19:51PM +0200, Arnd Bergmann wrote: > On Thu, Jul 14, 2022 at 8:57 PM Pali Roh=E1r wrote: > > Custom ARM version of pci_remap_iospace() is implemented only for MMU > > kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU. > > > > See compilation failures: > > https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/ > > https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/ > > https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/ > > https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/ > > > > Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci= _remap_iospace()") > > Reported-by: kernel test robot > > Signed-off-by: Pali Roh=E1r > > > > --- > > > > PING!!!! Is somebody interested in fixing these compile errors? As nobo= dy > > answered to my emails where I proposed this fix more than half year ago= and > > asked for opinion... > > > > https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/ > > https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/ > > https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/ > > https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/ > > https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/ > = > Are you sure this still happens in mainline kernels? Since > commit 2f618d5ef5dd ("ARM: remove support for NOMMU ARMv4/v5") > it should no longer be possible to disable the MMU in any Arm machines > other than the Cortex-M based ones, which do not support PCI. I don't know whether it happens in mainline kernels either. But even if the 2f618d5ef5dd Kconfiggery makes MMU mostly obsolete for Arm, it seems a little weird that io.h unconditionally promises an arch-specific implementation of pci_remap_iospace(), but we only provide it when CONFIG_MMU=3Dy. It seems like it'd be a little cleaner if the same condition determined visibility of both the declaration and the definition. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel