From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEF70C43334 for ; Fri, 15 Jul 2022 21:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3328sHTWWF1gFhtxqXxE0BLnrqEOhoY1mJ5tJRPSn7Q=; b=u9WJMEmWLlnjlT t8KTm8yhe8wQ9+iosfD3hHxCXY9nDmLPLrpJU3ovzBF3a/T9g6ITrnBb01eCriGvvPa0ci7Vcl/+j lc0YMw4sSGa5RKtlLXkKSM6iosdBxBBvcuzBnFWzBmM4O3DXe28nPvIBDOg4f7txdmdruwctmGx5X 8kjuFwRpTIydAoT6LMtxJIw5m555aJ4bXfNAbvbH3y73u2Q4WFnOC2QBUDY6LMF8JBB6IWmxI3mWW n6FrpnaqZ8HrV6d9aJu80fR3GjbYM+vrzVjXd1xuXzT7z9uSuwIIvcbFQNsCi//+IzFvuuoNoS0ri KCL7Zkja07xuhy2JQCYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCSnW-00AQUi-A7; Fri, 15 Jul 2022 21:24:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCSnT-00AQTK-8n; Fri, 15 Jul 2022 21:24:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EAE96174A; Fri, 15 Jul 2022 21:24:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CE25C34115; Fri, 15 Jul 2022 21:24:25 +0000 (UTC) Date: Fri, 15 Jul 2022 17:24:23 -0400 From: Steven Rostedt To: Chunfeng Yun Cc: , Ingo Molnar , Andrew Morton , , , , Greg Kroah-Hartman Subject: Re: [for-next][PATCH 13/23] USB: mtu3: tracing: Use the new __vstring() helper Message-ID: <20220715172423.6b57b9eb@gandalf.local.home> In-Reply-To: <962e59c25e981676014157cd111db9e16e237339.camel@mediatek.com> References: <20220714164256.403842845@goodmis.org> <20220714164330.311734558@goodmis.org> <962e59c25e981676014157cd111db9e16e237339.camel@mediatek.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_142427_377242_AEFF80C8 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 15 Jul 2022 18:01:44 +0800 Chunfeng Yun wrote: > irq/254-1120100-137 [000] d..1. 266.629662: mtu3_log: > 11201000.usb: ep0_state SETUPr-speed > > "r-speed" seems the remain of last log; I found an off-by-one bug in the vstring patch. I'll rebase, test and try again. In the mean time, care to add this on top to make sure it's fixed? Thanks! -- Steve diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h index e6f8ba52a958..b18759a673c6 100644 --- a/include/linux/trace_events.h +++ b/include/linux/trace_events.h @@ -922,16 +922,16 @@ perf_trace_buf_submit(void *raw_data, int size, int rctx, u16 type, * gcc warns that you can not use a va_list in an inlined * function. But lets me make it into a macro :-/ */ -#define __trace_event_vstr_len(fmt, va) \ -({ \ - va_list __ap; \ - int __ret; \ - \ - va_copy(__ap, *(va)); \ - __ret = vsnprintf(NULL, 0, fmt, __ap); \ - va_end(__ap); \ - \ - min(__ret, TRACE_EVENT_STR_MAX); \ +#define __trace_event_vstr_len(fmt, va) \ +({ \ + va_list __ap; \ + int __ret; \ + \ + va_copy(__ap, *(va)); \ + __ret = vsnprintf(NULL, 0, fmt, __ap) + 1; \ + va_end(__ap); \ + \ + min(__ret, TRACE_EVENT_STR_MAX); \ }) #endif /* _LINUX_TRACE_EVENT_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel