From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A56B5C433EF for ; Sat, 16 Jul 2022 16:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06D9jgxOEgPOzeSs+c4NlXggiloqZ+bd6F2ecPbzC9w=; b=hQQZMfn0S4QP7u 0QNI3n78yEx5dsCby3ZkP13SsLEEqW0fXNvbUgqWhHD6KmpW00ZKgCn++n5cT0jtFVC4+dB9DRZqO 5FceCtmaWzeSV1g4IJAxWk3UGK+vtiva676abx7x9EPvqgT/lWOeJFPwtLul6xHMWDmbI853V5QFT mWLkEa23gkmrKiLEcTaSDvXXoycG2utlnnvGe6TqWHHShzT1bCbfYGr9oWV2JjQ9M5peaaANaqpqF z3A/q20Jx/6XBnqn+N7Yh1r+5ujPE98xAYrT7LbPKB5ZBUQoJgyD3qfe9k7ZUojSdCoLcJA2m+UBU /sgq0r91spb/9LkRFQXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCkSI-00H1cF-Lk; Sat, 16 Jul 2022 16:15:46 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCkSF-00H1ZV-2z for linux-arm-kernel@lists.infradead.org; Sat, 16 Jul 2022 16:15:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C10BB80AB9; Sat, 16 Jul 2022 16:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF5F8C34114; Sat, 16 Jul 2022 16:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657988139; bh=ohST+iMB3W83aZYXNrDfxksLloNkjt3mKUhrT2850fY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bq/JMz8lY+Emu5XYPEKlNVkq0hzFTdyirT5Uga+ZZBvdJY+J1njEdzgiGOnsZrwS7 H6N0+gQ9VwVyRhgeYVkvXunpD/68vc9O7mUVyO6XqTwdsoF9JUPjWGVJha5Km9cniL mDFynQoFTCTG61r5VPKpsmvB/zm6apFKPAnz8pShHAsPHlIa5s/wJD7LYAujjdjOPQ vwv6yUxTF0AXDzeHbV8zWN4xXYcMz/sZ9+B1vQvfR4p8e73vTB1yjNxiP9TKidL6BE Vv9Vik+d3WvtrxpkaS8NQVPiHFLOCrfg9lusooAvTxGjGeko5d0HZCYcE3324MPNKf 1/Ee4in1Fk6Qg== Date: Sat, 16 Jul 2022 17:25:31 +0100 From: Jonathan Cameron To: Claudiu Beznea Subject: Re: [PATCH v2 02/19] iio: adc: at91-sama5d2_adc: check return status for pressure and touch Message-ID: <20220716172531.684b2878@jic23-huawei> In-Reply-To: <20220628151631.3116454-3-claudiu.beznea@microchip.com> References: <20220628151631.3116454-1-claudiu.beznea@microchip.com> <20220628151631.3116454-3-claudiu.beznea@microchip.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220716_091543_308973_C4B0434C X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, eugen.hristev@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Jun 2022 18:16:14 +0300 Claudiu Beznea wrote: > Check return status of at91_adc_read_position() and > at91_adc_read_pressure() in at91_adc_read_info_raw(). > > Fixes: 6794e23fa3fe ("iio: adc: at91-sama5d2_adc: add support for oversampling resolution") > Signed-off-by: Claudiu Beznea > --- > drivers/iio/adc/at91-sama5d2_adc.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 32b6f157b803..c3301c749164 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -1544,8 +1544,10 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, > *val = tmp_val; > mutex_unlock(&st->lock); > iio_device_release_direct_mode(indio_dev); Prefer to keep error path out of line. if (ret < 0) return ret; return at91_adc_adjust_val_osr(); Also ends up as a slightly less invasive change. > + if (ret > 0) > + ret = at91_adc_adjust_val_osr(st, val); > > - return at91_adc_adjust_val_osr(st, val); > + return ret; > } > if (chan->type == IIO_PRESSURE) { > ret = iio_device_claim_direct_mode(indio_dev); > @@ -1558,8 +1560,10 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, > *val = tmp_val; > mutex_unlock(&st->lock); > iio_device_release_direct_mode(indio_dev); > + if (ret > 0) > + ret = at91_adc_adjust_val_osr(st, val); > > - return at91_adc_adjust_val_osr(st, val); As above. > + return ret; > } > > /* in this case we have a voltage channel */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel